mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
e961b4cd0d
* Webhooks: Allow "true"/"false" for bool values in payload body Some slack integrations encode bool fields as "true"/"false", which was previously unsupported in mattermost due to how encoding/json works. This commit adds an aliased type for bool that implements json.Unmarshaler to maintain compatibility with Slack. * Add missing copyright header to added files
58 lines
1.6 KiB
Go
58 lines
1.6 KiB
Go
// Copyright (c) 2019-present Mattermost, Inc. All Rights Reserved.
|
|
// See License.txt for license information.
|
|
|
|
package model
|
|
|
|
import (
|
|
"encoding/json"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestSlackCompatibleBool_UnmarshalJSON_True(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
payload string
|
|
}{
|
|
{name: "literal", payload: `{"title": "Foo", "value": "Bar", "short": true}`},
|
|
{name: "stringLower", payload: `{"title": "Foo", "value": "Bar", "short": "true"}`},
|
|
{name: "stringMixed", payload: `{"title": "Foo", "value": "Bar", "short": "True"}`},
|
|
{name: "stringUpper", payload: `{"title": "Foo", "value": "Bar", "short": "TRUE"}`},
|
|
}
|
|
|
|
for _, tt := range cases {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
field := &SlackAttachmentField{}
|
|
|
|
err := json.Unmarshal([]byte(tt.payload), field)
|
|
|
|
require.NoError(t, err)
|
|
require.True(t, bool(field.Short))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestSlackCompatibleBool_UnmarshalJSON_False(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
payload string
|
|
}{
|
|
{name: "literal", payload: `{"title": "Foo", "value": "Bar", "short": false}`},
|
|
{name: "stringLower", payload: `{"title": "Foo", "value": "Bar", "short": "false"}`},
|
|
{name: "stringMixed", payload: `{"title": "Foo", "value": "Bar", "short": "False"}`},
|
|
{name: "stringUpper", payload: `{"title": "Foo", "value": "Bar", "short": "FALSE"}`},
|
|
}
|
|
|
|
for _, tt := range cases {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
field := &SlackAttachmentField{}
|
|
|
|
err := json.Unmarshal([]byte(tt.payload), field)
|
|
|
|
require.NoError(t, err)
|
|
require.False(t, bool(field.Short))
|
|
})
|
|
}
|
|
}
|