mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
* MM-14145: The config store Set will now Save automatically When UpdateConfig (and configStore.Set) is called in admin.go and config.go, commonStore.Set now takes a store-specific persist function. It uses that persist function to save the configuration automatically. Removed: Now callers do not have to call configStore.Save or app.PersistConfig, and those functions have been removed. Possible downside: this means a "failed to persist config" error can now be thrown during a app.UpdateConfig or commonStore.Set call. But considering application code never really sets a config without saving it (except in the test cases, which were testing that -- see below), it seems fine to group these responsibilities. Also removed: tests for 'set without save'. Since that can not happen anymore, the tests are not needed. * Removed Save completely, cleaned up formatting, joined save test with set tests. * fixed shadowed variable error
213 lines
5.7 KiB
Go
213 lines
5.7 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See License.txt for license information.
|
|
|
|
package config
|
|
|
|
import (
|
|
"bytes"
|
|
"database/sql"
|
|
"io/ioutil"
|
|
"net/url"
|
|
"strings"
|
|
|
|
"github.com/jmoiron/sqlx"
|
|
"github.com/pkg/errors"
|
|
|
|
"github.com/mattermost/mattermost-server/mlog"
|
|
"github.com/mattermost/mattermost-server/model"
|
|
|
|
// Load the MySQL driver
|
|
_ "github.com/go-sql-driver/mysql"
|
|
// Load the Postgres driver
|
|
_ "github.com/lib/pq"
|
|
)
|
|
|
|
// DatabaseStore is a config store backed by a database.
|
|
type DatabaseStore struct {
|
|
commonStore
|
|
|
|
originalDsn string
|
|
driverName string
|
|
dataSourceName string
|
|
db *sqlx.DB
|
|
}
|
|
|
|
// NewDatabaseStore creates a new instance of a config store backed by the given database.
|
|
func NewDatabaseStore(dsn string) (ds *DatabaseStore, err error) {
|
|
driverName, dataSourceName, err := parseDSN(dsn)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "invalid DSN")
|
|
}
|
|
|
|
db, err := sqlx.Open(driverName, dataSourceName)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "failed to connect to %s database", driverName)
|
|
}
|
|
|
|
ds = &DatabaseStore{
|
|
driverName: driverName,
|
|
originalDsn: dsn,
|
|
dataSourceName: dataSourceName,
|
|
db: db,
|
|
}
|
|
if err = initializeConfigurationsTable(ds.db); err != nil {
|
|
return nil, errors.Wrap(err, "failed to initialize")
|
|
}
|
|
|
|
if err = ds.Load(); err != nil {
|
|
return nil, errors.Wrap(err, "failed to load")
|
|
}
|
|
|
|
return ds, nil
|
|
}
|
|
|
|
// initializeConfigurationsTable ensures the requisite tables in place to form the backing store.
|
|
func initializeConfigurationsTable(db *sqlx.DB) error {
|
|
_, err := db.Exec(`
|
|
CREATE TABLE IF NOT EXISTS Configurations (
|
|
Id VARCHAR(26) PRIMARY KEY,
|
|
Value TEXT NOT NULL,
|
|
CreateAt BIGINT NOT NULL,
|
|
Active BOOLEAN NULL UNIQUE
|
|
)
|
|
`)
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to create Configurations table")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// parseDSN splits up a connection string into a driver name and data source name.
|
|
//
|
|
// For example:
|
|
// mysql://mmuser:mostest@dockerhost:5432/mattermost_test
|
|
// returns
|
|
// driverName = mysql
|
|
// dataSourceName = mmuser:mostest@dockerhost:5432/mattermost_test
|
|
//
|
|
// By contrast, a Postgres DSN is returned unmodified.
|
|
func parseDSN(dsn string) (string, string, error) {
|
|
// Treat the DSN as the URL that it is.
|
|
u, err := url.Parse(dsn)
|
|
if err != nil {
|
|
return "", "", errors.Wrap(err, "failed to parse DSN as URL")
|
|
}
|
|
|
|
scheme := u.Scheme
|
|
switch scheme {
|
|
case "mysql":
|
|
// Strip off the mysql:// for the dsn with which to connect.
|
|
u.Scheme = ""
|
|
dsn = strings.TrimPrefix(u.String(), "//")
|
|
|
|
case "postgres":
|
|
// No changes required
|
|
|
|
default:
|
|
return "", "", errors.Wrapf(err, "unsupported scheme %s", scheme)
|
|
}
|
|
|
|
return scheme, dsn, nil
|
|
}
|
|
|
|
// Set replaces the current configuration in its entirety and updates the backing store.
|
|
func (ds *DatabaseStore) Set(newCfg *model.Config) (*model.Config, error) {
|
|
return ds.commonStore.set(newCfg, nil, ds.persist)
|
|
|
|
}
|
|
|
|
// persist writes the configuration to the configured database.
|
|
func (ds *DatabaseStore) persist(cfg *model.Config) error {
|
|
b, err := marshalConfig(cfg)
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to serialize")
|
|
}
|
|
|
|
id := model.NewId()
|
|
value := string(b)
|
|
createAt := model.GetMillis()
|
|
|
|
tx, err := ds.db.Beginx()
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to begin transaction")
|
|
}
|
|
defer func() {
|
|
// Rollback after Commit just returns sql.ErrTxDone.
|
|
if err := tx.Rollback(); err != nil && err != sql.ErrTxDone {
|
|
mlog.Error("Failed to rollback configuration transaction", mlog.Err(err))
|
|
}
|
|
}()
|
|
|
|
params := map[string]interface{}{
|
|
"id": id,
|
|
"value": value,
|
|
"create_at": createAt,
|
|
"key": "ConfigurationId",
|
|
}
|
|
|
|
if _, err := tx.Exec("UPDATE Configurations SET Active = NULL WHERE Active"); err != nil {
|
|
return errors.Wrap(err, "failed to deactivate current configuration")
|
|
}
|
|
|
|
if _, err := tx.NamedExec("INSERT INTO Configurations (Id, Value, CreateAt, Active) VALUES (:id, :value, :create_at, TRUE)", params); err != nil {
|
|
return errors.Wrap(err, "failed to record new configuration")
|
|
}
|
|
|
|
if err := tx.Commit(); err != nil {
|
|
return errors.Wrap(err, "failed to commit transaction")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// Load updates the current configuration from the backing store.
|
|
func (ds *DatabaseStore) Load() (err error) {
|
|
var needsSave bool
|
|
var configurationData []byte
|
|
|
|
row := ds.db.QueryRow("SELECT Value FROM Configurations WHERE Active")
|
|
if err = row.Scan(&configurationData); err != nil && err != sql.ErrNoRows {
|
|
return errors.Wrap(err, "failed to query active configuration")
|
|
}
|
|
|
|
// Initialize from the default config if no active configuration could be found.
|
|
if len(configurationData) == 0 {
|
|
needsSave = true
|
|
|
|
defaultCfg := model.Config{}
|
|
defaultCfg.SetDefaults()
|
|
|
|
// Assume the database storing the config is also to be used for the application.
|
|
// This can be overridden using environment variables on first start if necessary,
|
|
// or changed from the system console afterwards.
|
|
*defaultCfg.SqlSettings.DriverName = ds.driverName
|
|
*defaultCfg.SqlSettings.DataSource = ds.dataSourceName
|
|
|
|
configurationData, err = marshalConfig(&defaultCfg)
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to serialize default config")
|
|
}
|
|
}
|
|
|
|
return ds.commonStore.load(ioutil.NopCloser(bytes.NewReader(configurationData)), needsSave, ds.persist)
|
|
}
|
|
|
|
// String returns the path to the database backing the config, masking the password.
|
|
func (ds *DatabaseStore) String() string {
|
|
u, _ := url.Parse(ds.originalDsn)
|
|
|
|
// Strip out the password to avoid leaking in logs.
|
|
u.User = url.User(u.User.Username())
|
|
|
|
return u.String()
|
|
}
|
|
|
|
// Close cleans up resources associated with the store.
|
|
func (ds *DatabaseStore) Close() error {
|
|
ds.configLock.Lock()
|
|
defer ds.configLock.Unlock()
|
|
|
|
return ds.db.Close()
|
|
}
|