mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
809a16458f
Only a handful of critical errors are present in the codebase. They all occur during server startup (in `app.StartServer()`). Currently, when one of these critical error occurs, it is simpled mentionned in the logs – then the error is discarded, and the app attempts to continue the execution (and probably fails pretty quickly in a weird way). Rather than continuing operations in an unknow state, these errors should trigger a clean exit. This commit rewrites critical startup errors to be correctly propagated, logged, and then terminate the command execution. Additionnaly, it makes the server return a proper error code to the shell.
150 lines
3.2 KiB
Go
150 lines
3.2 KiB
Go
// Copyright (c) 2016-present Mattermost, Inc. All Rights Reserved.
|
|
// See License.txt for license information.
|
|
|
|
package main
|
|
|
|
import (
|
|
"bufio"
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
|
|
"os/signal"
|
|
"syscall"
|
|
|
|
"github.com/mattermost/mattermost-server/api"
|
|
"github.com/mattermost/mattermost-server/api4"
|
|
"github.com/mattermost/mattermost-server/model"
|
|
"github.com/mattermost/mattermost-server/utils"
|
|
"github.com/mattermost/mattermost-server/wsapi"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
var testCmd = &cobra.Command{
|
|
Use: "test",
|
|
Short: "Testing Commands",
|
|
Hidden: true,
|
|
}
|
|
|
|
var runWebClientTestsCmd = &cobra.Command{
|
|
Use: "web_client_tests",
|
|
Short: "Run the web client tests",
|
|
RunE: webClientTestsCmdF,
|
|
}
|
|
|
|
var runServerForWebClientTestsCmd = &cobra.Command{
|
|
Use: "web_client_tests_server",
|
|
Short: "Run the server configured for running the web client tests against it",
|
|
RunE: serverForWebClientTestsCmdF,
|
|
}
|
|
|
|
func init() {
|
|
testCmd.AddCommand(
|
|
runWebClientTestsCmd,
|
|
runServerForWebClientTestsCmd,
|
|
)
|
|
}
|
|
|
|
func webClientTestsCmdF(cmd *cobra.Command, args []string) error {
|
|
a, err := initDBCommandContextCobra(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer a.Shutdown()
|
|
|
|
utils.InitTranslations(a.Config().LocalizationSettings)
|
|
serverErr := a.StartServer()
|
|
if serverErr != nil {
|
|
return serverErr
|
|
}
|
|
|
|
api4.Init(a, a.Srv.Router, false)
|
|
api.Init(a, a.Srv.Router)
|
|
wsapi.Init(a, a.Srv.WebSocketRouter)
|
|
a.UpdateConfig(setupClientTests)
|
|
runWebClientTests()
|
|
|
|
return nil
|
|
}
|
|
|
|
func serverForWebClientTestsCmdF(cmd *cobra.Command, args []string) error {
|
|
a, err := initDBCommandContextCobra(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer a.Shutdown()
|
|
|
|
utils.InitTranslations(a.Config().LocalizationSettings)
|
|
serverErr := a.StartServer()
|
|
if serverErr != nil {
|
|
return serverErr
|
|
}
|
|
|
|
api4.Init(a, a.Srv.Router, false)
|
|
api.Init(a, a.Srv.Router)
|
|
wsapi.Init(a, a.Srv.WebSocketRouter)
|
|
a.UpdateConfig(setupClientTests)
|
|
|
|
c := make(chan os.Signal, 1)
|
|
signal.Notify(c, os.Interrupt, syscall.SIGINT, syscall.SIGTERM)
|
|
<-c
|
|
|
|
return nil
|
|
}
|
|
|
|
func setupClientTests(cfg *model.Config) {
|
|
*cfg.TeamSettings.EnableOpenServer = true
|
|
*cfg.ServiceSettings.EnableCommands = false
|
|
*cfg.ServiceSettings.EnableOnlyAdminIntegrations = false
|
|
*cfg.ServiceSettings.EnableCustomEmoji = true
|
|
cfg.ServiceSettings.EnableIncomingWebhooks = false
|
|
cfg.ServiceSettings.EnableOutgoingWebhooks = false
|
|
}
|
|
|
|
func executeTestCommand(cmd *exec.Cmd) {
|
|
cmdOutPipe, err := cmd.StdoutPipe()
|
|
if err != nil {
|
|
CommandPrintErrorln("Failed to run tests")
|
|
os.Exit(1)
|
|
return
|
|
}
|
|
|
|
cmdErrOutPipe, err := cmd.StderrPipe()
|
|
if err != nil {
|
|
CommandPrintErrorln("Failed to run tests")
|
|
os.Exit(1)
|
|
return
|
|
}
|
|
|
|
cmdOutReader := bufio.NewScanner(cmdOutPipe)
|
|
cmdErrOutReader := bufio.NewScanner(cmdErrOutPipe)
|
|
go func() {
|
|
for cmdOutReader.Scan() {
|
|
fmt.Println(cmdOutReader.Text())
|
|
}
|
|
}()
|
|
|
|
go func() {
|
|
for cmdErrOutReader.Scan() {
|
|
fmt.Println(cmdErrOutReader.Text())
|
|
}
|
|
}()
|
|
|
|
if err := cmd.Run(); err != nil {
|
|
CommandPrintErrorln("Client Tests failed")
|
|
os.Exit(1)
|
|
return
|
|
}
|
|
}
|
|
|
|
func runWebClientTests() {
|
|
if webappDir := os.Getenv("WEBAPP_DIR"); webappDir != "" {
|
|
os.Chdir(webappDir)
|
|
} else {
|
|
os.Chdir("../mattermost-webapp")
|
|
}
|
|
|
|
cmd := exec.Command("npm", "test")
|
|
executeTestCommand(cmd)
|
|
}
|