mirror of
https://github.com/mattermost/mattermost.git
synced 2026-08-27 05:37:15 -05:00
Daniel Schalla
a3cdef8b0f
* Fix docs-impact-review hitting max turns by adding filesystem tools The claude-code-action workflow instructs Claude to search ./docs/source/ for existing documentation, but only grants gh and MCP tools. Claude repeatedly attempts filesystem access, gets denied, and exhausts the 30-turn limit. Add find, grep, cat, and ls to --allowedTools so the docs checkout can actually be searched. * Harden docs-impact-review against prompt-injection exfiltration - Drop find from allowedTools (unsafe due to -exec) - Scope ls, cat, grep to ./docs/source* paths only - Add persist-credentials: false to both checkout steps to prevent token extraction from .git/config * Use built-in Read/Glob/Grep tools instead of scoped Bash wrappers Built-in tools cannot execute commands, chain via shell operators, or abuse flags like -exec, making them inherently safer than any Bash glob pattern for filesystem access.