mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
62b57143c8
* Refactor to use structured logging * Properly formatted with gofmt * created interface Cache, but construction of cache is still coupled. * Implementing cache factories to build caches * Simple redis implementation without error handling. Keys and values by default are string * refactor NewLocalCacheLayer to inject cache factory * Removed redis impl to focus on cache abstraction * CacheFactory injected on sqlsupplier and saved in Store struct * remove useless private method * replace concrete declaration of lru cache to cache abstraction * discard spaces * Renamed factory to provider because concrete implementations of factories may hold an state (such as a redis client for example) * refactor to include all caches in the same package cache and subpackages * method close cache. This method will be used for concrete implementations that need to release resources (close a connection, etc) * closing cacheprovider and releasing resources while closing sql store * fixed merge conflict fail * gofmt files * remove unused property from post_store * naming refactor to avoid stutter. Added godocs on interface * Store doesnt know anything about the cache and provider. Cache provider will be built after loading config and injected in localCacheLayer * fixed broken test * cache provider initialized before RunOldAppInitialization which initializes the localcachelayer * move statusCache to server to initialize it with the new cache provider * update terms_service and channel_layer to have new cacheProvider * gofmt * Add Connect method to the cache provider * mock cacheprovider in user_layer_test Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com> Co-authored-by: mattermod <mattermod@users.noreply.github.com>
74 lines
2.7 KiB
Go
74 lines
2.7 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package localcachelayer
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/mattermost/mattermost-server/v5/model"
|
|
"github.com/mattermost/mattermost-server/v5/store/storetest"
|
|
"github.com/mattermost/mattermost-server/v5/store/storetest/mocks"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestSchemeStore(t *testing.T) {
|
|
StoreTest(t, storetest.TestSchemeStore)
|
|
}
|
|
|
|
func TestSchemeStoreCache(t *testing.T) {
|
|
fakeScheme := model.Scheme{Id: "123", Name: "scheme-name"}
|
|
|
|
t.Run("first call not cached, second cached and returning same data", func(t *testing.T) {
|
|
mockStore := getMockStore()
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider)
|
|
|
|
scheme, err := cachedStore.Scheme().Get("123")
|
|
require.Nil(t, err)
|
|
assert.Equal(t, scheme, &fakeScheme)
|
|
mockStore.Scheme().(*mocks.SchemeStore).AssertNumberOfCalls(t, "Get", 1)
|
|
require.Nil(t, err)
|
|
assert.Equal(t, scheme, &fakeScheme)
|
|
cachedStore.Scheme().Get("123")
|
|
mockStore.Scheme().(*mocks.SchemeStore).AssertNumberOfCalls(t, "Get", 1)
|
|
})
|
|
|
|
t.Run("first call not cached, save, and then not cached again", func(t *testing.T) {
|
|
mockStore := getMockStore()
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider)
|
|
|
|
cachedStore.Scheme().Get("123")
|
|
mockStore.Scheme().(*mocks.SchemeStore).AssertNumberOfCalls(t, "Get", 1)
|
|
cachedStore.Scheme().Save(&fakeScheme)
|
|
cachedStore.Scheme().Get("123")
|
|
mockStore.Scheme().(*mocks.SchemeStore).AssertNumberOfCalls(t, "Get", 2)
|
|
})
|
|
|
|
t.Run("first call not cached, delete, and then not cached again", func(t *testing.T) {
|
|
mockStore := getMockStore()
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider)
|
|
|
|
cachedStore.Scheme().Get("123")
|
|
mockStore.Scheme().(*mocks.SchemeStore).AssertNumberOfCalls(t, "Get", 1)
|
|
cachedStore.Scheme().Delete("123")
|
|
cachedStore.Scheme().Get("123")
|
|
mockStore.Scheme().(*mocks.SchemeStore).AssertNumberOfCalls(t, "Get", 2)
|
|
})
|
|
|
|
t.Run("first call not cached, permanent delete all, and then not cached again", func(t *testing.T) {
|
|
mockStore := getMockStore()
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider)
|
|
|
|
cachedStore.Scheme().Get("123")
|
|
mockStore.Scheme().(*mocks.SchemeStore).AssertNumberOfCalls(t, "Get", 1)
|
|
cachedStore.Scheme().PermanentDeleteAll()
|
|
cachedStore.Scheme().Get("123")
|
|
mockStore.Scheme().(*mocks.SchemeStore).AssertNumberOfCalls(t, "Get", 2)
|
|
})
|
|
}
|