mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
94827d06a3
th.InitBasic initializes users, channels, and teams. But a lot of tests don't use it at all, causing unncessary delays. A single InitBasic call takes around 400ms. This PR removes 71 of them, approximately shaving off 28 seconds. Arguably, this would be more because some tests run in loops.
289 lines
10 KiB
Go
289 lines
10 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/mattermost/mattermost-server/v5/model"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
type testWriter struct {
|
|
write func(p []byte) (int, error)
|
|
}
|
|
|
|
func (tw testWriter) Write(p []byte) (int, error) {
|
|
return tw.write(p)
|
|
}
|
|
|
|
func TestExportPermissions(t *testing.T) {
|
|
th := Setup(t)
|
|
defer th.TearDown()
|
|
|
|
var scheme *model.Scheme
|
|
var roles []*model.Role
|
|
withMigrationMarkedComplete(th, func() {
|
|
scheme, roles = th.CreateScheme()
|
|
})
|
|
|
|
results := [][]byte{}
|
|
|
|
tw := testWriter{
|
|
write: func(p []byte) (int, error) {
|
|
results = append(results, p)
|
|
return len(p), nil
|
|
},
|
|
}
|
|
|
|
err := th.App.ExportPermissions(tw)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
if len(results) == 0 {
|
|
t.Error("Expected export to have returned something.")
|
|
}
|
|
|
|
firstResult := results[0]
|
|
|
|
var row map[string]interface{}
|
|
err = json.Unmarshal(firstResult, &row)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
getRoleByName := func(name string) string {
|
|
for _, role := range roles {
|
|
if role.Name == name {
|
|
return role.Name
|
|
}
|
|
}
|
|
return ""
|
|
}
|
|
|
|
expectations := map[string]func(str string) string{
|
|
scheme.DisplayName: func(str string) string { return row["display_name"].(string) },
|
|
scheme.Name: func(str string) string { return row["name"].(string) },
|
|
scheme.Description: func(str string) string { return row["description"].(string) },
|
|
scheme.Scope: func(str string) string { return row["scope"].(string) },
|
|
scheme.DefaultTeamAdminRole: func(str string) string { return getRoleByName(str) },
|
|
scheme.DefaultTeamUserRole: func(str string) string { return getRoleByName(str) },
|
|
scheme.DefaultTeamGuestRole: func(str string) string { return getRoleByName(str) },
|
|
scheme.DefaultChannelAdminRole: func(str string) string { return getRoleByName(str) },
|
|
scheme.DefaultChannelUserRole: func(str string) string { return getRoleByName(str) },
|
|
scheme.DefaultChannelGuestRole: func(str string) string { return getRoleByName(str) },
|
|
}
|
|
|
|
for key, valF := range expectations {
|
|
expected := key
|
|
actual := valF(key)
|
|
if actual != expected {
|
|
t.Errorf("Expected %v but got %v.", expected, actual)
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
func TestImportPermissions(t *testing.T) {
|
|
th := Setup(t)
|
|
defer th.TearDown()
|
|
|
|
name := model.NewId()
|
|
displayName := model.NewId()
|
|
description := "my test description"
|
|
scope := model.SCHEME_SCOPE_CHANNEL
|
|
roleName1 := model.NewId()
|
|
roleName2 := model.NewId()
|
|
|
|
var results []*model.Scheme
|
|
var beforeCount int
|
|
withMigrationMarkedComplete(th, func() {
|
|
|
|
var appErr *model.AppError
|
|
results, appErr = th.App.GetSchemes(scope, 0, 100)
|
|
if appErr != nil {
|
|
panic(appErr)
|
|
}
|
|
beforeCount = len(results)
|
|
|
|
json := fmt.Sprintf(`{"display_name":"%v","name":"%v","description":"%v","scope":"%v","default_team_admin_role":"","default_team_user_role":"","default_channel_admin_role":"%v","default_channel_user_role":"%v","roles":[{"id":"yzfx3g9xjjfw8cqo6bpn33xr7o","name":"%v","display_name":"Channel Admin Role for Scheme my_scheme_1526475590","description":"","create_at":1526475589687,"update_at":1526475589687,"delete_at":0,"permissions":["manage_channel_roles"],"scheme_managed":true,"built_in":false},{"id":"a7s3cp4n33dfxbsrmyh9djao3a","name":"%v","display_name":"Channel User Role for Scheme my_scheme_1526475590","description":"","create_at":1526475589688,"update_at":1526475589688,"delete_at":0,"permissions":["read_channel","add_reaction","remove_reaction","manage_public_channel_members","upload_file","get_public_link","create_post","use_slash_commands","manage_private_channel_members","delete_post","edit_post"],"scheme_managed":true,"built_in":false}]}`, displayName, name, description, scope, roleName1, roleName2, roleName1, roleName2)
|
|
r := strings.NewReader(json)
|
|
|
|
err := th.App.ImportPermissions(r)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
results, appErr = th.App.GetSchemes(scope, 0, 100)
|
|
if appErr != nil {
|
|
panic(appErr)
|
|
}
|
|
|
|
})
|
|
|
|
actual := len(results)
|
|
expected := beforeCount + 1
|
|
if actual != expected {
|
|
t.Errorf("Expected %v roles but got %v.", expected, actual)
|
|
}
|
|
|
|
newScheme := results[0]
|
|
|
|
channelAdminRole, appErr := th.App.GetRoleByName(newScheme.DefaultChannelAdminRole)
|
|
if appErr != nil {
|
|
t.Error(appErr)
|
|
}
|
|
|
|
channelUserRole, appErr := th.App.GetRoleByName(newScheme.DefaultChannelUserRole)
|
|
if appErr != nil {
|
|
t.Error(appErr)
|
|
}
|
|
|
|
channelGuestRole, appErr := th.App.GetRoleByName(newScheme.DefaultChannelGuestRole)
|
|
if appErr != nil {
|
|
t.Error(appErr)
|
|
}
|
|
|
|
expectations := map[string]string{
|
|
newScheme.DisplayName: displayName,
|
|
newScheme.Name: name,
|
|
newScheme.Description: description,
|
|
newScheme.Scope: scope,
|
|
newScheme.DefaultTeamAdminRole: "",
|
|
newScheme.DefaultTeamUserRole: "",
|
|
newScheme.DefaultTeamGuestRole: "",
|
|
channelAdminRole.Name: newScheme.DefaultChannelAdminRole,
|
|
channelUserRole.Name: newScheme.DefaultChannelUserRole,
|
|
channelGuestRole.Name: newScheme.DefaultChannelGuestRole,
|
|
}
|
|
|
|
for actual, expected := range expectations {
|
|
if actual != expected {
|
|
t.Errorf("Expected %v but got %v.", expected, actual)
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
func TestImportPermissions_idempotentScheme(t *testing.T) {
|
|
th := Setup(t)
|
|
defer th.TearDown()
|
|
|
|
name := model.NewId()
|
|
displayName := model.NewId()
|
|
description := "my test description"
|
|
scope := model.SCHEME_SCOPE_CHANNEL
|
|
roleName1 := model.NewId()
|
|
roleName2 := model.NewId()
|
|
|
|
json := fmt.Sprintf(`{"display_name":"%v","name":"%v","description":"%v","scope":"%v","default_team_admin_role":"","default_team_user_role":"","default_channel_admin_role":"%v","default_channel_user_role":"%v","roles":[{"id":"yzfx3g9xjjfw8cqo6bpn33xr7o","name":"%v","display_name":"Channel Admin Role for Scheme my_scheme_1526475590","description":"","create_at":1526475589687,"update_at":1526475589687,"delete_at":0,"permissions":["manage_channel_roles"],"scheme_managed":true,"built_in":false},{"id":"a7s3cp4n33dfxbsrmyh9djao3a","name":"%v","display_name":"Channel User Role for Scheme my_scheme_1526475590","description":"","create_at":1526475589688,"update_at":1526475589688,"delete_at":0,"permissions":["read_channel","add_reaction","remove_reaction","manage_public_channel_members","upload_file","get_public_link","create_post","use_slash_commands","manage_private_channel_members","delete_post","edit_post"],"scheme_managed":true,"built_in":false}]}`, displayName, name, description, scope, roleName1, roleName2, roleName1, roleName2)
|
|
jsonl := strings.Repeat(json+"\n", 4)
|
|
r := strings.NewReader(jsonl)
|
|
|
|
var results []*model.Scheme
|
|
var expected int
|
|
withMigrationMarkedComplete(th, func() {
|
|
var appErr *model.AppError
|
|
results, appErr = th.App.GetSchemes(model.SCHEME_SCOPE_CHANNEL, 0, 100)
|
|
if appErr != nil {
|
|
panic(appErr)
|
|
}
|
|
expected = len(results)
|
|
|
|
err := th.App.ImportPermissions(r)
|
|
if err == nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
results, appErr = th.App.GetSchemes(model.SCHEME_SCOPE_CHANNEL, 0, 100)
|
|
if appErr != nil {
|
|
panic(appErr)
|
|
}
|
|
})
|
|
actual := len(results)
|
|
|
|
if expected != actual {
|
|
t.Errorf("Expected count to be %v but got %v", expected, actual)
|
|
}
|
|
|
|
}
|
|
|
|
func TestImportPermissions_schemeDeletedOnRoleFailure(t *testing.T) {
|
|
th := Setup(t)
|
|
defer th.TearDown()
|
|
|
|
name := model.NewId()
|
|
displayName := model.NewId()
|
|
description := "my test description"
|
|
scope := "invalid scope"
|
|
roleName1 := model.NewId()
|
|
roleName2 := model.NewId()
|
|
|
|
jsonl := fmt.Sprintf(`{"display_name":"%v","name":"%v","description":"%v","scope":"%v","default_team_admin_role":"","default_team_user_role":"","default_channel_admin_role":"%v","default_channel_user_role":"%v","roles":[{"id":"yzfx3g9xjjfw8cqo6bpn33xr7o","name":"%v","display_name":"Channel Admin Role for Scheme my_scheme_1526475590","description":"","create_at":1526475589687,"update_at":1526475589687,"delete_at":0,"permissions":["manage_channel_roles"],"scheme_managed":true,"built_in":false},{"id":"a7s3cp4n33dfxbsrmyh9djao3a","name":"%v","display_name":"Channel User Role for Scheme my_scheme_1526475590","description":"","create_at":1526475589688,"update_at":1526475589688,"delete_at":0,"permissions":["read_channel","add_reaction","remove_reaction","manage_public_channel_members","upload_file","get_public_link","create_post","use_slash_commands","manage_private_channel_members","delete_post","edit_post"],"scheme_managed":true,"built_in":false}]}`, displayName, name, description, scope, roleName1, roleName2, roleName1, roleName2)
|
|
r := strings.NewReader(jsonl)
|
|
|
|
var results []*model.Scheme
|
|
var expected int
|
|
withMigrationMarkedComplete(th, func() {
|
|
var appErr *model.AppError
|
|
results, appErr = th.App.GetSchemes(model.SCHEME_SCOPE_CHANNEL, 0, 100)
|
|
if appErr != nil {
|
|
panic(appErr)
|
|
}
|
|
expected = len(results)
|
|
|
|
err := th.App.ImportPermissions(r)
|
|
if err == nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
results, appErr = th.App.GetSchemes(model.SCHEME_SCOPE_CHANNEL, 0, 100)
|
|
if appErr != nil {
|
|
panic(appErr)
|
|
}
|
|
})
|
|
actual := len(results)
|
|
|
|
if expected != actual {
|
|
t.Errorf("Expected count to be %v but got %v", expected, actual)
|
|
}
|
|
|
|
}
|
|
|
|
func TestMigration(t *testing.T) {
|
|
th := Setup(t)
|
|
defer th.TearDown()
|
|
|
|
role, err := th.App.GetRoleByName(model.SYSTEM_ADMIN_ROLE_ID)
|
|
require.Nil(t, err)
|
|
assert.Contains(t, role.Permissions, model.PERMISSION_CREATE_EMOJIS.Id)
|
|
assert.Contains(t, role.Permissions, model.PERMISSION_DELETE_EMOJIS.Id)
|
|
assert.Contains(t, role.Permissions, model.PERMISSION_DELETE_OTHERS_EMOJIS.Id)
|
|
assert.Contains(t, role.Permissions, model.PERMISSION_USE_GROUP_MENTIONS.Id)
|
|
|
|
th.App.ResetPermissionsSystem()
|
|
|
|
role, err = th.App.GetRoleByName(model.SYSTEM_ADMIN_ROLE_ID)
|
|
require.Nil(t, err)
|
|
assert.Contains(t, role.Permissions, model.PERMISSION_CREATE_EMOJIS.Id)
|
|
assert.Contains(t, role.Permissions, model.PERMISSION_DELETE_EMOJIS.Id)
|
|
assert.Contains(t, role.Permissions, model.PERMISSION_DELETE_OTHERS_EMOJIS.Id)
|
|
assert.Contains(t, role.Permissions, model.PERMISSION_USE_GROUP_MENTIONS.Id)
|
|
}
|
|
|
|
func withMigrationMarkedComplete(th *TestHelper, f func()) {
|
|
// Mark the migration as done.
|
|
th.App.Srv().Store.System().PermanentDeleteByName(model.MIGRATION_KEY_ADVANCED_PERMISSIONS_PHASE_2)
|
|
th.App.Srv().Store.System().Save(&model.System{Name: model.MIGRATION_KEY_ADVANCED_PERMISSIONS_PHASE_2, Value: "true"})
|
|
// Un-mark the migration at the end of the test.
|
|
defer func() {
|
|
th.App.Srv().Store.System().PermanentDeleteByName(model.MIGRATION_KEY_ADVANCED_PERMISSIONS_PHASE_2)
|
|
}()
|
|
f()
|
|
}
|