mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
9481a4f0ef
* Bumping version to: 3.2.0-rc1 * PLT-2863 fixing bad merge that broke this PR (#3523) * PLT-2863 adding remove user from team * PLT-2863 adding the client side UI * Fixing trailing space * Fixing reported issues * Adding documentatino * Switching to final javascript driver * Fixing bad merge * Fixing bad merge * PLT-3538 Fix Login page doesn't show SAML option if gitlab is enabled (#3524) * Login error messages fix (#3525) * daily translations 20160708 (#3533) * Fixed permissions when getting a file attachment to use the correct user id (#3535) * PLT-3575 Fix Cannot upload certificates with .cer file extension on SAML (#3534) * PLT-3560 blocking adding to channel once user is removed (#3537) * Always allow system admins to see the Integrations sidebar (#3536) * Plt 3475 - Post control improvements (#3538) * Adding class to post when dropdown is active. * plt-3475 - Post controls improvements * daily translations 20160711 (#3544)
1468 lines
47 KiB
Go
1468 lines
47 KiB
Go
// Copyright (c) 2015 Mattermost, Inc. All Rights Reserved.
|
|
// See License.txt for license information.
|
|
|
|
package api
|
|
|
|
import (
|
|
"github.com/mattermost/platform/model"
|
|
"github.com/mattermost/platform/store"
|
|
"github.com/mattermost/platform/utils"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestCreateChannel(t *testing.T) {
|
|
th := Setup().InitBasic().InitSystemAdmin()
|
|
Client := th.BasicClient
|
|
SystemAdminClient := th.SystemAdminClient
|
|
team := th.BasicTeam
|
|
Client.Must(Client.Logout())
|
|
team2 := th.CreateTeam(th.BasicClient)
|
|
th.LoginBasic()
|
|
th.BasicClient.SetTeamId(team.Id)
|
|
|
|
channel := model.Channel{DisplayName: "Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
rchannel, err := Client.CreateChannel(&channel)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if rchannel.Data.(*model.Channel).Name != channel.Name {
|
|
t.Fatal("full name didn't match")
|
|
}
|
|
|
|
rget := Client.Must(Client.GetChannels("")).Data.(*model.ChannelList)
|
|
nameMatch := false
|
|
for _, c := range rget.Channels {
|
|
if c.Name == channel.Name {
|
|
nameMatch = true
|
|
}
|
|
}
|
|
|
|
if !nameMatch {
|
|
t.Fatal("Did not create channel with correct name")
|
|
}
|
|
|
|
if _, err := Client.CreateChannel(rchannel.Data.(*model.Channel)); err == nil {
|
|
t.Fatal("Cannot create an existing")
|
|
}
|
|
|
|
savedId := rchannel.Data.(*model.Channel).Id
|
|
|
|
rchannel.Data.(*model.Channel).Id = ""
|
|
if _, err := Client.CreateChannel(rchannel.Data.(*model.Channel)); err != nil {
|
|
if err.Message != "A channel with that URL already exists" {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
if _, err := Client.DoApiPost(Client.GetTeamRoute()+"/channels/create", "garbage"); err == nil {
|
|
t.Fatal("should have been an error")
|
|
}
|
|
|
|
Client.DeleteChannel(savedId)
|
|
if _, err := Client.CreateChannel(rchannel.Data.(*model.Channel)); err != nil {
|
|
if err.Message != "A channel with that URL was previously created" {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
channel = model.Channel{DisplayName: "Channel on Different Team", Name: "aaaa" + model.NewId() + "abbb", Type: model.CHANNEL_OPEN, TeamId: team2.Id}
|
|
|
|
if _, err := Client.CreateChannel(&channel); err.StatusCode != http.StatusForbidden {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
channel = model.Channel{DisplayName: "Channel With No TeamId", Name: "aaaa" + model.NewId() + "abbb", Type: model.CHANNEL_OPEN, TeamId: ""}
|
|
|
|
if _, err := Client.CreateChannel(&channel); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
channel = model.Channel{DisplayName: "Test API Name", Name: model.NewId() + "__" + model.NewId(), Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
|
|
if _, err := Client.CreateChannel(&channel); err == nil {
|
|
t.Fatal("Should have errored out on invalid '__' character")
|
|
}
|
|
|
|
channel = model.Channel{DisplayName: "Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_DIRECT, TeamId: team.Id}
|
|
|
|
if _, err := Client.CreateChannel(&channel); err == nil {
|
|
t.Fatal("Should have errored out on direct channel type")
|
|
}
|
|
|
|
isLicensed := utils.IsLicensed
|
|
restrictPublicChannel := *utils.Cfg.TeamSettings.RestrictPublicChannelManagement
|
|
restrictPrivateChannel := *utils.Cfg.TeamSettings.RestrictPrivateChannelManagement
|
|
defer func() {
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = restrictPublicChannel
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = restrictPrivateChannel
|
|
utils.IsLicensed = isLicensed
|
|
}()
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_ALL
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_ALL
|
|
utils.IsLicensed = true
|
|
|
|
channel2 := &model.Channel{DisplayName: "Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel3 := &model.Channel{DisplayName: "Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_PRIVATE, TeamId: team.Id}
|
|
if _, err := Client.CreateChannel(channel2); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := Client.CreateChannel(channel3); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_TEAM_ADMIN
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_TEAM_ADMIN
|
|
|
|
channel2.Name = "a" + model.NewId() + "a"
|
|
channel3.Name = "a" + model.NewId() + "a"
|
|
if _, err := Client.CreateChannel(channel2); err == nil {
|
|
t.Fatal("should have errored not team admin")
|
|
}
|
|
if _, err := Client.CreateChannel(channel3); err == nil {
|
|
t.Fatal("should have errored not team admin")
|
|
}
|
|
|
|
UpdateUserToTeamAdmin(th.BasicUser, team)
|
|
Client.Logout()
|
|
th.LoginBasic()
|
|
Client.SetTeamId(team.Id)
|
|
|
|
if _, err := Client.CreateChannel(channel2); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := Client.CreateChannel(channel3); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_SYSTEM_ADMIN
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_SYSTEM_ADMIN
|
|
|
|
channel2.Name = "a" + model.NewId() + "a"
|
|
channel3.Name = "a" + model.NewId() + "a"
|
|
if _, err := Client.CreateChannel(channel2); err == nil {
|
|
t.Fatal("should have errored not system admin")
|
|
}
|
|
if _, err := Client.CreateChannel(channel3); err == nil {
|
|
t.Fatal("should have errored not system admin")
|
|
}
|
|
|
|
LinkUserToTeam(th.SystemAdminUser, team)
|
|
|
|
if _, err := SystemAdminClient.CreateChannel(channel2); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := SystemAdminClient.CreateChannel(channel3); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestCreateDirectChannel(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
user := th.BasicUser
|
|
user2 := th.BasicUser2
|
|
|
|
rchannel, err := Client.CreateDirectChannel(th.BasicUser2.Id)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
channelName := ""
|
|
if user2.Id > user.Id {
|
|
channelName = user.Id + "__" + user2.Id
|
|
} else {
|
|
channelName = user2.Id + "__" + user.Id
|
|
}
|
|
|
|
if rchannel.Data.(*model.Channel).Name != channelName {
|
|
t.Fatal("channel name didn't match")
|
|
}
|
|
|
|
if rchannel.Data.(*model.Channel).Type != model.CHANNEL_DIRECT {
|
|
t.Fatal("channel type was not direct")
|
|
}
|
|
|
|
// don't fail on direct channels already existing
|
|
if _, err := Client.CreateDirectChannel(th.BasicUser2.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := Client.CreateDirectChannel("junk"); err == nil {
|
|
t.Fatal("should have failed with bad user id")
|
|
}
|
|
|
|
if _, err := Client.CreateDirectChannel("12345678901234567890123456"); err == nil {
|
|
t.Fatal("should have failed with non-existent user")
|
|
}
|
|
|
|
}
|
|
|
|
func TestUpdateChannel(t *testing.T) {
|
|
th := Setup().InitBasic().InitSystemAdmin()
|
|
Client := th.SystemAdminClient
|
|
team := th.SystemAdminTeam
|
|
sysAdminUser := th.SystemAdminUser
|
|
user := th.CreateUser(Client)
|
|
LinkUserToTeam(user, team)
|
|
user2 := th.CreateUser(Client)
|
|
LinkUserToTeam(user2, team)
|
|
|
|
Client.Login(user.Email, user.Password)
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
Client.AddChannelMember(channel1.Id, user.Id)
|
|
|
|
header := "a" + model.NewId() + "a"
|
|
purpose := "a" + model.NewId() + "a"
|
|
upChannel1 := &model.Channel{Id: channel1.Id, Header: header, Purpose: purpose}
|
|
upChannel1 = Client.Must(Client.UpdateChannel(upChannel1)).Data.(*model.Channel)
|
|
|
|
if upChannel1.Header != header {
|
|
t.Fatal("Channel admin failed to update header")
|
|
}
|
|
|
|
if upChannel1.Purpose != purpose {
|
|
t.Fatal("Channel admin failed to update purpose")
|
|
}
|
|
|
|
if upChannel1.DisplayName != channel1.DisplayName {
|
|
t.Fatal("Channel admin failed to skip displayName")
|
|
}
|
|
|
|
rget := Client.Must(Client.GetChannels(""))
|
|
data := rget.Data.(*model.ChannelList)
|
|
for _, c := range data.Channels {
|
|
if c.Name == model.DEFAULT_CHANNEL {
|
|
c.Header = "new header"
|
|
c.Name = "pseudo-square"
|
|
if _, err := Client.UpdateChannel(c); err == nil {
|
|
t.Fatal("should have errored on updating default channel name")
|
|
}
|
|
break
|
|
}
|
|
}
|
|
|
|
Client.Login(user2.Email, user2.Password)
|
|
|
|
if _, err := Client.UpdateChannel(upChannel1); err == nil {
|
|
t.Fatal("Standard User should have failed to update")
|
|
}
|
|
|
|
Client.Must(Client.JoinChannel(channel1.Id))
|
|
UpdateUserToTeamAdmin(user2, team)
|
|
|
|
Client.Logout()
|
|
Client.Login(user2.Email, user2.Password)
|
|
Client.SetTeamId(team.Id)
|
|
|
|
if _, err := Client.UpdateChannel(upChannel1); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
Client.Login(sysAdminUser.Email, sysAdminUser.Password)
|
|
LinkUserToTeam(sysAdminUser, team)
|
|
Client.Must(Client.JoinChannel(channel1.Id))
|
|
|
|
if _, err := Client.UpdateChannel(upChannel1); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
Client.Must(Client.DeleteChannel(channel1.Id))
|
|
|
|
if _, err := Client.UpdateChannel(upChannel1); err == nil {
|
|
t.Fatal("should have failed - channel deleted")
|
|
}
|
|
|
|
isLicensed := utils.IsLicensed
|
|
restrictPublicChannel := *utils.Cfg.TeamSettings.RestrictPublicChannelManagement
|
|
restrictPrivateChannel := *utils.Cfg.TeamSettings.RestrictPrivateChannelManagement
|
|
defer func() {
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = restrictPublicChannel
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = restrictPrivateChannel
|
|
utils.IsLicensed = isLicensed
|
|
}()
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_ALL
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_ALL
|
|
utils.IsLicensed = true
|
|
|
|
channel2 := th.CreateChannel(Client, team)
|
|
channel3 := th.CreatePrivateChannel(Client, team)
|
|
|
|
LinkUserToTeam(th.BasicUser, team)
|
|
|
|
Client.Must(Client.AddChannelMember(channel2.Id, th.BasicUser.Id))
|
|
Client.Must(Client.AddChannelMember(channel3.Id, th.BasicUser.Id))
|
|
|
|
Client.Login(th.BasicUser.Email, th.BasicUser.Password)
|
|
|
|
if _, err := Client.UpdateChannel(channel2); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := Client.UpdateChannel(channel3); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_TEAM_ADMIN
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_TEAM_ADMIN
|
|
|
|
if _, err := Client.UpdateChannel(channel2); err == nil {
|
|
t.Fatal("should have errored not team admin")
|
|
}
|
|
if _, err := Client.UpdateChannel(channel3); err == nil {
|
|
t.Fatal("should have errored not team admin")
|
|
}
|
|
|
|
UpdateUserToTeamAdmin(th.BasicUser, team)
|
|
Client.Logout()
|
|
Client.Login(th.BasicUser.Email, th.BasicUser.Password)
|
|
Client.SetTeamId(team.Id)
|
|
|
|
if _, err := Client.UpdateChannel(channel2); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := Client.UpdateChannel(channel3); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_SYSTEM_ADMIN
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_SYSTEM_ADMIN
|
|
|
|
if _, err := Client.UpdateChannel(channel2); err == nil {
|
|
t.Fatal("should have errored not system admin")
|
|
}
|
|
if _, err := Client.UpdateChannel(channel3); err == nil {
|
|
t.Fatal("should have errored not system admin")
|
|
}
|
|
|
|
th.LoginSystemAdmin()
|
|
|
|
if _, err := Client.UpdateChannel(channel2); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := Client.UpdateChannel(channel3); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestUpdateChannelHeader(t *testing.T) {
|
|
th := Setup().InitBasic().InitSystemAdmin()
|
|
Client := th.BasicClient
|
|
SystemAdminClient := th.SystemAdminClient
|
|
team := th.BasicTeam
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
data := make(map[string]string)
|
|
data["channel_id"] = channel1.Id
|
|
data["channel_header"] = "new header"
|
|
|
|
var upChannel1 *model.Channel
|
|
if result, err := Client.UpdateChannelHeader(data); err != nil {
|
|
t.Fatal(err)
|
|
} else {
|
|
upChannel1 = result.Data.(*model.Channel)
|
|
}
|
|
|
|
if upChannel1.Header != data["channel_header"] {
|
|
t.Fatal("Failed to update header")
|
|
}
|
|
|
|
data["channel_id"] = "junk"
|
|
if _, err := Client.UpdateChannelHeader(data); err == nil {
|
|
t.Fatal("should have errored on junk channel id")
|
|
}
|
|
|
|
data["channel_id"] = "12345678901234567890123456"
|
|
if _, err := Client.UpdateChannelHeader(data); err == nil {
|
|
t.Fatal("should have errored on non-existent channel id")
|
|
}
|
|
|
|
data["channel_id"] = channel1.Id
|
|
data["channel_header"] = strings.Repeat("a", 1050)
|
|
if _, err := Client.UpdateChannelHeader(data); err == nil {
|
|
t.Fatal("should have errored on bad channel header")
|
|
}
|
|
|
|
rchannel := Client.Must(Client.CreateDirectChannel(th.BasicUser2.Id)).Data.(*model.Channel)
|
|
data["channel_id"] = rchannel.Id
|
|
data["channel_header"] = "new header"
|
|
var upChanneld *model.Channel
|
|
if result, err := Client.UpdateChannelHeader(data); err != nil {
|
|
t.Fatal(err)
|
|
} else {
|
|
upChanneld = result.Data.(*model.Channel)
|
|
}
|
|
|
|
if upChanneld.Header != data["channel_header"] {
|
|
t.Fatal("Failed to update header")
|
|
}
|
|
|
|
th.LoginBasic2()
|
|
|
|
data["channel_id"] = channel1.Id
|
|
data["channel_header"] = "new header"
|
|
if _, err := Client.UpdateChannelHeader(data); err == nil {
|
|
t.Fatal("should have errored non-channel member trying to update header")
|
|
}
|
|
|
|
isLicensed := utils.IsLicensed
|
|
restrictPublicChannel := *utils.Cfg.TeamSettings.RestrictPublicChannelManagement
|
|
restrictPrivateChannel := *utils.Cfg.TeamSettings.RestrictPrivateChannelManagement
|
|
defer func() {
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = restrictPublicChannel
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = restrictPrivateChannel
|
|
utils.IsLicensed = isLicensed
|
|
}()
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_ALL
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_ALL
|
|
utils.IsLicensed = true
|
|
|
|
th.LoginBasic()
|
|
channel2 := th.CreateChannel(Client, team)
|
|
channel3 := th.CreatePrivateChannel(Client, team)
|
|
|
|
data2 := make(map[string]string)
|
|
data2["channel_id"] = channel2.Id
|
|
data2["channel_header"] = "new header"
|
|
|
|
data3 := make(map[string]string)
|
|
data3["channel_id"] = channel3.Id
|
|
data3["channel_header"] = "new header"
|
|
|
|
Client.Login(th.BasicUser.Email, th.BasicUser.Password)
|
|
|
|
if _, err := Client.UpdateChannelHeader(data2); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := Client.UpdateChannelHeader(data3); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_TEAM_ADMIN
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_TEAM_ADMIN
|
|
|
|
if _, err := Client.UpdateChannelHeader(data2); err == nil {
|
|
t.Fatal("should have errored not team admin")
|
|
}
|
|
if _, err := Client.UpdateChannelHeader(data3); err == nil {
|
|
t.Fatal("should have errored not team admin")
|
|
}
|
|
|
|
UpdateUserToTeamAdmin(th.BasicUser, team)
|
|
Client.Logout()
|
|
th.LoginBasic()
|
|
Client.SetTeamId(team.Id)
|
|
|
|
if _, err := Client.UpdateChannelHeader(data2); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := Client.UpdateChannelHeader(data3); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_SYSTEM_ADMIN
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_SYSTEM_ADMIN
|
|
|
|
if _, err := Client.UpdateChannelHeader(data2); err == nil {
|
|
t.Fatal("should have errored not system admin")
|
|
}
|
|
if _, err := Client.UpdateChannelHeader(data3); err == nil {
|
|
t.Fatal("should have errored not system admin")
|
|
}
|
|
|
|
LinkUserToTeam(th.SystemAdminUser, team)
|
|
Client.Must(Client.AddChannelMember(channel2.Id, th.SystemAdminUser.Id))
|
|
Client.Must(Client.AddChannelMember(channel3.Id, th.SystemAdminUser.Id))
|
|
th.LoginSystemAdmin()
|
|
|
|
if _, err := SystemAdminClient.UpdateChannelHeader(data2); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := SystemAdminClient.UpdateChannelHeader(data3); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestUpdateChannelPurpose(t *testing.T) {
|
|
th := Setup().InitBasic().InitSystemAdmin()
|
|
Client := th.BasicClient
|
|
SystemAdminClient := th.SystemAdminClient
|
|
team := th.BasicTeam
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
data := make(map[string]string)
|
|
data["channel_id"] = channel1.Id
|
|
data["channel_purpose"] = "new purpose"
|
|
|
|
var upChannel1 *model.Channel
|
|
if result, err := Client.UpdateChannelPurpose(data); err != nil {
|
|
t.Fatal(err)
|
|
} else {
|
|
upChannel1 = result.Data.(*model.Channel)
|
|
}
|
|
|
|
if upChannel1.Purpose != data["channel_purpose"] {
|
|
t.Fatal("Failed to update purpose")
|
|
}
|
|
|
|
data["channel_id"] = "junk"
|
|
if _, err := Client.UpdateChannelPurpose(data); err == nil {
|
|
t.Fatal("should have errored on junk channel id")
|
|
}
|
|
|
|
data["channel_id"] = "12345678901234567890123456"
|
|
if _, err := Client.UpdateChannelPurpose(data); err == nil {
|
|
t.Fatal("should have errored on non-existent channel id")
|
|
}
|
|
|
|
data["channel_id"] = channel1.Id
|
|
data["channel_purpose"] = strings.Repeat("a", 150)
|
|
if _, err := Client.UpdateChannelPurpose(data); err == nil {
|
|
t.Fatal("should have errored on bad channel purpose")
|
|
}
|
|
|
|
th.LoginBasic2()
|
|
|
|
data["channel_id"] = channel1.Id
|
|
data["channel_purpose"] = "new purpose"
|
|
if _, err := Client.UpdateChannelPurpose(data); err == nil {
|
|
t.Fatal("should have errored non-channel member trying to update purpose")
|
|
}
|
|
|
|
isLicensed := utils.IsLicensed
|
|
restrictPublicChannel := *utils.Cfg.TeamSettings.RestrictPublicChannelManagement
|
|
restrictPrivateChannel := *utils.Cfg.TeamSettings.RestrictPrivateChannelManagement
|
|
defer func() {
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = restrictPublicChannel
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = restrictPrivateChannel
|
|
utils.IsLicensed = isLicensed
|
|
}()
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_ALL
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_ALL
|
|
utils.IsLicensed = true
|
|
|
|
th.LoginBasic()
|
|
channel2 := th.CreateChannel(Client, team)
|
|
channel3 := th.CreatePrivateChannel(Client, team)
|
|
|
|
data2 := make(map[string]string)
|
|
data2["channel_id"] = channel2.Id
|
|
data2["channel_purpose"] = "new purpose"
|
|
|
|
data3 := make(map[string]string)
|
|
data3["channel_id"] = channel3.Id
|
|
data3["channel_purpose"] = "new purpose"
|
|
|
|
Client.Login(th.BasicUser.Email, th.BasicUser.Password)
|
|
|
|
if _, err := Client.UpdateChannelPurpose(data2); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := Client.UpdateChannelPurpose(data3); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_TEAM_ADMIN
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_TEAM_ADMIN
|
|
|
|
if _, err := Client.UpdateChannelPurpose(data2); err == nil {
|
|
t.Fatal("should have errored not team admin")
|
|
}
|
|
if _, err := Client.UpdateChannelPurpose(data3); err == nil {
|
|
t.Fatal("should have errored not team admin")
|
|
}
|
|
|
|
UpdateUserToTeamAdmin(th.BasicUser, team)
|
|
Client.Logout()
|
|
th.LoginBasic()
|
|
Client.SetTeamId(team.Id)
|
|
|
|
if _, err := Client.UpdateChannelPurpose(data2); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := Client.UpdateChannelPurpose(data3); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_SYSTEM_ADMIN
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_SYSTEM_ADMIN
|
|
|
|
if _, err := Client.UpdateChannelPurpose(data2); err == nil {
|
|
t.Fatal("should have errored not system admin")
|
|
}
|
|
if _, err := Client.UpdateChannelPurpose(data3); err == nil {
|
|
t.Fatal("should have errored not system admin")
|
|
}
|
|
|
|
LinkUserToTeam(th.SystemAdminUser, team)
|
|
Client.Must(Client.AddChannelMember(channel2.Id, th.SystemAdminUser.Id))
|
|
Client.Must(Client.AddChannelMember(channel3.Id, th.SystemAdminUser.Id))
|
|
th.LoginSystemAdmin()
|
|
|
|
if _, err := SystemAdminClient.UpdateChannelPurpose(data2); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := SystemAdminClient.UpdateChannelPurpose(data3); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestGetChannel(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
team := th.BasicTeam
|
|
team2 := th.CreateTeam(Client)
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
channel2 := &model.Channel{DisplayName: "B Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel2 = Client.Must(Client.CreateChannel(channel2)).Data.(*model.Channel)
|
|
|
|
rget := Client.Must(Client.GetChannels(""))
|
|
data := rget.Data.(*model.ChannelList)
|
|
|
|
if data.Channels[0].DisplayName != channel1.DisplayName {
|
|
t.Fatal("full name didn't match")
|
|
}
|
|
|
|
if data.Channels[1].DisplayName != channel2.DisplayName {
|
|
t.Fatal("full name didn't match")
|
|
}
|
|
|
|
// test etag caching
|
|
if cache_result, err := Client.GetChannels(rget.Etag); err != nil {
|
|
t.Fatal(err)
|
|
} else if cache_result.Data.(*model.ChannelList) != nil {
|
|
t.Log(cache_result.Data)
|
|
t.Fatal("cache should be empty")
|
|
}
|
|
|
|
if _, err := Client.UpdateLastViewedAt(channel2.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if resp, err := Client.GetChannel(channel1.Id, ""); err != nil {
|
|
t.Fatal(err)
|
|
} else {
|
|
data := resp.Data.(*model.ChannelData)
|
|
if data.Channel.DisplayName != channel1.DisplayName {
|
|
t.Fatal("name didn't match")
|
|
}
|
|
|
|
// test etag caching
|
|
if cache_result, err := Client.GetChannel(channel1.Id, resp.Etag); err != nil {
|
|
t.Fatal(err)
|
|
} else if cache_result.Data.(*model.ChannelData) != nil {
|
|
t.Log(cache_result.Data)
|
|
t.Fatal("cache should be empty")
|
|
}
|
|
}
|
|
|
|
if _, err := Client.GetChannel("junk", ""); err == nil {
|
|
t.Fatal("should have failed - bad channel id")
|
|
}
|
|
|
|
Client.SetTeamId(team2.Id)
|
|
if _, err := Client.GetChannel(channel2.Id, ""); err == nil {
|
|
t.Fatal("should have failed - wrong team")
|
|
}
|
|
}
|
|
|
|
func TestGetMoreChannel(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
team := th.BasicTeam
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
channel2 := &model.Channel{DisplayName: "B Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel2 = Client.Must(Client.CreateChannel(channel2)).Data.(*model.Channel)
|
|
|
|
th.LoginBasic2()
|
|
|
|
rget := Client.Must(Client.GetMoreChannels(""))
|
|
data := rget.Data.(*model.ChannelList)
|
|
|
|
if data.Channels[0].DisplayName != channel1.DisplayName {
|
|
t.Fatal("full name didn't match")
|
|
}
|
|
|
|
if data.Channels[1].DisplayName != channel2.DisplayName {
|
|
t.Fatal("full name didn't match")
|
|
}
|
|
|
|
// test etag caching
|
|
if cache_result, err := Client.GetMoreChannels(rget.Etag); err != nil {
|
|
t.Fatal(err)
|
|
} else if cache_result.Data.(*model.ChannelList) != nil {
|
|
t.Log(cache_result.Data)
|
|
t.Fatal("cache should be empty")
|
|
}
|
|
}
|
|
|
|
func TestGetChannelCounts(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
team := th.BasicTeam
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
channel2 := &model.Channel{DisplayName: "B Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel2 = Client.Must(Client.CreateChannel(channel2)).Data.(*model.Channel)
|
|
|
|
if result, err := Client.GetChannelCounts(""); err != nil {
|
|
t.Fatal(err)
|
|
} else {
|
|
counts := result.Data.(*model.ChannelCounts)
|
|
|
|
if len(counts.Counts) != 5 {
|
|
t.Fatal("wrong number of channel counts")
|
|
}
|
|
|
|
if len(counts.UpdateTimes) != 5 {
|
|
t.Fatal("wrong number of channel update times")
|
|
}
|
|
|
|
if cache_result, err := Client.GetChannelCounts(result.Etag); err != nil {
|
|
t.Fatal(err)
|
|
} else if cache_result.Data.(*model.ChannelCounts) != nil {
|
|
t.Log(cache_result.Data)
|
|
t.Fatal("result data should be empty")
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
func TestJoinChannelById(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
team := th.BasicTeam
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
channel3 := &model.Channel{DisplayName: "B Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_PRIVATE, TeamId: team.Id}
|
|
channel3 = Client.Must(Client.CreateChannel(channel3)).Data.(*model.Channel)
|
|
|
|
th.LoginBasic2()
|
|
|
|
Client.Must(Client.JoinChannel(channel1.Id))
|
|
|
|
if _, err := Client.JoinChannel(channel3.Id); err == nil {
|
|
t.Fatal("shouldn't be able to join secret group")
|
|
}
|
|
|
|
rchannel := Client.Must(Client.CreateDirectChannel(th.BasicUser.Id)).Data.(*model.Channel)
|
|
|
|
user3 := th.CreateUser(th.BasicClient)
|
|
LinkUserToTeam(user3, team)
|
|
Client.Must(Client.Login(user3.Email, "Password1"))
|
|
|
|
if _, err := Client.JoinChannel(rchannel.Id); err == nil {
|
|
t.Fatal("shoudn't be able to join direct channel")
|
|
}
|
|
|
|
th.LoginBasic()
|
|
|
|
if _, err := Client.JoinChannel(channel1.Id); err != nil {
|
|
t.Fatal("should be able to join public channel that we're a member of")
|
|
}
|
|
|
|
if _, err := Client.JoinChannel(channel3.Id); err != nil {
|
|
t.Fatal("should be able to join private channel that we're a member of")
|
|
}
|
|
|
|
if _, err := Client.JoinChannel(rchannel.Id); err != nil {
|
|
t.Fatal("should be able to join direct channel that we're a member of")
|
|
}
|
|
}
|
|
|
|
func TestJoinChannelByName(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
team := th.BasicTeam
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
channel3 := &model.Channel{DisplayName: "B Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_PRIVATE, TeamId: team.Id}
|
|
channel3 = Client.Must(Client.CreateChannel(channel3)).Data.(*model.Channel)
|
|
|
|
th.LoginBasic2()
|
|
|
|
Client.Must(Client.JoinChannelByName(channel1.Name))
|
|
|
|
if _, err := Client.JoinChannelByName(channel3.Name); err == nil {
|
|
t.Fatal("shouldn't be able to join secret group")
|
|
}
|
|
|
|
rchannel := Client.Must(Client.CreateDirectChannel(th.BasicUser.Id)).Data.(*model.Channel)
|
|
|
|
user3 := th.CreateUser(th.BasicClient)
|
|
LinkUserToTeam(user3, team)
|
|
Client.Must(Client.Login(user3.Email, "Password1"))
|
|
|
|
if _, err := Client.JoinChannelByName(rchannel.Name); err == nil {
|
|
t.Fatal("shoudn't be able to join direct channel")
|
|
}
|
|
|
|
th.LoginBasic()
|
|
|
|
if _, err := Client.JoinChannelByName(channel1.Name); err != nil {
|
|
t.Fatal("should be able to join public channel that we're a member of")
|
|
}
|
|
|
|
if _, err := Client.JoinChannelByName(channel3.Name); err != nil {
|
|
t.Fatal("should be able to join private channel that we're a member of")
|
|
}
|
|
|
|
if _, err := Client.JoinChannelByName(rchannel.Name); err != nil {
|
|
t.Fatal("should be able to join direct channel that we're a member of")
|
|
}
|
|
}
|
|
|
|
func TestJoinChannelByNameDisabledUser(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
team := th.BasicTeam
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
Client.Must(th.BasicClient.RemoveUserFromTeam(th.BasicTeam.Id, th.BasicUser.Id))
|
|
|
|
if _, err := AddUserToChannel(th.BasicUser, channel1); err == nil {
|
|
t.Fatal("shoudn't be able to join channel")
|
|
} else {
|
|
if err.Id != "api.channel.add_user.to.channel.failed.deleted.app_error" {
|
|
t.Fatal("wrong error")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestLeaveChannel(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
team := th.BasicTeam
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
channel3 := &model.Channel{DisplayName: "B Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_PRIVATE, TeamId: team.Id}
|
|
channel3 = Client.Must(Client.CreateChannel(channel3)).Data.(*model.Channel)
|
|
|
|
th.LoginBasic2()
|
|
|
|
Client.Must(Client.JoinChannel(channel1.Id))
|
|
|
|
// Cannot leave a the private group if you are the only member
|
|
if _, err := Client.LeaveChannel(channel3.Id); err == nil {
|
|
t.Fatal("should have errored, cannot leave private group if only one member")
|
|
}
|
|
|
|
rchannel := Client.Must(Client.CreateDirectChannel(th.BasicUser.Id)).Data.(*model.Channel)
|
|
|
|
if _, err := Client.LeaveChannel(rchannel.Id); err == nil {
|
|
t.Fatal("should have errored, cannot leave direct channel")
|
|
}
|
|
|
|
rget := Client.Must(Client.GetChannels(""))
|
|
cdata := rget.Data.(*model.ChannelList)
|
|
for _, c := range cdata.Channels {
|
|
if c.Name == model.DEFAULT_CHANNEL {
|
|
if _, err := Client.LeaveChannel(c.Id); err == nil {
|
|
t.Fatal("should have errored on leaving default channel")
|
|
}
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDeleteChannel(t *testing.T) {
|
|
th := Setup().InitBasic().InitSystemAdmin()
|
|
Client := th.SystemAdminClient
|
|
team := th.SystemAdminTeam
|
|
userSystemAdmin := th.SystemAdminUser
|
|
userTeamAdmin := th.CreateUser(Client)
|
|
LinkUserToTeam(userTeamAdmin, team)
|
|
user2 := th.CreateUser(Client)
|
|
LinkUserToTeam(user2, team)
|
|
|
|
Client.Login(user2.Email, user2.Password)
|
|
|
|
channelMadeByCA := &model.Channel{DisplayName: "C Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channelMadeByCA = Client.Must(Client.CreateChannel(channelMadeByCA)).Data.(*model.Channel)
|
|
|
|
Client.AddChannelMember(channelMadeByCA.Id, userTeamAdmin.Id)
|
|
|
|
Client.Login(userTeamAdmin.Email, "pwd")
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
channel2 := &model.Channel{DisplayName: "B Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel2 = Client.Must(Client.CreateChannel(channel2)).Data.(*model.Channel)
|
|
|
|
if _, err := Client.DeleteChannel(channel1.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := Client.DeleteChannel(channelMadeByCA.Id); err != nil {
|
|
t.Fatal("Team admin failed to delete Channel Admin's channel")
|
|
}
|
|
|
|
post1 := &model.Post{ChannelId: channel1.Id, Message: "a" + model.NewId() + "a"}
|
|
if _, err := Client.CreatePost(post1); err == nil {
|
|
t.Fatal("should have failed to post to deleted channel")
|
|
}
|
|
|
|
userStd := th.CreateUser(Client)
|
|
LinkUserToTeam(userStd, team)
|
|
Client.Login(userStd.Email, userStd.Password)
|
|
|
|
if _, err := Client.JoinChannel(channel1.Id); err == nil {
|
|
t.Fatal("should have failed to join deleted channel")
|
|
}
|
|
|
|
Client.Must(Client.JoinChannel(channel2.Id))
|
|
|
|
if _, err := Client.DeleteChannel(channel2.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
rget := Client.Must(Client.GetChannels(""))
|
|
cdata := rget.Data.(*model.ChannelList)
|
|
for _, c := range cdata.Channels {
|
|
if c.Name == model.DEFAULT_CHANNEL {
|
|
if _, err := Client.DeleteChannel(c.Id); err == nil {
|
|
t.Fatal("should have errored on deleting default channel")
|
|
}
|
|
break
|
|
}
|
|
}
|
|
|
|
UpdateUserToTeamAdmin(userStd, team)
|
|
|
|
Client.Logout()
|
|
Client.Login(userStd.Email, userStd.Password)
|
|
Client.SetTeamId(team.Id)
|
|
|
|
channel2 = th.CreateChannel(Client, team)
|
|
|
|
if _, err := Client.DeleteChannel(channel2.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
channel3 := &model.Channel{DisplayName: "B Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel3 = Client.Must(Client.CreateChannel(channel3)).Data.(*model.Channel)
|
|
|
|
Client.Login(userSystemAdmin.Email, userSystemAdmin.Password)
|
|
Client.Must(Client.JoinChannel(channel3.Id))
|
|
|
|
if _, err := Client.DeleteChannel(channel3.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := Client.DeleteChannel(channel3.Id); err == nil {
|
|
t.Fatal("should have failed - channel already deleted")
|
|
}
|
|
|
|
isLicensed := utils.IsLicensed
|
|
restrictPublicChannel := *utils.Cfg.TeamSettings.RestrictPublicChannelManagement
|
|
restrictPrivateChannel := *utils.Cfg.TeamSettings.RestrictPrivateChannelManagement
|
|
defer func() {
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = restrictPublicChannel
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = restrictPrivateChannel
|
|
utils.IsLicensed = isLicensed
|
|
}()
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_ALL
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_ALL
|
|
utils.IsLicensed = true
|
|
|
|
th.LoginSystemAdmin()
|
|
LinkUserToTeam(th.BasicUser, team)
|
|
|
|
channel2 = th.CreateChannel(Client, team)
|
|
channel3 = th.CreatePrivateChannel(Client, team)
|
|
channel4 := th.CreateChannel(Client, team)
|
|
Client.Must(Client.AddChannelMember(channel2.Id, th.BasicUser.Id))
|
|
Client.Must(Client.AddChannelMember(channel3.Id, th.BasicUser.Id))
|
|
Client.Must(Client.AddChannelMember(channel4.Id, th.BasicUser.Id))
|
|
Client.Must(Client.LeaveChannel(channel4.Id))
|
|
|
|
Client.Login(th.BasicUser.Email, th.BasicUser.Password)
|
|
|
|
if _, err := Client.DeleteChannel(channel2.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := Client.DeleteChannel(channel3.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_TEAM_ADMIN
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_TEAM_ADMIN
|
|
|
|
th.LoginSystemAdmin()
|
|
|
|
channel2 = th.CreateChannel(Client, team)
|
|
channel3 = th.CreatePrivateChannel(Client, team)
|
|
Client.Must(Client.AddChannelMember(channel2.Id, th.BasicUser.Id))
|
|
Client.Must(Client.AddChannelMember(channel3.Id, th.BasicUser.Id))
|
|
|
|
Client.Login(th.BasicUser.Email, th.BasicUser.Password)
|
|
|
|
if _, err := Client.DeleteChannel(channel2.Id); err == nil {
|
|
t.Fatal("should have errored not team admin")
|
|
}
|
|
if _, err := Client.DeleteChannel(channel3.Id); err == nil {
|
|
t.Fatal("should have errored not team admin")
|
|
}
|
|
|
|
UpdateUserToTeamAdmin(th.BasicUser, team)
|
|
Client.Logout()
|
|
Client.Login(th.BasicUser.Email, th.BasicUser.Password)
|
|
Client.SetTeamId(team.Id)
|
|
|
|
if _, err := Client.DeleteChannel(channel2.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := Client.DeleteChannel(channel3.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
*utils.Cfg.TeamSettings.RestrictPublicChannelManagement = model.PERMISSIONS_SYSTEM_ADMIN
|
|
*utils.Cfg.TeamSettings.RestrictPrivateChannelManagement = model.PERMISSIONS_SYSTEM_ADMIN
|
|
|
|
th.LoginSystemAdmin()
|
|
|
|
channel2 = th.CreateChannel(Client, team)
|
|
channel3 = th.CreatePrivateChannel(Client, team)
|
|
Client.Must(Client.AddChannelMember(channel2.Id, th.BasicUser.Id))
|
|
Client.Must(Client.AddChannelMember(channel3.Id, th.BasicUser.Id))
|
|
|
|
Client.Login(th.BasicUser.Email, th.BasicUser.Password)
|
|
|
|
if _, err := Client.DeleteChannel(channel2.Id); err == nil {
|
|
t.Fatal("should have errored not system admin")
|
|
}
|
|
if _, err := Client.DeleteChannel(channel3.Id); err == nil {
|
|
t.Fatal("should have errored not system admin")
|
|
}
|
|
|
|
// Only one left in channel, should be able to delete
|
|
if _, err := Client.DeleteChannel(channel4.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
th.LoginSystemAdmin()
|
|
|
|
if _, err := Client.DeleteChannel(channel2.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := Client.DeleteChannel(channel3.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestGetChannelExtraInfo(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
team := th.BasicTeam
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
rget := Client.Must(Client.GetChannelExtraInfo(channel1.Id, -1, ""))
|
|
data := rget.Data.(*model.ChannelExtra)
|
|
if data.Id != channel1.Id {
|
|
t.Fatal("couldnt't get extra info")
|
|
} else if len(data.Members) != 1 {
|
|
t.Fatal("got incorrect members")
|
|
} else if data.MemberCount != 1 {
|
|
t.Fatal("got incorrect member count")
|
|
}
|
|
|
|
//
|
|
// Testing etag caching
|
|
//
|
|
|
|
currentEtag := rget.Etag
|
|
|
|
if cache_result, err := Client.GetChannelExtraInfo(channel1.Id, -1, currentEtag); err != nil {
|
|
t.Fatal(err)
|
|
} else if cache_result.Data.(*model.ChannelExtra) != nil {
|
|
t.Log(cache_result.Data)
|
|
t.Fatal("response should be empty")
|
|
} else {
|
|
currentEtag = cache_result.Etag
|
|
}
|
|
|
|
Client2 := model.NewClient("http://localhost" + utils.Cfg.ServiceSettings.ListenAddress)
|
|
|
|
user2 := &model.User{Email: "success+" + model.NewId() + "@simulator.amazonses.com", Nickname: "Tester 2", Password: "passwd1"}
|
|
user2 = Client2.Must(Client2.CreateUser(user2, "")).Data.(*model.User)
|
|
LinkUserToTeam(user2, team)
|
|
Client2.SetTeamId(team.Id)
|
|
store.Must(Srv.Store.User().VerifyEmail(user2.Id))
|
|
|
|
Client2.Login(user2.Email, "passwd1")
|
|
Client2.Must(Client2.JoinChannel(channel1.Id))
|
|
|
|
if cache_result, err := Client.GetChannelExtraInfo(channel1.Id, -1, currentEtag); err != nil {
|
|
t.Fatal(err)
|
|
} else if cache_result.Data.(*model.ChannelExtra) == nil {
|
|
t.Log(cache_result.Data)
|
|
t.Fatal("response should not be empty")
|
|
} else {
|
|
currentEtag = cache_result.Etag
|
|
}
|
|
|
|
if cache_result, err := Client.GetChannelExtraInfo(channel1.Id, -1, currentEtag); err != nil {
|
|
t.Fatal(err)
|
|
} else if cache_result.Data.(*model.ChannelExtra) != nil {
|
|
t.Log(cache_result.Data)
|
|
t.Fatal("response should be empty")
|
|
} else {
|
|
currentEtag = cache_result.Etag
|
|
}
|
|
|
|
Client2.Must(Client2.LeaveChannel(channel1.Id))
|
|
|
|
if cache_result, err := Client.GetChannelExtraInfo(channel1.Id, -1, currentEtag); err != nil {
|
|
t.Fatal(err)
|
|
} else if cache_result.Data.(*model.ChannelExtra) == nil {
|
|
t.Log(cache_result.Data)
|
|
t.Fatal("response should not be empty")
|
|
} else {
|
|
currentEtag = cache_result.Etag
|
|
}
|
|
|
|
if cache_result, err := Client.GetChannelExtraInfo(channel1.Id, -1, currentEtag); err != nil {
|
|
t.Fatal(err)
|
|
} else if cache_result.Data.(*model.ChannelExtra) != nil {
|
|
t.Log(cache_result.Data)
|
|
t.Fatal("response should be empty")
|
|
} else {
|
|
currentEtag = cache_result.Etag
|
|
}
|
|
|
|
Client2.Must(Client2.JoinChannel(channel1.Id))
|
|
|
|
if cache_result, err := Client.GetChannelExtraInfo(channel1.Id, 2, currentEtag); err != nil {
|
|
t.Fatal(err)
|
|
} else if extra := cache_result.Data.(*model.ChannelExtra); extra == nil {
|
|
t.Fatal("response should not be empty")
|
|
} else if len(extra.Members) != 2 {
|
|
t.Fatal("should've returned 2 members")
|
|
} else if extra.MemberCount != 2 {
|
|
t.Fatal("should've returned member count of 2")
|
|
} else {
|
|
currentEtag = cache_result.Etag
|
|
}
|
|
|
|
if cache_result, err := Client.GetChannelExtraInfo(channel1.Id, 1, currentEtag); err != nil {
|
|
t.Fatal(err)
|
|
} else if extra := cache_result.Data.(*model.ChannelExtra); extra == nil {
|
|
t.Fatal("response should not be empty")
|
|
} else if len(extra.Members) != 1 {
|
|
t.Fatal("should've returned only 1 member")
|
|
} else if extra.MemberCount != 2 {
|
|
t.Fatal("should've returned member count of 2")
|
|
} else {
|
|
currentEtag = cache_result.Etag
|
|
}
|
|
|
|
if cache_result, err := Client.GetChannelExtraInfo(channel1.Id, 1, currentEtag); err != nil {
|
|
t.Fatal(err)
|
|
} else if cache_result.Data.(*model.ChannelExtra) != nil {
|
|
t.Log(cache_result.Data)
|
|
t.Fatal("response should be empty")
|
|
} else {
|
|
currentEtag = cache_result.Etag
|
|
}
|
|
|
|
}
|
|
|
|
func TestAddChannelMember(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
team := th.BasicTeam
|
|
user2 := th.BasicUser2
|
|
user3 := th.CreateUser(Client)
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
if _, err := Client.AddChannelMember(channel1.Id, user2.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := Client.AddChannelMember(channel1.Id, "dsgsdg"); err == nil {
|
|
t.Fatal("Should have errored, bad user id")
|
|
}
|
|
|
|
if _, err := Client.AddChannelMember(channel1.Id, "12345678901234567890123456"); err == nil {
|
|
t.Fatal("Should have errored, bad user id")
|
|
}
|
|
|
|
if _, err := Client.AddChannelMember(channel1.Id, user2.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := Client.AddChannelMember("sgdsgsdg", user2.Id); err == nil {
|
|
t.Fatal("Should have errored, bad channel id")
|
|
}
|
|
|
|
channel2 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel2 = Client.Must(Client.CreateChannel(channel2)).Data.(*model.Channel)
|
|
|
|
th.LoginBasic2()
|
|
|
|
if _, err := Client.AddChannelMember(channel2.Id, user2.Id); err == nil {
|
|
t.Fatal("Should have errored, user not in channel")
|
|
}
|
|
|
|
th.LoginBasic()
|
|
|
|
Client.Must(Client.DeleteChannel(channel2.Id))
|
|
|
|
if _, err := Client.AddChannelMember(channel2.Id, user2.Id); err == nil {
|
|
t.Fatal("Should have errored, channel deleted")
|
|
}
|
|
|
|
if _, err := Client.AddChannelMember(channel1.Id, user3.Id); err == nil {
|
|
t.Fatal("Should have errored, user not on team")
|
|
}
|
|
}
|
|
|
|
func TestRemoveChannelMember(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
team := th.BasicTeam
|
|
user2 := th.BasicUser2
|
|
UpdateUserToTeamAdmin(user2, team)
|
|
|
|
channelMadeByCA := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channelMadeByCA = Client.Must(Client.CreateChannel(channelMadeByCA)).Data.(*model.Channel)
|
|
|
|
Client.Must(Client.AddChannelMember(channelMadeByCA.Id, user2.Id))
|
|
|
|
th.LoginBasic2()
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
userStd := th.CreateUser(th.BasicClient)
|
|
LinkUserToTeam(userStd, team)
|
|
|
|
Client.Must(Client.AddChannelMember(channel1.Id, userStd.Id))
|
|
|
|
Client.Must(Client.AddChannelMember(channelMadeByCA.Id, userStd.Id))
|
|
|
|
if _, err := Client.RemoveChannelMember(channel1.Id, "dsgsdg"); err == nil {
|
|
t.Fatal("Should have errored, bad user id")
|
|
}
|
|
|
|
if _, err := Client.RemoveChannelMember("sgdsgsdg", userStd.Id); err == nil {
|
|
t.Fatal("Should have errored, bad channel id")
|
|
}
|
|
|
|
if _, err := Client.RemoveChannelMember(channel1.Id, userStd.Id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := Client.RemoveChannelMember(channelMadeByCA.Id, userStd.Id); err != nil {
|
|
t.Fatal("Team Admin failed to remove member from Channel Admin's channel")
|
|
}
|
|
|
|
channel2 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel2 = Client.Must(Client.CreateChannel(channel2)).Data.(*model.Channel)
|
|
|
|
Client.Login(userStd.Email, userStd.Password)
|
|
|
|
if _, err := Client.RemoveChannelMember(channel2.Id, userStd.Id); err == nil {
|
|
t.Fatal("Should have errored, user not channel admin")
|
|
}
|
|
|
|
th.LoginBasic2()
|
|
Client.Must(Client.AddChannelMember(channel2.Id, userStd.Id))
|
|
|
|
Client.Must(Client.DeleteChannel(channel2.Id))
|
|
|
|
if _, err := Client.RemoveChannelMember(channel2.Id, userStd.Id); err == nil {
|
|
t.Fatal("Should have errored, channel deleted")
|
|
}
|
|
|
|
}
|
|
|
|
func TestUpdateNotifyProps(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
team := th.BasicTeam
|
|
user := th.BasicUser
|
|
user2 := th.BasicUser2
|
|
|
|
channel1 := &model.Channel{DisplayName: "A Test API Name", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
|
|
|
|
data := make(map[string]string)
|
|
data["channel_id"] = channel1.Id
|
|
data["user_id"] = user.Id
|
|
data["desktop"] = model.CHANNEL_NOTIFY_MENTION
|
|
|
|
timeBeforeUpdate := model.GetMillis()
|
|
time.Sleep(100 * time.Millisecond)
|
|
|
|
// test updating desktop
|
|
if result, err := Client.UpdateNotifyProps(data); err != nil {
|
|
t.Fatal(err)
|
|
} else if notifyProps := result.Data.(map[string]string); notifyProps["desktop"] != model.CHANNEL_NOTIFY_MENTION {
|
|
t.Fatal("NotifyProps[\"desktop\"] did not update properly")
|
|
} else if notifyProps["mark_unread"] != model.CHANNEL_MARK_UNREAD_ALL {
|
|
t.Fatalf("NotifyProps[\"mark_unread\"] changed to %v", notifyProps["mark_unread"])
|
|
}
|
|
|
|
rget := Client.Must(Client.GetChannels(""))
|
|
rdata := rget.Data.(*model.ChannelList)
|
|
if len(rdata.Members) == 0 || rdata.Members[channel1.Id].NotifyProps["desktop"] != data["desktop"] {
|
|
t.Fatal("NotifyProps[\"desktop\"] did not update properly")
|
|
} else if rdata.Members[channel1.Id].LastUpdateAt <= timeBeforeUpdate {
|
|
t.Fatal("LastUpdateAt did not update")
|
|
}
|
|
|
|
// test an empty update
|
|
delete(data, "desktop")
|
|
|
|
if result, err := Client.UpdateNotifyProps(data); err != nil {
|
|
t.Fatal(err)
|
|
} else if notifyProps := result.Data.(map[string]string); notifyProps["mark_unread"] != model.CHANNEL_MARK_UNREAD_ALL {
|
|
t.Fatalf("NotifyProps[\"mark_unread\"] changed to %v", notifyProps["mark_unread"])
|
|
} else if notifyProps["desktop"] != model.CHANNEL_NOTIFY_MENTION {
|
|
t.Fatalf("NotifyProps[\"desktop\"] changed to %v", notifyProps["desktop"])
|
|
}
|
|
|
|
// test updating mark unread
|
|
data["mark_unread"] = model.CHANNEL_MARK_UNREAD_MENTION
|
|
|
|
if result, err := Client.UpdateNotifyProps(data); err != nil {
|
|
t.Fatal(err)
|
|
} else if notifyProps := result.Data.(map[string]string); notifyProps["mark_unread"] != model.CHANNEL_MARK_UNREAD_MENTION {
|
|
t.Fatal("NotifyProps[\"mark_unread\"] did not update properly")
|
|
} else if notifyProps["desktop"] != model.CHANNEL_NOTIFY_MENTION {
|
|
t.Fatalf("NotifyProps[\"desktop\"] changed to %v", notifyProps["desktop"])
|
|
}
|
|
|
|
// test updating both
|
|
data["desktop"] = model.CHANNEL_NOTIFY_NONE
|
|
data["mark_unread"] = model.CHANNEL_MARK_UNREAD_MENTION
|
|
|
|
if result, err := Client.UpdateNotifyProps(data); err != nil {
|
|
t.Fatal(err)
|
|
} else if notifyProps := result.Data.(map[string]string); notifyProps["desktop"] != model.CHANNEL_NOTIFY_NONE {
|
|
t.Fatal("NotifyProps[\"desktop\"] did not update properly")
|
|
} else if notifyProps["mark_unread"] != model.CHANNEL_MARK_UNREAD_MENTION {
|
|
t.Fatal("NotifyProps[\"mark_unread\"] did not update properly")
|
|
}
|
|
|
|
// test error cases
|
|
data["user_id"] = "junk"
|
|
if _, err := Client.UpdateNotifyProps(data); err == nil {
|
|
t.Fatal("Should have errored - bad user id")
|
|
}
|
|
|
|
data["user_id"] = "12345678901234567890123456"
|
|
if _, err := Client.UpdateNotifyProps(data); err == nil {
|
|
t.Fatal("Should have errored - bad user id")
|
|
}
|
|
|
|
data["user_id"] = user.Id
|
|
data["channel_id"] = "junk"
|
|
if _, err := Client.UpdateNotifyProps(data); err == nil {
|
|
t.Fatal("Should have errored - bad channel id")
|
|
}
|
|
|
|
data["channel_id"] = "12345678901234567890123456"
|
|
if _, err := Client.UpdateNotifyProps(data); err == nil {
|
|
t.Fatal("Should have errored - bad channel id")
|
|
}
|
|
|
|
data["desktop"] = "junk"
|
|
data["mark_unread"] = model.CHANNEL_MARK_UNREAD_ALL
|
|
if _, err := Client.UpdateNotifyProps(data); err == nil {
|
|
t.Fatal("Should have errored - bad desktop notify level")
|
|
}
|
|
|
|
data["desktop"] = model.CHANNEL_NOTIFY_ALL
|
|
data["mark_unread"] = "junk"
|
|
if _, err := Client.UpdateNotifyProps(data); err == nil {
|
|
t.Fatal("Should have errored - bad mark unread level")
|
|
}
|
|
|
|
th.LoginBasic2()
|
|
|
|
data["channel_id"] = channel1.Id
|
|
data["user_id"] = user2.Id
|
|
data["desktop"] = model.CHANNEL_NOTIFY_MENTION
|
|
data["mark_unread"] = model.CHANNEL_MARK_UNREAD_MENTION
|
|
if _, err := Client.UpdateNotifyProps(data); err == nil {
|
|
t.Fatal("Should have errored - user not in channel")
|
|
}
|
|
}
|
|
|
|
func TestFuzzyChannel(t *testing.T) {
|
|
th := Setup().InitBasic()
|
|
Client := th.BasicClient
|
|
team := th.BasicTeam
|
|
|
|
// Strings that should pass as acceptable channel names
|
|
var fuzzyStringsPass = []string{
|
|
"*", "?", ".", "}{][)(><", "{}[]()<>",
|
|
|
|
"qahwah ( قهوة)",
|
|
"שָׁלוֹם עֲלֵיכֶם",
|
|
"Ramen チャーシュー chāshū",
|
|
"言而无信",
|
|
"Ṫ͌ó̍ ̍͂̓̍̍̀i̊ͯ͒",
|
|
"& < &qu",
|
|
|
|
"' or '1'='1' -- ",
|
|
"' or '1'='1' ({ ",
|
|
"' or '1'='1' /* ",
|
|
"1;DROP TABLE users",
|
|
|
|
"<b><i><u><strong><em>",
|
|
|
|
"sue@thatmightbe",
|
|
"sue@thatmightbe.",
|
|
"sue@thatmightbe.c",
|
|
"sue@thatmightbe.co",
|
|
"su+san@thatmightbe.com",
|
|
"a@b.中国",
|
|
"1@2.am",
|
|
"a@b.co.uk",
|
|
"a@b.cancerresearch",
|
|
"local@[127.0.0.1]",
|
|
}
|
|
|
|
for i := 0; i < len(fuzzyStringsPass); i++ {
|
|
channel := model.Channel{DisplayName: fuzzyStringsPass[i], Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
|
|
|
|
_, err := Client.CreateChannel(&channel)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
}
|