mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
* Added redirection after Auth complete * Fixed gofmt * Handling error while parsing the url, added util function to check for a valid mobile redirect url * Added check for custom scheme url validation * Added test to verify custom schele url * Added mobile message screens * Translation strings for mobile screens * Added mobile specific screens for success and error * Added error logs and changed variable name for consistency with oauth.go * i18n fix * Reusing assigned variable instead of map * Added AppCustomUrlScheme property * Code refactor and removed dependency from cookies to build the final url * Changed util function * Updated util test * Fixed go lint * Code refactor and unsused code removed * Code refactor * simplified boolean checks * Added support of whitelist of appCustomURLSchemes * Changed i18 en * Fixed validating redirecturl for web Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
173 lines
4.3 KiB
Go
173 lines
4.3 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package utils
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestStringArrayIntersection(t *testing.T) {
|
|
a := []string{
|
|
"abc",
|
|
"def",
|
|
"ghi",
|
|
}
|
|
b := []string{
|
|
"jkl",
|
|
}
|
|
c := []string{
|
|
"def",
|
|
}
|
|
|
|
assert.Empty(t, StringArrayIntersection(a, b))
|
|
assert.Len(t, StringArrayIntersection(a, c), 1)
|
|
}
|
|
|
|
func TestRemoveDuplicatesFromStringArray(t *testing.T) {
|
|
a := []string{
|
|
"a",
|
|
"b",
|
|
"a",
|
|
"a",
|
|
"b",
|
|
"c",
|
|
"a",
|
|
}
|
|
|
|
assert.Len(t, RemoveDuplicatesFromStringArray(a), 3)
|
|
}
|
|
|
|
func TestStringSliceDiff(t *testing.T) {
|
|
a := []string{"one", "two", "three", "four", "five", "six"}
|
|
b := []string{"two", "seven", "four", "six"}
|
|
expected := []string{"one", "three", "five"}
|
|
|
|
assert.Equal(t, expected, StringSliceDiff(a, b))
|
|
}
|
|
|
|
func TestGetIpAddress(t *testing.T) {
|
|
// Test with a single IP in the X-Forwarded-For
|
|
httpRequest1 := http.Request{
|
|
Header: http.Header{
|
|
"X-Forwarded-For": []string{"10.0.0.1"},
|
|
"X-Real-Ip": []string{"10.1.0.1"},
|
|
},
|
|
RemoteAddr: "10.2.0.1:12345",
|
|
}
|
|
|
|
assert.Equal(t, "10.0.0.1", GetIpAddress(&httpRequest1, []string{"X-Forwarded-For"}))
|
|
|
|
// Test with multiple IPs in the X-Forwarded-For
|
|
httpRequest2 := http.Request{
|
|
Header: http.Header{
|
|
"X-Forwarded-For": []string{"10.0.0.1, 10.0.0.2, 10.0.0.3"},
|
|
"X-Real-Ip": []string{"10.1.0.1"},
|
|
},
|
|
RemoteAddr: "10.2.0.1:12345",
|
|
}
|
|
|
|
assert.Equal(t, "10.0.0.1", GetIpAddress(&httpRequest2, []string{"X-Forwarded-For"}))
|
|
|
|
// Test with an empty X-Forwarded-For
|
|
httpRequest3 := http.Request{
|
|
Header: http.Header{
|
|
"X-Forwarded-For": []string{""},
|
|
"X-Real-Ip": []string{"10.1.0.1"},
|
|
},
|
|
RemoteAddr: "10.2.0.1:12345",
|
|
}
|
|
|
|
assert.Equal(t, "10.1.0.1", GetIpAddress(&httpRequest3, []string{"X-Forwarded-For", "X-Real-Ip"}))
|
|
|
|
// Test without an X-Fowarded-For
|
|
httpRequest4 := http.Request{
|
|
Header: http.Header{
|
|
"X-Real-Ip": []string{"10.1.0.1"},
|
|
},
|
|
RemoteAddr: "10.2.0.1:12345",
|
|
}
|
|
|
|
assert.Equal(t, "10.1.0.1", GetIpAddress(&httpRequest4, []string{"X-Forwarded-For", "X-Real-Ip"}))
|
|
|
|
// Test without any headers
|
|
httpRequest5 := http.Request{
|
|
RemoteAddr: "10.2.0.1:12345",
|
|
}
|
|
|
|
assert.Equal(t, "10.2.0.1", GetIpAddress(&httpRequest5, []string{"X-Forwarded-For", "X-Real-Ip"}))
|
|
|
|
// Test with both headers, but both untrusted
|
|
httpRequest6 := http.Request{
|
|
Header: http.Header{
|
|
"X-Forwarded-For": []string{"10.3.0.1"},
|
|
"X-Real-Ip": []string{"10.1.0.1"},
|
|
},
|
|
RemoteAddr: "10.2.0.1:12345",
|
|
}
|
|
|
|
assert.Equal(t, "10.2.0.1", GetIpAddress(&httpRequest6, nil))
|
|
|
|
// Test with both headers, but only X-Real-Ip trusted
|
|
httpRequest7 := http.Request{
|
|
Header: http.Header{
|
|
"X-Forwarded-For": []string{"10.3.0.1"},
|
|
"X-Real-Ip": []string{"10.1.0.1"},
|
|
},
|
|
RemoteAddr: "10.2.0.1:12345",
|
|
}
|
|
|
|
assert.Equal(t, "10.1.0.1", GetIpAddress(&httpRequest7, []string{"X-Real-Ip"}))
|
|
|
|
// Test with X-Forwarded-For, comma separated, untrusted
|
|
httpRequest8 := http.Request{
|
|
Header: http.Header{
|
|
"X-Forwarded-For": []string{"10.3.0.1, 10.1.0.1"},
|
|
},
|
|
RemoteAddr: "10.2.0.1:12345",
|
|
}
|
|
|
|
assert.Equal(t, "10.2.0.1", GetIpAddress(&httpRequest8, nil))
|
|
|
|
// Test with X-Forwarded-For, comma separated, untrusted
|
|
httpRequest9 := http.Request{
|
|
Header: http.Header{
|
|
"X-Forwarded-For": []string{"10.3.0.1, 10.1.0.1"},
|
|
},
|
|
RemoteAddr: "10.2.0.1:12345",
|
|
}
|
|
|
|
assert.Equal(t, "10.3.0.1", GetIpAddress(&httpRequest9, []string{"X-Forwarded-For"}))
|
|
|
|
// Test with both headers, both allowed, first one in trusted used
|
|
httpRequest10 := http.Request{
|
|
Header: http.Header{
|
|
"X-Forwarded-For": []string{"10.3.0.1"},
|
|
"X-Real-Ip": []string{"10.1.0.1"},
|
|
},
|
|
RemoteAddr: "10.2.0.1:12345",
|
|
}
|
|
|
|
assert.Equal(t, "10.1.0.1", GetIpAddress(&httpRequest10, []string{"X-Real-Ip", "X-Forwarded-For"}))
|
|
}
|
|
|
|
func TestRemoveStringFromSlice(t *testing.T) {
|
|
a := []string{"one", "two", "three", "four", "five", "six"}
|
|
expected := []string{"one", "two", "three", "five", "six"}
|
|
|
|
assert.Equal(t, RemoveStringFromSlice("four", a), expected)
|
|
}
|
|
|
|
func TestAppendQueryParamsToURL(t *testing.T) {
|
|
url := "mattermost://callback"
|
|
redirectUrl := AppendQueryParamsToURL(url, map[string]string{
|
|
"key1": "value1",
|
|
"key2": "value2",
|
|
})
|
|
expected := url + "?key1=value1&key2=value2"
|
|
assert.Equal(t, redirectUrl, expected)
|
|
}
|