mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
* Adding Upgrade to Enterprise version feature * Addressing PR review comments, and adding some minor improvements * Add tests file * Addressing PR comments * fix linter checks * Storing and exposing the upgraded from TE info * Fix showing errors on mac * A more appropiate status code for not-supported upgrade * Fixing tests * Handling permissions errors * More server logging around upgrade failures * Apply text changes suggested from code review Co-authored-by: Eric Sadur <57730300+esadur@users.noreply.github.com> * Address PR review comments * Only allow to restart the system after an upgrade * Verify file signature before upgrade * Adding limit to the downloaded file * Simplifying the upgrade binary process with backup in memory * Fixing backup/restore mechanism for the binary file * Improve file permissions handling * Askin the permissions for the right place (the parent directory) * Fixing tests * Addressing PR review comments * Fix license headers * Fixing retry layer * Making it work on windows builds * Adding license header * Fixing 2 tests * Fixing tests that need UpgradeFromTE System key mock * Extracting i18n translation * Apply suggestions from code review Co-authored-by: Eric Sadur <57730300+esadur@users.noreply.github.com> * Improving how the errors are written * Fixing another error text * Removing unneeded translation * Fixing upgrade status strings * Update i18n/en.json Co-authored-by: Eric Sadur <57730300+esadur@users.noreply.github.com> * Fixing tests Co-authored-by: Eric Sadur <57730300+esadur@users.noreply.github.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
120 lines
4.8 KiB
Go
120 lines
4.8 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/mattermost/mattermost-server/v5/model"
|
|
"github.com/mattermost/mattermost-server/v5/store/storetest/mocks"
|
|
"github.com/mattermost/mattermost-server/v5/utils/fileutils"
|
|
"github.com/stretchr/testify/mock"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestPluginPublicKeys(t *testing.T) {
|
|
th := SetupWithStoreMock(t)
|
|
defer th.TearDown()
|
|
|
|
mockStore := th.App.Srv().Store.(*mocks.Store)
|
|
mockUserStore := mocks.UserStore{}
|
|
mockUserStore.On("Count", mock.Anything).Return(int64(10), nil)
|
|
mockPostStore := mocks.PostStore{}
|
|
mockPostStore.On("GetMaxPostSize").Return(65535, nil)
|
|
mockSystemStore := mocks.SystemStore{}
|
|
mockSystemStore.On("GetByName", "UpgradedFromTE").Return(&model.System{Name: "UpgradedFromTE", Value: "false"}, nil)
|
|
mockSystemStore.On("GetByName", "InstallationDate").Return(&model.System{Name: "InstallationDate", Value: "10"}, nil)
|
|
mockSystemStore.On("GetByName", "FirstServerRunTimestamp").Return(&model.System{Name: "FirstServerRunTimestamp", Value: "10"}, nil)
|
|
|
|
mockStore.On("User").Return(&mockUserStore)
|
|
mockStore.On("Post").Return(&mockPostStore)
|
|
mockStore.On("System").Return(&mockSystemStore)
|
|
|
|
path, _ := fileutils.FindDir("tests")
|
|
publicKeyFilename := "test-public-key.plugin.gpg"
|
|
publicKey, err := ioutil.ReadFile(filepath.Join(path, publicKeyFilename))
|
|
require.Nil(t, err)
|
|
fileReader, err := os.Open(filepath.Join(path, publicKeyFilename))
|
|
require.Nil(t, err)
|
|
defer fileReader.Close()
|
|
th.App.AddPublicKey(publicKeyFilename, fileReader)
|
|
file, err := th.App.GetPublicKey(publicKeyFilename)
|
|
require.Nil(t, err)
|
|
require.Equal(t, publicKey, file)
|
|
_, err = th.App.GetPublicKey("wrong file name")
|
|
require.NotNil(t, err)
|
|
_, err = th.App.GetPublicKey("wrong-file-name.plugin.gpg")
|
|
require.NotNil(t, err)
|
|
|
|
err = th.App.DeletePublicKey("wrong file name")
|
|
require.Nil(t, err)
|
|
err = th.App.DeletePublicKey("wrong-file-name.plugin.gpg")
|
|
require.Nil(t, err)
|
|
|
|
err = th.App.DeletePublicKey(publicKeyFilename)
|
|
require.Nil(t, err)
|
|
_, err = th.App.GetPublicKey(publicKeyFilename)
|
|
require.NotNil(t, err)
|
|
}
|
|
|
|
func TestVerifySignature(t *testing.T) {
|
|
path, _ := fileutils.FindDir("tests")
|
|
pluginFilename := "testplugin.tar.gz"
|
|
signatureFilename := "testplugin.tar.gz.sig"
|
|
armoredSignatureFilename := "testplugin.tar.gz.asc"
|
|
publicKeyFilename := "development-public-key.gpg"
|
|
armoredPublicKeyFilename := "development-public-key.asc"
|
|
t.Run("verify armored signature and armored public key", func(t *testing.T) {
|
|
publicKeyFileReader, err := os.Open(filepath.Join(path, armoredPublicKeyFilename))
|
|
require.Nil(t, err)
|
|
defer publicKeyFileReader.Close()
|
|
pluginFileReader, err := os.Open(filepath.Join(path, pluginFilename))
|
|
require.Nil(t, err)
|
|
defer pluginFileReader.Close()
|
|
signatureFileReader, err := os.Open(filepath.Join(path, armoredSignatureFilename))
|
|
require.Nil(t, err)
|
|
defer signatureFileReader.Close()
|
|
require.Nil(t, verifySignature(publicKeyFileReader, pluginFileReader, signatureFileReader))
|
|
})
|
|
t.Run("verify non armored signature and armored public key", func(t *testing.T) {
|
|
publicKeyFileReader, err := os.Open(filepath.Join(path, armoredPublicKeyFilename))
|
|
require.Nil(t, err)
|
|
defer publicKeyFileReader.Close()
|
|
pluginFileReader, err := os.Open(filepath.Join(path, pluginFilename))
|
|
require.Nil(t, err)
|
|
defer pluginFileReader.Close()
|
|
signatureFileReader, err := os.Open(filepath.Join(path, signatureFilename))
|
|
require.Nil(t, err)
|
|
defer signatureFileReader.Close()
|
|
require.Nil(t, verifySignature(publicKeyFileReader, pluginFileReader, signatureFileReader))
|
|
})
|
|
t.Run("verify armored signature and non armored public key", func(t *testing.T) {
|
|
publicKeyFileReader, err := os.Open(filepath.Join(path, publicKeyFilename))
|
|
require.Nil(t, err)
|
|
defer publicKeyFileReader.Close()
|
|
pluginFileReader, err := os.Open(filepath.Join(path, pluginFilename))
|
|
require.Nil(t, err)
|
|
defer pluginFileReader.Close()
|
|
armoredSignatureFileReader, err := os.Open(filepath.Join(path, armoredSignatureFilename))
|
|
require.Nil(t, err)
|
|
defer armoredSignatureFileReader.Close()
|
|
require.Nil(t, verifySignature(publicKeyFileReader, pluginFileReader, armoredSignatureFileReader))
|
|
})
|
|
t.Run("verify non armored signature and non armored public key", func(t *testing.T) {
|
|
publicKeyFileReader, err := os.Open(filepath.Join(path, publicKeyFilename))
|
|
require.Nil(t, err)
|
|
defer publicKeyFileReader.Close()
|
|
pluginFileReader, err := os.Open(filepath.Join(path, pluginFilename))
|
|
require.Nil(t, err)
|
|
defer pluginFileReader.Close()
|
|
signatureFileReader, err := os.Open(filepath.Join(path, signatureFilename))
|
|
require.Nil(t, err)
|
|
defer signatureFileReader.Close()
|
|
require.Nil(t, verifySignature(publicKeyFileReader, pluginFileReader, signatureFileReader))
|
|
})
|
|
}
|