mirror of
https://github.com/mattermost/mattermost.git
synced 2025-02-25 18:55:24 -06:00
288ed40e8f
* Retry on failed download of plugins from marketplace. * minor polishing. * Handling http errors during downloading Adding unit test for DownloadFromURL * Adding suggested changes from the PR Close response body before returning error during progressive retry Remove separate struct for the downloadURL parameter in download_test Adding comment to clarify the share retries variable Changing to NoError and Error in the test assertion. * Added license header to download_test.go Co-authored-by: mattermod <mattermod@users.noreply.github.com>
65 lines
1.6 KiB
Go
65 lines
1.6 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"io"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"net/url"
|
|
"time"
|
|
|
|
"github.com/mattermost/mattermost-server/v5/model"
|
|
"github.com/mattermost/mattermost-server/v5/utils"
|
|
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
const (
|
|
// HTTP_REQUEST_TIMEOUT defines a high timeout for downloading large files
|
|
// from an external URL to avoid slow connections from failing to install.
|
|
HTTP_REQUEST_TIMEOUT = 1 * time.Hour
|
|
)
|
|
|
|
func (a *App) DownloadFromURL(downloadURL string) ([]byte, error) {
|
|
if !model.IsValidHttpUrl(downloadURL) {
|
|
return nil, errors.Errorf("invalid url %s", downloadURL)
|
|
}
|
|
|
|
u, err := url.ParseRequestURI(downloadURL)
|
|
if err != nil {
|
|
return nil, errors.Errorf("failed to parse url %s", downloadURL)
|
|
}
|
|
if !*a.Config().PluginSettings.AllowInsecureDownloadUrl && u.Scheme != "https" {
|
|
return nil, errors.Errorf("insecure url not allowed %s", downloadURL)
|
|
}
|
|
|
|
client := a.HTTPService().MakeClient(true)
|
|
client.Timeout = HTTP_REQUEST_TIMEOUT
|
|
|
|
var resp *http.Response
|
|
err = utils.ProgressiveRetry(func() error {
|
|
resp, err = client.Get(downloadURL)
|
|
|
|
if err != nil {
|
|
return errors.Wrapf(err, "failed to fetch from %s", downloadURL)
|
|
}
|
|
|
|
if !(resp.StatusCode >= 200 && resp.StatusCode < 300) {
|
|
_, _ = io.Copy(ioutil.Discard, resp.Body)
|
|
_ = resp.Body.Close()
|
|
return errors.Errorf("failed to fetch from %s", downloadURL)
|
|
}
|
|
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "download failed after multiple retries.")
|
|
}
|
|
|
|
defer resp.Body.Close()
|
|
|
|
return ioutil.ReadAll(resp.Body)
|
|
}
|