From 0f00d3365f88d4a1d11b81539c682c76f7eb5405 Mon Sep 17 00:00:00 2001 From: Maxim Dounin Date: Mon, 27 Feb 2017 22:36:15 +0300 Subject: [PATCH] Fixed background update with "if". Cloned subrequests should inherit r->content_handler. This way they will be able to use the same location configuration as the original request if there are "if" directives in the configuration. Without r->content_handler inherited, the following configuration tries to access a static file in the update request: location / { set $true 1; if ($true) { # nothing } proxy_pass http://backend; proxy_cache one; proxy_cache_use_stale updating; proxy_cache_background_update on; } See http://mailman.nginx.org/pipermail/nginx/2017-February/053019.html for initial report. --- src/http/ngx_http_core_module.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/http/ngx_http_core_module.c b/src/http/ngx_http_core_module.c index 9e128908a..6e31a2ade 100644 --- a/src/http/ngx_http_core_module.c +++ b/src/http/ngx_http_core_module.c @@ -2571,6 +2571,7 @@ ngx_http_subrequest(ngx_http_request_t *r, sr->method_name = r->method_name; sr->loc_conf = r->loc_conf; sr->valid_location = r->valid_location; + sr->content_handler = r->content_handler; sr->phase_handler = r->phase_handler; sr->write_event_handler = ngx_http_core_run_phases;