IntenseWebs/nginx
3
0
Fork 0
mirror of https://github.com/nginx/nginx.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

QUIC: removed excessive check.

Browse Source 
The c->udp->dgram may be NULL only if the quic connection was just
created: the ngx_event_udp_recvmsg() passes information about datagrams
to existing connections by providing information in c->udp.

If case of a new connection, c->udp is allocated by the QUIC code during
creation of quic connection (it uses c->sockaddr to initialize qsock->path).

Thus the check for qsock->path is excessive and can be read wrong, assuming
that other options possible, leading to warnings from clang static analyzer.
This commit is contained in:
Vladimir Homutov 2021-12-01 18:33:29 +03:00
parent a981efe6e8
commit 468641cbc3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/event/quic/ngx_event_quic_migration.c
View File

@ -289,7 +289,7 @@ ngx_quic_update_paths(ngx_connection_t *c, ngx_quic_header_t *pkt)
qsock = ngx_quic_get_socket(c); qsock = ngx_quic_get_socket(c);
if (c->udp->dgram == NULL && qsock->path) { if (c->udp->dgram == NULL) {
/* 1st ever packet in connection, path already exists */ /* 1st ever packet in connection, path already exists */
path = qsock->path; path = qsock->path;
goto update; goto update;