IntenseWebs/nginx
3
0
Fork 0
mirror of https://github.com/nginx/nginx.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed "return" with discarding invalid chunked body.

Browse Source 
When ngx_http_discard_request_body() call was added to ngx_http_send_response(),
there were no return codes other than NGX_OK and NGX_HTTP_INTERNAL_SERVER_ERROR.
Now it can also return NGX_HTTP_BAD_REQUEST, but ngx_http_send_response() still
incorrectly transforms it to NGX_HTTP_INTERNAL_SERVER_ERROR.

The fix is to propagate ngx_http_discard_request_body() errors.
This commit is contained in:
Sergey Kandaurov
2019-09-04 13:33:51 +03:00
parent 77c01f10a1
commit 5a2ce3f4ee
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/http/ngx_http_core_module.c
View File

@@ -1660,8 +1660,10 @@ ngx_http_send_response(ngx_http_request_t *r, ngx_uint_t status,
ngx_buf_t *b; ngx_buf_t *b;
ngx_chain_t out; ngx_chain_t out;
if (ngx_http_discard_request_body(r) != NGX_OK) { rc = ngx_http_discard_request_body(r);
return NGX_HTTP_INTERNAL_SERVER_ERROR;
if (rc != NGX_OK) {
return rc;
} }
r->headers_out.status = status; r->headers_out.status = status;