IntenseWebs/nginx
3
0
Fork 0
mirror of https://github.com/nginx/nginx.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Do not set timers after the connection is closed.

Browse Source 
The qc->closing flag is set when a connection close is initiated for the first
time.

No timers will be set if the flag is active.

TODO: this is a temporary solution to avoid running timer handlers after
connection (and it's pool) was destroyed.  It looks like currently we have
no clear policy of connection closing in regard to timers.
This commit is contained in:
Vladimir Homutov 2020-04-04 22:27:29 +03:00
parent 3f3315aea6
commit 5b41275219
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/event/ngx_event_quic.c
View File

@ -704,6 +704,7 @@ ngx_quic_close_connection(ngx_connection_t *c)
qc = c->quic;
if (qc) {
qc->closing = 1;
tree = &qc->streams.tree;
if (tree->root != tree->sentinel) {
@ -727,6 +728,10 @@ ngx_quic_close_connection(ngx_connection_t *c)
ngx_post_event(rev, &ngx_posted_events);
if (rev->timer_set) {
ngx_del_timer(rev);
}
#if (NGX_DEBUG)
ns++;
#endif
@ -735,7 +740,6 @@ ngx_quic_close_connection(ngx_connection_t *c)
ngx_log_debug1(NGX_LOG_DEBUG_EVENT, c->log, 0,
"quic connection has %ui active streams", ns);
qc->closing = 1;
return;
}
@ -1622,7 +1626,7 @@ ngx_quic_output(ngx_connection_t *c)
}
}
if (!qc->send_timer_set) {
if (!qc->send_timer_set && !qc->closing) {
qc->send_timer_set = 1;
ngx_add_timer(c->read, qc->tp.max_idle_timeout);
}