From 72d0668627ae2ee8a8d33d9d9e65ebc5c11e1e38 Mon Sep 17 00:00:00 2001 From: Vladimir Homutov Date: Wed, 9 Feb 2022 15:53:21 +0300 Subject: [PATCH] QUIC: fixed output context restoring. The cd8018bc81a5 fixed unintended send of non-padded initial packets, but failed to restore context properly: only processed contexts need to be restored. As a consequence, a packet number could be restored from uninitialized value. --- src/event/quic/ngx_event_quic_output.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/event/quic/ngx_event_quic_output.c b/src/event/quic/ngx_event_quic_output.c index ebfe0cfc2..72a678c3d 100644 --- a/src/event/quic/ngx_event_quic_output.c +++ b/src/event/quic/ngx_event_quic_output.c @@ -165,7 +165,7 @@ ngx_quic_create_datagrams(ngx_connection_t *c) if (min > len) { /* padding can't be applied - avoid sending the packet */ - for (i = 0; i < NGX_QUIC_SEND_CTX_LAST; i++) { + while (i-- > 0) { ctx = &qc->send_ctx[i]; ngx_quic_revert_send(c, ctx, preserved_pnum[i]); }