IntenseWebs/nginx
3
0
Fork 0
mirror of https://github.com/nginx/nginx.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Decoupled validation of Host and :authority for HTTP/2 and HTTP/3.

Browse Source 
Previously an error was triggered for HTTP/2 when host with port was passed
by client.
This commit is contained in:
Roman Arutyunyan 2020-06-02 15:59:14 +03:00
parent 0a11fdbb28
commit c0003539ac
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/http/ngx_http_request.c
View File

@ -2065,10 +2065,18 @@ ngx_http_process_request_header(ngx_http_request_t *r)
return NGX_ERROR;
}
if (r->http_version >= NGX_HTTP_VERSION_20) {
if (r->headers_in.host == NULL && r->http_version == NGX_HTTP_VERSION_20) {
ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
"client sent HTTP/2 request without "
"\":authority\" or \"Host\" header");
ngx_http_finalize_request(r, NGX_HTTP_BAD_REQUEST);
return NGX_ERROR;
}
if (r->http_version == NGX_HTTP_VERSION_30) {
if (r->headers_in.server.len == 0) {
ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
"client sent HTTP request without "
"client sent HTTP/3 request without "
"\":authority\" or \"Host\" header");
ngx_http_finalize_request(r, NGX_HTTP_BAD_REQUEST);
return NGX_ERROR;
@ -2082,7 +2090,7 @@ ngx_http_process_request_header(ngx_http_request_t *r)
!= 0)
{
ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
"client sent HTTP request with different "
"client sent HTTP/3 request with different "
"values of \":authority\" and \"Host\" headers");
ngx_http_finalize_request(r, NGX_HTTP_BAD_REQUEST);
return NGX_ERROR;