From d54d551e2a880c7a7691a83d212eb707eb0f82ba Mon Sep 17 00:00:00 2001 From: Roman Arutyunyan Date: Wed, 30 Jun 2021 13:47:38 +0300 Subject: [PATCH] QUIC: consider max_ack_delay=16384 invalid. As per RFC 9000: Values of 2^14 or greater are invalid. --- src/event/quic/ngx_event_quic.c | 2 +- src/http/modules/ngx_http_quic_module.c | 2 +- src/stream/ngx_stream_quic_module.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/event/quic/ngx_event_quic.c b/src/event/quic/ngx_event_quic.c index f0dd943a6..0d61be837 100644 --- a/src/event/quic/ngx_event_quic.c +++ b/src/event/quic/ngx_event_quic.c @@ -176,7 +176,7 @@ ngx_quic_apply_transport_params(ngx_connection_t *c, ngx_quic_tp_t *ctp) return NGX_ERROR; } - if (ctp->max_ack_delay > 16384) { + if (ctp->max_ack_delay >= 16384) { qc->error = NGX_QUIC_ERR_TRANSPORT_PARAMETER_ERROR; qc->error_reason = "invalid max_ack_delay"; diff --git a/src/http/modules/ngx_http_quic_module.c b/src/http/modules/ngx_http_quic_module.c index 2354dfd8b..d933dd1f9 100644 --- a/src/http/modules/ngx_http_quic_module.c +++ b/src/http/modules/ngx_http_quic_module.c @@ -394,7 +394,7 @@ ngx_http_quic_max_ack_delay(ngx_conf_t *cf, void *post, void *data) { ngx_msec_t *sp = data; - if (*sp > 16384) { + if (*sp >= 16384) { ngx_conf_log_error(NGX_LOG_EMERG, cf, 0, "\"quic_max_ack_delay\" must be less than 16384"); diff --git a/src/stream/ngx_stream_quic_module.c b/src/stream/ngx_stream_quic_module.c index 6567b16cf..01caa9555 100644 --- a/src/stream/ngx_stream_quic_module.c +++ b/src/stream/ngx_stream_quic_module.c @@ -354,7 +354,7 @@ ngx_stream_quic_max_ack_delay(ngx_conf_t *cf, void *post, void *data) { ngx_msec_t *sp = data; - if (*sp > 16384) { + if (*sp >= 16384) { ngx_conf_log_error(NGX_LOG_EMERG, cf, 0, "\"quic_max_ack_delay\" must be less than 16384");