From ed506f8e15d2b84b3122d692299755e2731b3c79 Mon Sep 17 00:00:00 2001 From: Vladimir Homutov Date: Thu, 23 Apr 2020 12:25:00 +0300 Subject: [PATCH] TODOs cleanup in transport. We always generate stream frames that have length. The 'len' member is used during parsing incoming frames and can be safely ignored when generating output. --- src/event/ngx_event_quic_transport.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/event/ngx_event_quic_transport.c b/src/event/ngx_event_quic_transport.c index 546a25168..150deef98 100644 --- a/src/event/ngx_event_quic_transport.c +++ b/src/event/ngx_event_quic_transport.c @@ -1267,15 +1267,6 @@ ngx_quic_create_stream(u_char *p, ngx_quic_stream_frame_t *sf) size_t len; u_char *start; - if (!sf->len) { -#if 0 - ngx_log_error(NGX_LOG_INFO, log, 0, - "attempt to generate a stream frame without length"); -#endif - // XXX: handle error in caller - return NGX_ERROR; - } - if (p == NULL) { len = ngx_quic_varint_len(sf->type); @@ -1345,7 +1336,7 @@ ngx_quic_parse_transport_param(u_char *p, u_char *end, uint16_t id, case NGX_QUIC_TP_ORIGINAL_CONNECTION_ID: case NGX_QUIC_TP_STATELESS_RESET_TOKEN: case NGX_QUIC_TP_PREFERRED_ADDRESS: - // TODO + /* TODO: implement */ return NGX_DECLINED; }