From fec3d792c98315cbbdd58d2a5e3605e485e780e8 Mon Sep 17 00:00:00 2001 From: Sergey Kandaurov Date: Thu, 22 Oct 2020 11:05:50 +0100 Subject: [PATCH] QUIC: restored proper usage of ngx_quic_drop_ack_ranges(). ACK Ranges are again managed based on the remembered Largest Acknowledged sent in the packet being acknowledged, which partially reverts c01964fd7b8b. --- src/event/ngx_event_quic.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/event/ngx_event_quic.c b/src/event/ngx_event_quic.c index 7848a77ac..70fb09eeb 100644 --- a/src/event/ngx_event_quic.c +++ b/src/event/ngx_event_quic.c @@ -2799,8 +2799,6 @@ ngx_quic_handle_ack_frame(ngx_connection_t *c, ngx_quic_header_t *pkt, } } - ngx_quic_drop_ack_ranges(c, ctx, ack->largest); - pos = ack->ranges_start; end = ack->ranges_end; @@ -2871,6 +2869,10 @@ ngx_quic_handle_ack_frame_range(ngx_connection_t *c, ngx_quic_send_ctx_t *ctx, ngx_quic_congestion_ack(c, f); switch (f->type) { + case NGX_QUIC_FT_ACK: + case NGX_QUIC_FT_ACK_ECN: + ngx_quic_drop_ack_ranges(c, ctx, f->u.ack.largest); + break; case NGX_QUIC_FT_STREAM0: case NGX_QUIC_FT_STREAM1: