2016-09-20 11:32:34 -05:00
|
|
|
package terraform
|
|
|
|
|
2016-09-20 12:16:49 -05:00
|
|
|
import (
|
|
|
|
"log"
|
|
|
|
|
2021-05-17 14:00:50 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/addrs"
|
2021-05-17 14:43:35 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/states"
|
terraform: ugly huge change to weave in new HCL2-oriented types
Due to how deeply the configuration types go into Terraform Core, there
isn't a great way to switch out to HCL2 gradually. As a consequence, this
huge commit gets us from the old state to a _compilable_ new state, but
does not yet attempt to fix any tests and has a number of known missing
parts and bugs. We will continue to iterate on this in forthcoming
commits, heading back towards passing tests and making Terraform
fully-functional again.
The three main goals here are:
- Use the configuration models from the "configs" package instead of the
older models in the "config" package, which is now deprecated and
preserved only to help us write our migration tool.
- Do expression inspection and evaluation using the functionality of the
new "lang" package, instead of the Interpolator type and related
functionality in the main "terraform" package.
- Represent addresses of various objects using types in the addrs package,
rather than hand-constructed strings. This is not critical to support
the above, but was a big help during the implementation of these other
points since it made it much more explicit what kind of address is
expected in each context.
Since our new packages are built to accommodate some future planned
features that are not yet implemented (e.g. the "for_each" argument on
resources, "count"/"for_each" on modules), and since there's still a fair
amount of functionality still using old-style APIs, there is a moderate
amount of shimming here to connect new assumptions with old, hopefully in
a way that makes it easier to find and eliminate these shims later.
I apologize in advance to the person who inevitably just found this huge
commit while spelunking through the commit history.
2018-04-30 12:33:53 -05:00
|
|
|
|
2021-05-17 14:17:09 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/configs"
|
2021-05-17 11:30:37 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/dag"
|
2016-09-20 12:16:49 -05:00
|
|
|
)
|
|
|
|
|
2016-09-20 11:32:34 -05:00
|
|
|
// GraphNodeDestroyer must be implemented by nodes that destroy resources.
|
|
|
|
type GraphNodeDestroyer interface {
|
2016-09-20 12:16:49 -05:00
|
|
|
dag.Vertex
|
|
|
|
|
terraform: ugly huge change to weave in new HCL2-oriented types
Due to how deeply the configuration types go into Terraform Core, there
isn't a great way to switch out to HCL2 gradually. As a consequence, this
huge commit gets us from the old state to a _compilable_ new state, but
does not yet attempt to fix any tests and has a number of known missing
parts and bugs. We will continue to iterate on this in forthcoming
commits, heading back towards passing tests and making Terraform
fully-functional again.
The three main goals here are:
- Use the configuration models from the "configs" package instead of the
older models in the "config" package, which is now deprecated and
preserved only to help us write our migration tool.
- Do expression inspection and evaluation using the functionality of the
new "lang" package, instead of the Interpolator type and related
functionality in the main "terraform" package.
- Represent addresses of various objects using types in the addrs package,
rather than hand-constructed strings. This is not critical to support
the above, but was a big help during the implementation of these other
points since it made it much more explicit what kind of address is
expected in each context.
Since our new packages are built to accommodate some future planned
features that are not yet implemented (e.g. the "for_each" argument on
resources, "count"/"for_each" on modules), and since there's still a fair
amount of functionality still using old-style APIs, there is a moderate
amount of shimming here to connect new assumptions with old, hopefully in
a way that makes it easier to find and eliminate these shims later.
I apologize in advance to the person who inevitably just found this huge
commit while spelunking through the commit history.
2018-04-30 12:33:53 -05:00
|
|
|
// DestroyAddr is the address of the resource that is being
|
2016-09-20 11:32:34 -05:00
|
|
|
// destroyed by this node. If this returns nil, then this node
|
|
|
|
// is not destroying anything.
|
terraform: ugly huge change to weave in new HCL2-oriented types
Due to how deeply the configuration types go into Terraform Core, there
isn't a great way to switch out to HCL2 gradually. As a consequence, this
huge commit gets us from the old state to a _compilable_ new state, but
does not yet attempt to fix any tests and has a number of known missing
parts and bugs. We will continue to iterate on this in forthcoming
commits, heading back towards passing tests and making Terraform
fully-functional again.
The three main goals here are:
- Use the configuration models from the "configs" package instead of the
older models in the "config" package, which is now deprecated and
preserved only to help us write our migration tool.
- Do expression inspection and evaluation using the functionality of the
new "lang" package, instead of the Interpolator type and related
functionality in the main "terraform" package.
- Represent addresses of various objects using types in the addrs package,
rather than hand-constructed strings. This is not critical to support
the above, but was a big help during the implementation of these other
points since it made it much more explicit what kind of address is
expected in each context.
Since our new packages are built to accommodate some future planned
features that are not yet implemented (e.g. the "for_each" argument on
resources, "count"/"for_each" on modules), and since there's still a fair
amount of functionality still using old-style APIs, there is a moderate
amount of shimming here to connect new assumptions with old, hopefully in
a way that makes it easier to find and eliminate these shims later.
I apologize in advance to the person who inevitably just found this huge
commit while spelunking through the commit history.
2018-04-30 12:33:53 -05:00
|
|
|
DestroyAddr() *addrs.AbsResourceInstance
|
2016-09-20 11:32:34 -05:00
|
|
|
}
|
|
|
|
|
2016-09-21 12:55:07 -05:00
|
|
|
// GraphNodeCreator must be implemented by nodes that create OR update resources.
|
|
|
|
type GraphNodeCreator interface {
|
terraform: ugly huge change to weave in new HCL2-oriented types
Due to how deeply the configuration types go into Terraform Core, there
isn't a great way to switch out to HCL2 gradually. As a consequence, this
huge commit gets us from the old state to a _compilable_ new state, but
does not yet attempt to fix any tests and has a number of known missing
parts and bugs. We will continue to iterate on this in forthcoming
commits, heading back towards passing tests and making Terraform
fully-functional again.
The three main goals here are:
- Use the configuration models from the "configs" package instead of the
older models in the "config" package, which is now deprecated and
preserved only to help us write our migration tool.
- Do expression inspection and evaluation using the functionality of the
new "lang" package, instead of the Interpolator type and related
functionality in the main "terraform" package.
- Represent addresses of various objects using types in the addrs package,
rather than hand-constructed strings. This is not critical to support
the above, but was a big help during the implementation of these other
points since it made it much more explicit what kind of address is
expected in each context.
Since our new packages are built to accommodate some future planned
features that are not yet implemented (e.g. the "for_each" argument on
resources, "count"/"for_each" on modules), and since there's still a fair
amount of functionality still using old-style APIs, there is a moderate
amount of shimming here to connect new assumptions with old, hopefully in
a way that makes it easier to find and eliminate these shims later.
I apologize in advance to the person who inevitably just found this huge
commit while spelunking through the commit history.
2018-04-30 12:33:53 -05:00
|
|
|
// CreateAddr is the address of the resource being created or updated
|
|
|
|
CreateAddr() *addrs.AbsResourceInstance
|
2016-09-21 12:55:07 -05:00
|
|
|
}
|
|
|
|
|
2016-09-20 11:32:34 -05:00
|
|
|
// DestroyEdgeTransformer is a GraphTransformer that creates the proper
|
|
|
|
// references for destroy resources. Destroy resources are more complex
|
|
|
|
// in that they must be depend on the destruction of resources that
|
|
|
|
// in turn depend on the CREATION of the node being destroy.
|
|
|
|
//
|
|
|
|
// That is complicated. Visually:
|
|
|
|
//
|
|
|
|
// B_d -> A_d -> A -> B
|
|
|
|
//
|
|
|
|
// Notice that A destroy depends on B destroy, while B create depends on
|
|
|
|
// A create. They're inverted. This must be done for example because often
|
|
|
|
// dependent resources will block parent resources from deleting. Concrete
|
|
|
|
// example: VPC with subnets, the VPC can't be deleted while there are
|
|
|
|
// still subnets.
|
2016-09-20 12:16:49 -05:00
|
|
|
type DestroyEdgeTransformer struct {
|
2016-12-10 19:11:24 -06:00
|
|
|
// These are needed to properly build the graph of dependencies
|
|
|
|
// to determine what a destroy node depends on. Any of these can be nil.
|
terraform: ugly huge change to weave in new HCL2-oriented types
Due to how deeply the configuration types go into Terraform Core, there
isn't a great way to switch out to HCL2 gradually. As a consequence, this
huge commit gets us from the old state to a _compilable_ new state, but
does not yet attempt to fix any tests and has a number of known missing
parts and bugs. We will continue to iterate on this in forthcoming
commits, heading back towards passing tests and making Terraform
fully-functional again.
The three main goals here are:
- Use the configuration models from the "configs" package instead of the
older models in the "config" package, which is now deprecated and
preserved only to help us write our migration tool.
- Do expression inspection and evaluation using the functionality of the
new "lang" package, instead of the Interpolator type and related
functionality in the main "terraform" package.
- Represent addresses of various objects using types in the addrs package,
rather than hand-constructed strings. This is not critical to support
the above, but was a big help during the implementation of these other
points since it made it much more explicit what kind of address is
expected in each context.
Since our new packages are built to accommodate some future planned
features that are not yet implemented (e.g. the "for_each" argument on
resources, "count"/"for_each" on modules), and since there's still a fair
amount of functionality still using old-style APIs, there is a moderate
amount of shimming here to connect new assumptions with old, hopefully in
a way that makes it easier to find and eliminate these shims later.
I apologize in advance to the person who inevitably just found this huge
commit while spelunking through the commit history.
2018-04-30 12:33:53 -05:00
|
|
|
Config *configs.Config
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
State *states.State
|
2016-09-20 12:16:49 -05:00
|
|
|
}
|
2016-09-20 11:32:34 -05:00
|
|
|
|
|
|
|
func (t *DestroyEdgeTransformer) Transform(g *Graph) error {
|
|
|
|
// Build a map of what is being destroyed (by address string) to
|
2019-10-17 15:05:27 -05:00
|
|
|
// the list of destroyers.
|
2016-09-20 11:32:34 -05:00
|
|
|
destroyers := make(map[string][]GraphNodeDestroyer)
|
2019-10-17 15:05:27 -05:00
|
|
|
|
2019-10-30 14:59:34 -05:00
|
|
|
// Record the creators, which will need to depend on the destroyers if they
|
|
|
|
// are only being updated.
|
2021-03-21 11:14:47 -05:00
|
|
|
creators := make(map[string][]GraphNodeCreator)
|
2019-10-30 14:59:34 -05:00
|
|
|
|
2020-06-25 14:23:00 -05:00
|
|
|
// destroyersByResource records each destroyer by the ConfigResource
|
|
|
|
// address. We use this because dependencies are only referenced as
|
|
|
|
// resources and have no index or module instance information, but we will
|
|
|
|
// want to connect all the individual instances for correct ordering.
|
2019-10-17 15:05:27 -05:00
|
|
|
destroyersByResource := make(map[string][]GraphNodeDestroyer)
|
2016-09-20 11:32:34 -05:00
|
|
|
for _, v := range g.Vertices() {
|
2019-10-30 14:59:34 -05:00
|
|
|
switch n := v.(type) {
|
|
|
|
case GraphNodeDestroyer:
|
|
|
|
addrP := n.DestroyAddr()
|
|
|
|
if addrP == nil {
|
|
|
|
log.Printf("[WARN] DestroyEdgeTransformer: %q (%T) has no destroy address", dag.VertexName(n), v)
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
addr := *addrP
|
|
|
|
|
|
|
|
key := addr.String()
|
|
|
|
log.Printf("[TRACE] DestroyEdgeTransformer: %q (%T) destroys %s", dag.VertexName(n), v, key)
|
|
|
|
destroyers[key] = append(destroyers[key], n)
|
|
|
|
|
2020-06-25 14:23:00 -05:00
|
|
|
resAddr := addr.ContainingResource().Config().String()
|
2019-10-30 14:59:34 -05:00
|
|
|
destroyersByResource[resAddr] = append(destroyersByResource[resAddr], n)
|
|
|
|
case GraphNodeCreator:
|
2021-03-21 11:14:47 -05:00
|
|
|
addr := n.CreateAddr().ContainingResource().Config().String()
|
|
|
|
creators[addr] = append(creators[addr], n)
|
2016-09-20 11:32:34 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// If we aren't destroying anything, there will be no edges to make
|
|
|
|
// so just exit early and avoid future work.
|
|
|
|
if len(destroyers) == 0 {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2019-10-30 14:59:34 -05:00
|
|
|
// Connect destroy despendencies as stored in the state
|
2019-10-17 15:05:27 -05:00
|
|
|
for _, ds := range destroyers {
|
|
|
|
for _, des := range ds {
|
2019-10-30 14:59:34 -05:00
|
|
|
ri, ok := des.(GraphNodeResourceInstance)
|
2019-10-17 15:05:27 -05:00
|
|
|
if !ok {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, resAddr := range ri.StateDependencies() {
|
|
|
|
for _, desDep := range destroyersByResource[resAddr.String()] {
|
2020-07-16 18:11:08 -05:00
|
|
|
if !graphNodesAreResourceInstancesInDifferentInstancesOfSameModule(desDep, des) {
|
|
|
|
log.Printf("[TRACE] DestroyEdgeTransformer: %s has stored dependency of %s\n", dag.VertexName(desDep), dag.VertexName(des))
|
|
|
|
g.Connect(dag.BasicEdge(desDep, des))
|
|
|
|
} else {
|
|
|
|
log.Printf("[TRACE] DestroyEdgeTransformer: skipping %s => %s inter-module-instance dependency\n", dag.VertexName(desDep), dag.VertexName(des))
|
|
|
|
}
|
2019-10-17 15:05:27 -05:00
|
|
|
}
|
2021-03-21 11:14:47 -05:00
|
|
|
|
|
|
|
// We can have some create or update nodes which were
|
|
|
|
// dependents of the destroy node. If they have no destroyer
|
|
|
|
// themselves, make the connection directly from the creator.
|
|
|
|
for _, createDep := range creators[resAddr.String()] {
|
|
|
|
if !graphNodesAreResourceInstancesInDifferentInstancesOfSameModule(createDep, des) {
|
|
|
|
log.Printf("[DEBUG] DestroyEdgeTransformer: %s has stored dependency of %s\n", dag.VertexName(createDep), dag.VertexName(des))
|
|
|
|
g.Connect(dag.BasicEdge(createDep, des))
|
|
|
|
} else {
|
|
|
|
log.Printf("[TRACE] DestroyEdgeTransformer: skipping %s => %s inter-module-instance dependency\n", dag.VertexName(createDep), dag.VertexName(des))
|
|
|
|
}
|
|
|
|
}
|
2019-10-17 15:05:27 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-10-30 14:59:34 -05:00
|
|
|
// connect creators to any destroyers on which they may depend
|
2021-03-21 11:14:47 -05:00
|
|
|
for _, cs := range creators {
|
|
|
|
for _, c := range cs {
|
|
|
|
ri, ok := c.(GraphNodeResourceInstance)
|
|
|
|
if !ok {
|
|
|
|
continue
|
|
|
|
}
|
2019-10-30 14:59:34 -05:00
|
|
|
|
2021-03-21 11:14:47 -05:00
|
|
|
for _, resAddr := range ri.StateDependencies() {
|
|
|
|
for _, desDep := range destroyersByResource[resAddr.String()] {
|
|
|
|
if !graphNodesAreResourceInstancesInDifferentInstancesOfSameModule(c, desDep) {
|
|
|
|
log.Printf("[TRACE] DestroyEdgeTransformer: %s has stored dependency of %s\n", dag.VertexName(c), dag.VertexName(desDep))
|
|
|
|
g.Connect(dag.BasicEdge(c, desDep))
|
|
|
|
} else {
|
|
|
|
log.Printf("[TRACE] DestroyEdgeTransformer: skipping %s => %s inter-module-instance dependency\n", dag.VertexName(c), dag.VertexName(desDep))
|
|
|
|
}
|
2020-07-16 18:11:08 -05:00
|
|
|
}
|
2019-10-30 14:59:34 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-09-21 12:55:07 -05:00
|
|
|
// Go through and connect creators to destroyers. Going along with
|
|
|
|
// our example, this makes: A_d => A
|
|
|
|
for _, v := range g.Vertices() {
|
|
|
|
cn, ok := v.(GraphNodeCreator)
|
|
|
|
if !ok {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
addr := cn.CreateAddr()
|
|
|
|
if addr == nil {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
2019-10-17 15:05:27 -05:00
|
|
|
for _, d := range destroyers[addr.String()] {
|
2016-09-21 12:55:07 -05:00
|
|
|
// For illustrating our example
|
|
|
|
a_d := d.(dag.Vertex)
|
|
|
|
a := v
|
|
|
|
|
2016-09-21 13:03:04 -05:00
|
|
|
log.Printf(
|
2018-05-09 19:05:18 -05:00
|
|
|
"[TRACE] DestroyEdgeTransformer: connecting creator %q with destroyer %q",
|
2016-09-21 13:03:04 -05:00
|
|
|
dag.VertexName(a), dag.VertexName(a_d))
|
|
|
|
|
2019-11-19 16:31:38 -06:00
|
|
|
g.Connect(dag.BasicEdge(a, a_d))
|
2016-09-21 12:55:07 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-05-18 19:59:17 -05:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2020-05-20 12:45:31 -05:00
|
|
|
// Remove any nodes that aren't needed when destroying modules.
|
|
|
|
// Variables, outputs, locals, and expanders may not be able to evaluate
|
|
|
|
// correctly, so we can remove these if nothing depends on them. The module
|
|
|
|
// closers also need to disable their use of expansion if the module itself is
|
|
|
|
// no longer present.
|
|
|
|
type pruneUnusedNodesTransformer struct {
|
2019-09-28 19:34:55 -05:00
|
|
|
}
|
|
|
|
|
2020-05-20 12:45:31 -05:00
|
|
|
func (t *pruneUnusedNodesTransformer) Transform(g *Graph) error {
|
|
|
|
// We need a reverse depth first walk of modules, processing them in order
|
|
|
|
// from the leaf modules to the root. This allows us to remove unneeded
|
|
|
|
// dependencies from child modules, freeing up nodes in the parent module
|
|
|
|
// to also be removed.
|
2020-05-18 19:59:17 -05:00
|
|
|
|
2020-08-18 15:34:44 -05:00
|
|
|
nodes := g.Vertices()
|
2019-09-28 19:34:55 -05:00
|
|
|
|
2020-08-18 15:34:44 -05:00
|
|
|
for removed := true; removed; {
|
2020-05-18 19:59:17 -05:00
|
|
|
removed = false
|
|
|
|
|
|
|
|
for i := 0; i < len(nodes); i++ {
|
2020-05-20 12:45:31 -05:00
|
|
|
// run this in a closure, so we can return early rather than
|
|
|
|
// dealing with complex looping and labels
|
|
|
|
func() {
|
|
|
|
n := nodes[i]
|
2020-07-09 14:54:42 -05:00
|
|
|
switch n := n.(type) {
|
2020-05-20 12:45:31 -05:00
|
|
|
case graphNodeTemporaryValue:
|
2020-07-09 14:54:42 -05:00
|
|
|
// root module outputs indicate they are not temporary by
|
|
|
|
// returning false here.
|
|
|
|
if !n.temporaryValue() {
|
|
|
|
return
|
2020-05-18 19:59:17 -05:00
|
|
|
}
|
2020-07-09 14:54:42 -05:00
|
|
|
|
|
|
|
// temporary values, which consist of variables, locals,
|
|
|
|
// and outputs, must be kept if anything refers to them.
|
2020-05-28 08:01:52 -05:00
|
|
|
for _, v := range g.UpEdges(n) {
|
2020-05-20 12:45:31 -05:00
|
|
|
// keep any value which is connected through a
|
|
|
|
// reference
|
2020-05-28 08:01:52 -05:00
|
|
|
if _, ok := v.(GraphNodeReferencer); ok {
|
2020-05-20 12:45:31 -05:00
|
|
|
return
|
|
|
|
}
|
2020-05-18 19:59:17 -05:00
|
|
|
}
|
2019-09-28 19:34:55 -05:00
|
|
|
|
2020-05-21 21:11:58 -05:00
|
|
|
case graphNodeExpandsInstances:
|
2020-05-20 12:45:31 -05:00
|
|
|
// Any nodes that expand instances are kept when their
|
|
|
|
// instances may need to be evaluated.
|
2020-05-28 08:01:52 -05:00
|
|
|
for _, v := range g.UpEdges(n) {
|
|
|
|
switch v.(type) {
|
2020-05-21 21:11:58 -05:00
|
|
|
case graphNodeExpandsInstances:
|
|
|
|
// expanders can always depend on module expansion
|
|
|
|
// themselves
|
|
|
|
return
|
|
|
|
case GraphNodeResourceInstance:
|
|
|
|
// resource instances always depend on their
|
|
|
|
// resource node, which is an expander
|
2020-05-20 12:45:31 -05:00
|
|
|
return
|
|
|
|
}
|
2020-05-18 19:59:17 -05:00
|
|
|
}
|
|
|
|
|
2021-03-08 13:52:43 -06:00
|
|
|
case GraphNodeProvider:
|
|
|
|
// Providers that may have been required by expansion nodes
|
|
|
|
// that we no longer need can also be removed.
|
|
|
|
if g.UpEdges(n).Len() > 0 {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2020-05-20 12:45:31 -05:00
|
|
|
default:
|
|
|
|
return
|
|
|
|
}
|
2020-05-18 19:59:17 -05:00
|
|
|
|
2020-05-28 08:01:52 -05:00
|
|
|
log.Printf("[DEBUG] pruneUnusedNodes: %s is no longer needed, removing", dag.VertexName(n))
|
2020-05-20 12:45:31 -05:00
|
|
|
g.Remove(n)
|
|
|
|
removed = true
|
2020-05-18 19:59:17 -05:00
|
|
|
|
2020-05-20 12:45:31 -05:00
|
|
|
// remove the node from our iteration as well
|
|
|
|
last := len(nodes) - 1
|
|
|
|
nodes[i], nodes[last] = nodes[last], nodes[i]
|
|
|
|
nodes = nodes[:last]
|
|
|
|
}()
|
2019-09-28 19:34:55 -05:00
|
|
|
}
|
|
|
|
}
|
2020-08-18 15:34:44 -05:00
|
|
|
|
|
|
|
return nil
|
2016-09-20 11:32:34 -05:00
|
|
|
}
|