2014-06-18 23:36:44 -05:00
|
|
|
package command
|
|
|
|
|
|
|
|
import (
|
2017-01-18 22:50:45 -06:00
|
|
|
"bytes"
|
2021-11-01 15:09:16 -05:00
|
|
|
"context"
|
2017-01-18 22:50:45 -06:00
|
|
|
"crypto/md5"
|
|
|
|
"encoding/base64"
|
|
|
|
"encoding/json"
|
2017-02-03 14:32:40 -06:00
|
|
|
"fmt"
|
2016-11-30 13:36:54 -06:00
|
|
|
"io"
|
2014-06-27 16:43:23 -05:00
|
|
|
"io/ioutil"
|
2017-01-18 22:50:45 -06:00
|
|
|
"net/http"
|
|
|
|
"net/http/httptest"
|
2014-06-27 16:43:23 -05:00
|
|
|
"os"
|
2017-02-03 14:32:40 -06:00
|
|
|
"os/exec"
|
2022-07-12 16:00:36 -05:00
|
|
|
"path"
|
2014-06-18 23:36:44 -05:00
|
|
|
"path/filepath"
|
2015-02-26 12:29:23 -06:00
|
|
|
"strings"
|
2017-02-03 14:32:40 -06:00
|
|
|
"syscall"
|
2014-06-27 16:43:23 -05:00
|
|
|
"testing"
|
2014-06-18 23:36:44 -05:00
|
|
|
|
2022-08-29 14:29:07 -05:00
|
|
|
"github.com/google/go-cmp/cmp"
|
|
|
|
|
2020-05-25 14:24:35 -05:00
|
|
|
svchost "github.com/hashicorp/terraform-svchost"
|
2021-05-17 11:45:36 -05:00
|
|
|
"github.com/hashicorp/terraform-svchost/disco"
|
2021-05-17 14:00:50 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/addrs"
|
2021-05-17 11:45:36 -05:00
|
|
|
backendInit "github.com/hashicorp/terraform/internal/backend/init"
|
|
|
|
backendLocal "github.com/hashicorp/terraform/internal/backend/local"
|
2021-05-17 14:07:38 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/command/views"
|
2021-09-01 19:01:44 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/command/workdir"
|
2021-05-17 14:17:09 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/configs"
|
|
|
|
"github.com/hashicorp/terraform/internal/configs/configload"
|
|
|
|
"github.com/hashicorp/terraform/internal/configs/configschema"
|
2020-10-07 11:48:25 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/copy"
|
backend/local: Check dependency lock consistency before any operations
In historical versions of Terraform the responsibility to check this was
inside the terraform.NewContext function, along with various other
assorted concerns that made that function particularly complicated.
More recently, we reduced the responsibility of the "terraform" package
only to instantiating particular named plugins, assuming that its caller
is responsible for selecting appropriate versions of any providers that
_are_ external. However, until this commit we were just assuming that
"terraform init" had correctly selected appropriate plugins and recorded
them in the lock file, and so nothing was dealing with the problem of
ensuring that there haven't been any changes to the lock file or config
since the most recent "terraform init" which would cause us to need to
re-evaluate those decisions.
Part of the game here is to slightly extend the role of the dependency
locks object to also carry information about a subset of provider
addresses whose lock entries we're intentionally disregarding as part of
the various little edge-case features we have for overridding providers:
dev_overrides, "unmanaged providers", and the testing overrides in our
own unit tests. This is an in-memory-only annotation, never included in
the serialized plan files on disk.
I had originally intended to create a new package to encapsulate all of
this plugin-selection logic, including both the version constraint
checking here and also the handling of the provider factory functions, but
as an interim step I've just made version constraint consistency checks
the responsibility of the backend/local package, which means that we'll
always catch problems as part of preparing for local operations, while
not imposing these additional checks on commands that _don't_ run local
operations, such as "terraform apply" when in remote operations mode.
2021-09-29 19:31:43 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/depsfile"
|
2021-05-17 11:45:36 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/getproviders"
|
|
|
|
"github.com/hashicorp/terraform/internal/initwd"
|
|
|
|
legacy "github.com/hashicorp/terraform/internal/legacy/terraform"
|
|
|
|
_ "github.com/hashicorp/terraform/internal/logging"
|
2021-05-17 14:33:17 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/plans"
|
|
|
|
"github.com/hashicorp/terraform/internal/plans/planfile"
|
2021-05-17 12:40:40 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/providers"
|
2021-05-17 11:45:36 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/registry"
|
2021-05-17 14:43:35 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/states"
|
|
|
|
"github.com/hashicorp/terraform/internal/states/statefile"
|
|
|
|
"github.com/hashicorp/terraform/internal/states/statemgr"
|
2021-05-17 11:45:36 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/terminal"
|
2021-05-17 14:46:19 -05:00
|
|
|
"github.com/hashicorp/terraform/internal/terraform"
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
"github.com/hashicorp/terraform/version"
|
2018-10-31 10:45:03 -05:00
|
|
|
"github.com/zclconf/go-cty/cty"
|
2014-06-18 23:36:44 -05:00
|
|
|
)
|
|
|
|
|
2018-11-20 02:58:59 -06:00
|
|
|
// These are the directories for our test data and fixtures.
|
|
|
|
var (
|
2019-06-30 02:38:36 -05:00
|
|
|
fixtureDir = "./testdata"
|
2018-11-20 02:58:59 -06:00
|
|
|
testDataDir = "./testdata"
|
|
|
|
)
|
2014-07-11 23:03:56 -05:00
|
|
|
|
|
|
|
func init() {
|
2014-09-29 13:24:16 -05:00
|
|
|
test = true
|
|
|
|
|
2018-10-31 10:45:03 -05:00
|
|
|
// Initialize the backends
|
|
|
|
backendInit.Init(nil)
|
|
|
|
|
2018-11-20 02:58:59 -06:00
|
|
|
// Expand the data and fixture dirs on init because
|
|
|
|
// we change the working directory in some tests.
|
2014-07-11 23:03:56 -05:00
|
|
|
var err error
|
|
|
|
fixtureDir, err = filepath.Abs(fixtureDir)
|
|
|
|
if err != nil {
|
|
|
|
panic(err)
|
|
|
|
}
|
2018-03-28 12:08:38 -05:00
|
|
|
|
2018-11-20 02:58:59 -06:00
|
|
|
testDataDir, err = filepath.Abs(testDataDir)
|
|
|
|
if err != nil {
|
|
|
|
panic(err)
|
|
|
|
}
|
2014-07-11 23:03:56 -05:00
|
|
|
}
|
2014-06-18 23:36:44 -05:00
|
|
|
|
2016-08-01 16:16:22 -05:00
|
|
|
func TestMain(m *testing.M) {
|
2018-10-16 21:48:28 -05:00
|
|
|
// Make sure backend init is initialized, since our tests tend to assume it.
|
2018-10-31 10:45:03 -05:00
|
|
|
backendInit.Init(nil)
|
2018-10-16 21:48:28 -05:00
|
|
|
|
2016-08-01 16:16:22 -05:00
|
|
|
os.Exit(m.Run())
|
|
|
|
}
|
|
|
|
|
2021-09-01 19:01:44 -05:00
|
|
|
// tempWorkingDir constructs a workdir.Dir object referring to a newly-created
|
2022-04-08 11:34:16 -05:00
|
|
|
// temporary directory. The temporary directory is automatically removed when
|
2022-08-17 13:46:02 -05:00
|
|
|
// the test and all its subtests complete.
|
2021-09-01 19:01:44 -05:00
|
|
|
//
|
|
|
|
// Although workdir.Dir is built to support arbitrary base directories, the
|
|
|
|
// not-yet-migrated behaviors in command.Meta tend to expect the root module
|
|
|
|
// directory to be the real process working directory, and so if you intend
|
|
|
|
// to use the result inside a command.Meta object you must use a pattern
|
|
|
|
// similar to the following when initializing your test:
|
|
|
|
//
|
2022-08-17 13:46:02 -05:00
|
|
|
// wd := tempWorkingDir(t)
|
|
|
|
// defer testChdir(t, wd.RootModuleDir())()
|
2021-09-01 19:01:44 -05:00
|
|
|
//
|
|
|
|
// Note that testChdir modifies global state for the test process, and so a
|
|
|
|
// test using this pattern must never call t.Parallel().
|
2022-04-08 11:34:16 -05:00
|
|
|
func tempWorkingDir(t *testing.T) *workdir.Dir {
|
2021-09-01 19:01:44 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2022-04-08 11:34:16 -05:00
|
|
|
dirPath := t.TempDir()
|
2021-09-01 19:01:44 -05:00
|
|
|
t.Logf("temporary directory %s", dirPath)
|
|
|
|
|
2022-04-08 11:34:16 -05:00
|
|
|
return workdir.NewDir(dirPath)
|
2021-09-01 19:01:44 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// tempWorkingDirFixture is like tempWorkingDir but it also copies the content
|
|
|
|
// from a fixture directory into the temporary directory before returning it.
|
|
|
|
//
|
|
|
|
// The same caveats about working directory apply as for testWorkingDir. See
|
|
|
|
// the testWorkingDir commentary for an example of how to use this function
|
|
|
|
// along with testChdir to meet the expectations of command.Meta legacy
|
|
|
|
// functionality.
|
2021-09-13 12:22:36 -05:00
|
|
|
func tempWorkingDirFixture(t *testing.T, fixtureName string) *workdir.Dir {
|
2021-09-01 19:01:44 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2021-09-13 12:22:36 -05:00
|
|
|
dirPath := testTempDir(t)
|
2021-09-01 19:01:44 -05:00
|
|
|
t.Logf("temporary directory %s with fixture %q", dirPath, fixtureName)
|
|
|
|
|
|
|
|
fixturePath := testFixturePath(fixtureName)
|
|
|
|
testCopyDir(t, fixturePath, dirPath)
|
|
|
|
// NOTE: Unfortunately because testCopyDir immediately aborts the test
|
|
|
|
// on failure, a failure to copy will prevent us from cleaning up the
|
|
|
|
// temporary directory. Oh well. :(
|
|
|
|
|
2021-09-13 12:22:36 -05:00
|
|
|
return workdir.NewDir(dirPath)
|
2021-09-01 19:01:44 -05:00
|
|
|
}
|
|
|
|
|
2014-06-18 23:36:44 -05:00
|
|
|
func testFixturePath(name string) string {
|
2014-07-11 22:38:03 -05:00
|
|
|
return filepath.Join(fixtureDir, name)
|
2014-06-18 23:36:44 -05:00
|
|
|
}
|
|
|
|
|
2018-09-29 11:34:23 -05:00
|
|
|
func metaOverridesForProvider(p providers.Interface) *testingOverrides {
|
2017-04-13 20:05:58 -05:00
|
|
|
return &testingOverrides{
|
2020-03-30 17:30:56 -05:00
|
|
|
Providers: map[addrs.Provider]providers.Factory{
|
2022-02-18 09:19:39 -06:00
|
|
|
addrs.NewDefaultProvider("test"): providers.FactoryFixed(p),
|
|
|
|
addrs.NewProvider(addrs.DefaultProviderRegistryHost, "hashicorp2", "test"): providers.FactoryFixed(p),
|
2020-03-30 17:30:56 -05:00
|
|
|
},
|
2014-06-18 23:36:44 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
func testModuleWithSnapshot(t *testing.T, name string) (*configs.Config, *configload.Snapshot) {
|
|
|
|
t.Helper()
|
2017-08-25 18:23:47 -05:00
|
|
|
|
2018-05-22 21:33:45 -05:00
|
|
|
dir := filepath.Join(fixtureDir, name)
|
|
|
|
// FIXME: We're not dealing with the cleanup function here because
|
|
|
|
// this testModule function is used all over and so we don't want to
|
|
|
|
// change its interface at this late stage.
|
|
|
|
loader, _ := configload.NewLoaderForTests(t)
|
|
|
|
|
|
|
|
// Test modules usually do not refer to remote sources, and for local
|
|
|
|
// sources only this ultimately just records all of the module paths
|
|
|
|
// in a JSON file so that we can load them below.
|
2023-02-17 05:40:47 -06:00
|
|
|
inst := initwd.NewModuleInstaller(loader.ModulesDir(), loader, registry.NewClient(nil, nil))
|
2021-11-01 15:09:16 -05:00
|
|
|
_, instDiags := inst.InstallModules(context.Background(), dir, true, initwd.ModuleInstallHooksImpl{})
|
2019-01-08 20:39:14 -06:00
|
|
|
if instDiags.HasErrors() {
|
|
|
|
t.Fatal(instDiags.Err())
|
2014-09-24 17:48:46 -05:00
|
|
|
}
|
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
config, snap, diags := loader.LoadConfigWithSnapshot(dir)
|
2018-05-22 21:33:45 -05:00
|
|
|
if diags.HasErrors() {
|
|
|
|
t.Fatal(diags.Error())
|
2014-09-24 17:48:46 -05:00
|
|
|
}
|
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
return config, snap
|
2014-09-24 17:48:46 -05:00
|
|
|
}
|
|
|
|
|
2016-10-28 19:51:05 -05:00
|
|
|
// testPlan returns a non-nil noop plan.
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
func testPlan(t *testing.T) *plans.Plan {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
2018-10-11 19:58:46 -05:00
|
|
|
|
|
|
|
// This is what an empty configuration block would look like after being
|
|
|
|
// decoded with the schema of the "local" backend.
|
|
|
|
backendConfig := cty.ObjectVal(map[string]cty.Value{
|
|
|
|
"path": cty.NullVal(cty.String),
|
|
|
|
"workspace_dir": cty.NullVal(cty.String),
|
|
|
|
})
|
|
|
|
backendConfigRaw, err := plans.NewDynamicValue(backendConfig, backendConfig.Type())
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
return &plans.Plan{
|
2018-10-11 19:58:46 -05:00
|
|
|
Backend: plans.Backend{
|
|
|
|
// This is just a placeholder so that the plan file can be written
|
|
|
|
// out. Caller may wish to override it to something more "real"
|
|
|
|
// where the plan will actually be subsequently applied.
|
|
|
|
Type: "local",
|
|
|
|
Config: backendConfigRaw,
|
|
|
|
},
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
Changes: plans.NewChanges(),
|
2016-10-28 19:51:05 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
func testPlanFile(t *testing.T, configSnap *configload.Snapshot, state *states.State, plan *plans.Plan) string {
|
2021-10-13 16:28:14 -05:00
|
|
|
return testPlanFileMatchState(t, configSnap, state, plan, statemgr.SnapshotMeta{})
|
|
|
|
}
|
|
|
|
|
|
|
|
func testPlanFileMatchState(t *testing.T, configSnap *configload.Snapshot, state *states.State, plan *plans.Plan, stateMeta statemgr.SnapshotMeta) string {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
stateFile := &statefile.File{
|
2021-10-13 16:28:14 -05:00
|
|
|
Lineage: stateMeta.Lineage,
|
|
|
|
Serial: stateMeta.Serial,
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
State: state,
|
|
|
|
TerraformVersion: version.SemVer,
|
2014-06-27 16:43:23 -05:00
|
|
|
}
|
2021-05-04 17:59:58 -05:00
|
|
|
prevStateFile := &statefile.File{
|
2021-10-13 16:28:14 -05:00
|
|
|
Lineage: stateMeta.Lineage,
|
|
|
|
Serial: stateMeta.Serial,
|
2021-05-04 17:59:58 -05:00
|
|
|
State: state, // we just assume no changes detected during refresh
|
|
|
|
TerraformVersion: version.SemVer,
|
|
|
|
}
|
2014-06-27 16:43:23 -05:00
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
path := testTempFile(t)
|
2021-09-29 18:03:10 -05:00
|
|
|
err := planfile.Create(path, planfile.CreateArgs{
|
|
|
|
ConfigSnapshot: configSnap,
|
|
|
|
PreviousRunStateFile: prevStateFile,
|
|
|
|
StateFile: stateFile,
|
|
|
|
Plan: plan,
|
backend/local: Check dependency lock consistency before any operations
In historical versions of Terraform the responsibility to check this was
inside the terraform.NewContext function, along with various other
assorted concerns that made that function particularly complicated.
More recently, we reduced the responsibility of the "terraform" package
only to instantiating particular named plugins, assuming that its caller
is responsible for selecting appropriate versions of any providers that
_are_ external. However, until this commit we were just assuming that
"terraform init" had correctly selected appropriate plugins and recorded
them in the lock file, and so nothing was dealing with the problem of
ensuring that there haven't been any changes to the lock file or config
since the most recent "terraform init" which would cause us to need to
re-evaluate those decisions.
Part of the game here is to slightly extend the role of the dependency
locks object to also carry information about a subset of provider
addresses whose lock entries we're intentionally disregarding as part of
the various little edge-case features we have for overridding providers:
dev_overrides, "unmanaged providers", and the testing overrides in our
own unit tests. This is an in-memory-only annotation, never included in
the serialized plan files on disk.
I had originally intended to create a new package to encapsulate all of
this plugin-selection logic, including both the version constraint
checking here and also the handling of the provider factory functions, but
as an interim step I've just made version constraint consistency checks
the responsibility of the backend/local package, which means that we'll
always catch problems as part of preparing for local operations, while
not imposing these additional checks on commands that _don't_ run local
operations, such as "terraform apply" when in remote operations mode.
2021-09-29 19:31:43 -05:00
|
|
|
DependencyLocks: depsfile.NewLocks(),
|
2021-09-29 18:03:10 -05:00
|
|
|
})
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("failed to create temporary plan file: %s", err)
|
2014-06-27 16:43:23 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
return path
|
|
|
|
}
|
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
// testPlanFileNoop is a shortcut function that creates a plan file that
|
|
|
|
// represents no changes and returns its path. This is useful when a test
|
|
|
|
// just needs any plan file, and it doesn't matter what is inside it.
|
|
|
|
func testPlanFileNoop(t *testing.T) string {
|
|
|
|
snap := &configload.Snapshot{
|
|
|
|
Modules: map[string]*configload.SnapshotModule{
|
|
|
|
"": {
|
|
|
|
Dir: ".",
|
|
|
|
Files: map[string][]byte{
|
|
|
|
"main.tf": nil,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
state := states.NewState()
|
|
|
|
plan := testPlan(t)
|
|
|
|
return testPlanFile(t, snap, state, plan)
|
|
|
|
}
|
|
|
|
|
2018-10-14 11:21:31 -05:00
|
|
|
func testReadPlan(t *testing.T, path string) *plans.Plan {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2018-10-14 11:21:31 -05:00
|
|
|
f, err := planfile.Open(path)
|
2014-07-01 11:12:05 -05:00
|
|
|
if err != nil {
|
2018-10-14 11:21:31 -05:00
|
|
|
t.Fatalf("error opening plan file %q: %s", path, err)
|
2014-07-01 11:12:05 -05:00
|
|
|
}
|
|
|
|
defer f.Close()
|
|
|
|
|
2018-10-14 11:21:31 -05:00
|
|
|
p, err := f.ReadPlan()
|
2014-07-01 11:12:05 -05:00
|
|
|
if err != nil {
|
2018-10-14 11:21:31 -05:00
|
|
|
t.Fatalf("error reading plan from plan file %q: %s", path, err)
|
2014-07-01 11:12:05 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
return p
|
|
|
|
}
|
|
|
|
|
2014-09-17 13:15:07 -05:00
|
|
|
// testState returns a test State structure that we use for a lot of tests.
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
func testState() *states.State {
|
|
|
|
return states.BuildState(func(s *states.SyncState) {
|
|
|
|
s.SetResourceInstanceCurrent(
|
|
|
|
addrs.Resource{
|
|
|
|
Mode: addrs.ManagedResourceMode,
|
|
|
|
Type: "test_instance",
|
|
|
|
Name: "foo",
|
|
|
|
}.Instance(addrs.NoKey).Absolute(addrs.RootModuleInstance),
|
|
|
|
&states.ResourceInstanceObjectSrc{
|
2018-10-14 18:07:42 -05:00
|
|
|
// The weird whitespace here is reflective of how this would
|
|
|
|
// get written out in a real state file, due to the indentation
|
|
|
|
// of all of the containing wrapping objects and arrays.
|
2019-10-30 14:59:34 -05:00
|
|
|
AttrsJSON: []byte("{\n \"id\": \"bar\"\n }"),
|
|
|
|
Status: states.ObjectReady,
|
2020-03-23 14:26:18 -05:00
|
|
|
Dependencies: []addrs.ConfigResource{},
|
2014-09-17 13:15:07 -05:00
|
|
|
},
|
2020-02-13 14:32:58 -06:00
|
|
|
addrs.AbsProviderConfig{
|
2020-04-01 14:55:25 -05:00
|
|
|
Provider: addrs.NewDefaultProvider("test"),
|
2020-03-11 13:19:52 -05:00
|
|
|
Module: addrs.RootModule,
|
2020-02-13 14:32:58 -06:00
|
|
|
},
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
)
|
2019-06-04 09:32:12 -05:00
|
|
|
// DeepCopy is used here to ensure our synthetic state matches exactly
|
|
|
|
// with a state that will have been copied during the command
|
|
|
|
// operation, and all fields have been copied correctly.
|
|
|
|
}).DeepCopy()
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// writeStateForTesting is a helper that writes the given naked state to the
|
|
|
|
// given writer, generating a stub *statefile.File wrapper which is then
|
|
|
|
// immediately discarded.
|
|
|
|
func writeStateForTesting(state *states.State, w io.Writer) error {
|
|
|
|
sf := &statefile.File{
|
|
|
|
Serial: 0,
|
|
|
|
Lineage: "fake-for-testing",
|
|
|
|
State: state,
|
|
|
|
}
|
|
|
|
return statefile.Write(sf, w)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testStateMgrCurrentLineage returns the current lineage for the given state
|
|
|
|
// manager, or the empty string if it does not use lineage. This is primarily
|
|
|
|
// for testing against the local backend, which always supports lineage.
|
|
|
|
func testStateMgrCurrentLineage(mgr statemgr.Persistent) string {
|
|
|
|
if pm, ok := mgr.(statemgr.PersistentMeta); ok {
|
|
|
|
m := pm.StateSnapshotMeta()
|
|
|
|
return m.Lineage
|
|
|
|
}
|
|
|
|
return ""
|
|
|
|
}
|
|
|
|
|
|
|
|
// markStateForMatching is a helper that writes a specific marker value to
|
|
|
|
// a state so that it can be recognized later with getStateMatchingMarker.
|
|
|
|
//
|
|
|
|
// Internally this just sets a root module output value called "testing_mark"
|
|
|
|
// to the given string value. If the state is being checked in other ways,
|
|
|
|
// the test code may need to compensate for the addition or overwriting of this
|
|
|
|
// special output value name.
|
|
|
|
//
|
|
|
|
// The given mark string is returned verbatim, to allow the following pattern
|
|
|
|
// in tests:
|
|
|
|
//
|
2022-08-17 13:46:02 -05:00
|
|
|
// mark := markStateForMatching(state, "foo")
|
|
|
|
// // (do stuff to the state)
|
|
|
|
// assertStateHasMarker(state, mark)
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
func markStateForMatching(state *states.State, mark string) string {
|
|
|
|
state.RootModule().SetOutputValue("testing_mark", cty.StringVal(mark), false)
|
|
|
|
return mark
|
|
|
|
}
|
|
|
|
|
|
|
|
// getStateMatchingMarker is used with markStateForMatching to retrieve the
|
|
|
|
// mark string previously added to the given state. If no such mark is present,
|
|
|
|
// the result is an empty string.
|
|
|
|
func getStateMatchingMarker(state *states.State) string {
|
|
|
|
os := state.RootModule().OutputValues["testing_mark"]
|
|
|
|
if os == nil {
|
|
|
|
return ""
|
|
|
|
}
|
|
|
|
v := os.Value
|
|
|
|
if v.Type() == cty.String && v.IsKnown() && !v.IsNull() {
|
|
|
|
return v.AsString()
|
|
|
|
}
|
|
|
|
return ""
|
|
|
|
}
|
|
|
|
|
|
|
|
// stateHasMarker is a helper around getStateMatchingMarker that also includes
|
|
|
|
// the equality test, for more convenient use in test assertion branches.
|
|
|
|
func stateHasMarker(state *states.State, want string) bool {
|
|
|
|
return getStateMatchingMarker(state) == want
|
|
|
|
}
|
|
|
|
|
|
|
|
// assertStateHasMarker wraps stateHasMarker to automatically generate a
|
|
|
|
// fatal test result (i.e. t.Fatal) if the marker doesn't match.
|
|
|
|
func assertStateHasMarker(t *testing.T, state *states.State, want string) {
|
|
|
|
if !stateHasMarker(state, want) {
|
|
|
|
t.Fatalf("wrong state marker\ngot: %q\nwant: %q", getStateMatchingMarker(state), want)
|
2014-09-17 13:15:07 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
func testStateFile(t *testing.T, s *states.State) string {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2014-06-27 16:43:23 -05:00
|
|
|
path := testTempFile(t)
|
|
|
|
|
|
|
|
f, err := os.Create(path)
|
|
|
|
if err != nil {
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
t.Fatalf("failed to create temporary state file %s: %s", path, err)
|
2014-06-27 16:43:23 -05:00
|
|
|
}
|
|
|
|
defer f.Close()
|
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
err = writeStateForTesting(s, f)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("failed to write state to temporary file %s: %s", path, err)
|
2014-06-27 16:43:23 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
return path
|
|
|
|
}
|
|
|
|
|
2015-02-26 12:29:23 -06:00
|
|
|
// testStateFileDefault writes the state out to the default statefile
|
|
|
|
// in the cwd. Use `testCwd` to change into a temp cwd.
|
2020-10-05 07:33:49 -05:00
|
|
|
func testStateFileDefault(t *testing.T, s *states.State) {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2015-02-26 12:29:23 -06:00
|
|
|
f, err := os.Create(DefaultStateFilename)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
defer f.Close()
|
|
|
|
|
2020-10-05 07:33:49 -05:00
|
|
|
if err := writeStateForTesting(s, f); err != nil {
|
2015-02-26 12:29:23 -06:00
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-09-28 12:09:37 -05:00
|
|
|
// testStateFileWorkspaceDefault writes the state out to the default statefile
|
|
|
|
// for the given workspace in the cwd. Use `testCwd` to change into a temp cwd.
|
|
|
|
func testStateFileWorkspaceDefault(t *testing.T, workspace string, s *states.State) string {
|
|
|
|
t.Helper()
|
|
|
|
|
|
|
|
workspaceDir := filepath.Join(backendLocal.DefaultWorkspaceDir, workspace)
|
|
|
|
err := os.MkdirAll(workspaceDir, os.ModePerm)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
path := filepath.Join(workspaceDir, DefaultStateFilename)
|
|
|
|
f, err := os.Create(path)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
defer f.Close()
|
|
|
|
|
|
|
|
if err := writeStateForTesting(s, f); err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
return path
|
|
|
|
}
|
|
|
|
|
2015-03-05 16:55:15 -06:00
|
|
|
// testStateFileRemote writes the state out to the remote statefile
|
|
|
|
// in the cwd. Use `testCwd` to change into a temp cwd.
|
2020-11-18 12:41:33 -06:00
|
|
|
func testStateFileRemote(t *testing.T, s *legacy.State) string {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2015-03-05 16:55:15 -06:00
|
|
|
path := filepath.Join(DefaultDataDir, DefaultStateFilename)
|
|
|
|
if err := os.MkdirAll(filepath.Dir(path), 0755); err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
f, err := os.Create(path)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
defer f.Close()
|
|
|
|
|
2020-11-18 12:41:33 -06:00
|
|
|
if err := legacy.WriteState(s, f); err != nil {
|
2015-03-05 16:55:15 -06:00
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
return path
|
|
|
|
}
|
|
|
|
|
2017-01-18 22:50:45 -06:00
|
|
|
// testStateRead reads the state from a file
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
func testStateRead(t *testing.T, path string) *states.State {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2015-02-26 12:29:23 -06:00
|
|
|
f, err := os.Open(path)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
2017-07-05 16:59:42 -05:00
|
|
|
defer f.Close()
|
2015-02-26 12:29:23 -06:00
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
sf, err := statefile.Read(f)
|
2015-02-26 12:29:23 -06:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
return sf.State
|
|
|
|
}
|
|
|
|
|
|
|
|
// testDataStateRead reads a "data state", which is a file format resembling
|
|
|
|
// our state format v3 that is used only to track current backend settings.
|
|
|
|
//
|
2020-11-18 12:41:33 -06:00
|
|
|
// This old format still uses *legacy.State, but should be replaced with
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
// a more specialized type in a later release.
|
2020-11-18 12:41:33 -06:00
|
|
|
func testDataStateRead(t *testing.T, path string) *legacy.State {
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
t.Helper()
|
|
|
|
|
|
|
|
f, err := os.Open(path)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
defer f.Close()
|
|
|
|
|
2020-11-18 12:41:33 -06:00
|
|
|
s, err := legacy.ReadState(f)
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
return s
|
2017-01-18 22:50:45 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
// testStateOutput tests that the state at the given path contains
|
|
|
|
// the expected state string.
|
|
|
|
func testStateOutput(t *testing.T, path string, expected string) {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2017-01-18 22:50:45 -06:00
|
|
|
newState := testStateRead(t, path)
|
2015-02-26 12:29:23 -06:00
|
|
|
actual := strings.TrimSpace(newState.String())
|
|
|
|
expected = strings.TrimSpace(expected)
|
|
|
|
if actual != expected {
|
2016-03-08 14:37:34 -06:00
|
|
|
t.Fatalf("expected:\n%s\nactual:\n%s", expected, actual)
|
2015-02-26 12:29:23 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-09-29 11:34:23 -05:00
|
|
|
func testProvider() *terraform.MockProvider {
|
|
|
|
p := new(terraform.MockProvider)
|
2020-09-21 13:48:21 -05:00
|
|
|
p.PlanResourceChangeFn = func(req providers.PlanResourceChangeRequest) (resp providers.PlanResourceChangeResponse) {
|
|
|
|
resp.PlannedState = req.ProposedNewState
|
|
|
|
return resp
|
2018-09-29 11:34:23 -05:00
|
|
|
}
|
2020-09-21 13:48:21 -05:00
|
|
|
|
2018-09-29 11:34:23 -05:00
|
|
|
p.ReadResourceFn = func(req providers.ReadResourceRequest) providers.ReadResourceResponse {
|
|
|
|
return providers.ReadResourceResponse{
|
|
|
|
NewState: req.PriorState,
|
|
|
|
}
|
2014-06-18 23:36:44 -05:00
|
|
|
}
|
|
|
|
return p
|
|
|
|
}
|
2014-06-27 16:43:23 -05:00
|
|
|
|
|
|
|
func testTempFile(t *testing.T) string {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2016-05-10 19:03:58 -05:00
|
|
|
return filepath.Join(testTempDir(t), "state.tfstate")
|
2014-06-27 16:43:23 -05:00
|
|
|
}
|
2014-08-05 11:32:01 -05:00
|
|
|
|
|
|
|
func testTempDir(t *testing.T) string {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
2022-04-08 11:34:16 -05:00
|
|
|
d, err := filepath.EvalSymlinks(t.TempDir())
|
2019-12-06 09:56:47 -06:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
2014-08-05 11:32:01 -05:00
|
|
|
return d
|
|
|
|
}
|
2014-10-08 14:08:35 -05:00
|
|
|
|
2016-08-24 00:11:21 -05:00
|
|
|
// testChdir changes the directory and returns a function to defer to
|
|
|
|
// revert the old cwd.
|
|
|
|
func testChdir(t *testing.T, new string) func() {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2016-08-24 00:11:21 -05:00
|
|
|
old, err := os.Getwd()
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := os.Chdir(new); err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
return func() {
|
|
|
|
// Re-run the function ignoring the defer result
|
|
|
|
testChdir(t, old)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-04-08 11:34:16 -05:00
|
|
|
// testCwd is used to change the current working directory into a temporary
|
|
|
|
// directory. The cleanup is performed automatically after the test and all its
|
|
|
|
// subtests complete.
|
|
|
|
func testCwd(t *testing.T) string {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2022-04-08 11:34:16 -05:00
|
|
|
tmp := t.TempDir()
|
2015-02-22 12:49:31 -06:00
|
|
|
|
2014-10-08 14:08:35 -05:00
|
|
|
cwd, err := os.Getwd()
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
2015-02-22 12:49:31 -06:00
|
|
|
|
2014-10-09 16:45:08 -05:00
|
|
|
if err := os.Chdir(tmp); err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
2015-02-22 12:49:31 -06:00
|
|
|
|
2022-04-08 11:34:16 -05:00
|
|
|
t.Cleanup(func() {
|
|
|
|
if err := os.Chdir(cwd); err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
})
|
2015-02-22 12:49:31 -06:00
|
|
|
|
2022-04-08 11:34:16 -05:00
|
|
|
return tmp
|
2014-10-08 14:08:35 -05:00
|
|
|
}
|
2016-11-30 13:36:54 -06:00
|
|
|
|
|
|
|
// testStdinPipe changes os.Stdin to be a pipe that sends the data from
|
|
|
|
// the reader before closing the pipe.
|
|
|
|
//
|
|
|
|
// The returned function should be deferred to properly clean up and restore
|
|
|
|
// the original stdin.
|
|
|
|
func testStdinPipe(t *testing.T, src io.Reader) func() {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2016-11-30 13:36:54 -06:00
|
|
|
r, w, err := os.Pipe()
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Modify stdin to point to our new pipe
|
|
|
|
old := os.Stdin
|
|
|
|
os.Stdin = r
|
|
|
|
|
|
|
|
// Copy the data from the reader to the pipe
|
|
|
|
go func() {
|
|
|
|
defer w.Close()
|
|
|
|
io.Copy(w, src)
|
|
|
|
}()
|
|
|
|
|
|
|
|
return func() {
|
|
|
|
// Close our read end
|
|
|
|
r.Close()
|
|
|
|
|
|
|
|
// Reset stdin
|
|
|
|
os.Stdin = old
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Modify os.Stdout to write to the given buffer. Note that this is generally
|
|
|
|
// not useful since the commands are configured to write to a cli.Ui, not
|
|
|
|
// Stdout directly. Commands like `console` though use the raw stdout.
|
|
|
|
func testStdoutCapture(t *testing.T, dst io.Writer) func() {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2016-11-30 13:36:54 -06:00
|
|
|
r, w, err := os.Pipe()
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Modify stdout
|
|
|
|
old := os.Stdout
|
|
|
|
os.Stdout = w
|
|
|
|
|
|
|
|
// Copy
|
|
|
|
doneCh := make(chan struct{})
|
|
|
|
go func() {
|
|
|
|
defer close(doneCh)
|
|
|
|
defer r.Close()
|
|
|
|
io.Copy(dst, r)
|
|
|
|
}()
|
|
|
|
|
|
|
|
return func() {
|
|
|
|
// Close the writer end of the pipe
|
|
|
|
w.Sync()
|
|
|
|
w.Close()
|
|
|
|
|
|
|
|
// Reset stdout
|
|
|
|
os.Stdout = old
|
|
|
|
|
|
|
|
// Wait for the data copy to complete to avoid a race reading data
|
|
|
|
<-doneCh
|
|
|
|
}
|
|
|
|
}
|
2017-01-18 22:50:45 -06:00
|
|
|
|
|
|
|
// testInteractiveInput configures tests so that the answers given are sent
|
|
|
|
// in order to interactive prompts. The returned function must be called
|
|
|
|
// in a defer to clean up.
|
|
|
|
func testInteractiveInput(t *testing.T, answers []string) func() {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2017-01-18 22:50:45 -06:00
|
|
|
// Disable test mode so input is called
|
|
|
|
test = false
|
|
|
|
|
2021-01-26 13:39:11 -06:00
|
|
|
// Set up reader/writers
|
2017-01-18 22:50:45 -06:00
|
|
|
testInputResponse = answers
|
|
|
|
defaultInputReader = bytes.NewBufferString("")
|
|
|
|
defaultInputWriter = new(bytes.Buffer)
|
|
|
|
|
|
|
|
// Return the cleanup
|
|
|
|
return func() {
|
|
|
|
test = true
|
|
|
|
testInputResponse = nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-03-01 12:59:17 -06:00
|
|
|
// testInputMap configures tests so that the given answers are returned
|
|
|
|
// for calls to Input when the right question is asked. The key is the
|
|
|
|
// question "Id" that is used.
|
|
|
|
func testInputMap(t *testing.T, answers map[string]string) func() {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2017-03-01 12:59:17 -06:00
|
|
|
// Disable test mode so input is called
|
|
|
|
test = false
|
|
|
|
|
2021-01-26 13:39:11 -06:00
|
|
|
// Set up reader/writers
|
2017-03-01 12:59:17 -06:00
|
|
|
defaultInputReader = bytes.NewBufferString("")
|
|
|
|
defaultInputWriter = new(bytes.Buffer)
|
|
|
|
|
|
|
|
// Setup answers
|
|
|
|
testInputResponse = nil
|
|
|
|
testInputResponseMap = answers
|
|
|
|
|
|
|
|
// Return the cleanup
|
|
|
|
return func() {
|
2021-09-22 15:55:56 -05:00
|
|
|
var unusedAnswers = testInputResponseMap
|
2021-09-21 22:00:32 -05:00
|
|
|
|
2021-09-22 15:55:56 -05:00
|
|
|
// First, clean up!
|
2017-03-01 12:59:17 -06:00
|
|
|
test = true
|
|
|
|
testInputResponseMap = nil
|
2021-09-22 15:55:56 -05:00
|
|
|
|
|
|
|
if len(unusedAnswers) > 0 {
|
|
|
|
t.Fatalf("expected no unused answers provided to command.testInputMap, got: %v", unusedAnswers)
|
|
|
|
}
|
2017-03-01 12:59:17 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-01-18 22:50:45 -06:00
|
|
|
// testBackendState is used to make a test HTTP server to test a configured
|
|
|
|
// backend. This returns the complete state that can be saved. Use
|
|
|
|
// `testStateFileRemote` to write the returned state.
|
2018-11-07 19:20:46 -06:00
|
|
|
//
|
|
|
|
// When using this function, the configuration fixture for the test must
|
|
|
|
// include an empty configuration block for the HTTP backend, like this:
|
|
|
|
//
|
2022-08-17 13:46:02 -05:00
|
|
|
// terraform {
|
|
|
|
// backend "http" {
|
|
|
|
// }
|
|
|
|
// }
|
2018-11-07 19:20:46 -06:00
|
|
|
//
|
|
|
|
// If such a block isn't present, or if it isn't empty, then an error will
|
|
|
|
// be returned about the backend configuration having changed and that
|
|
|
|
// "terraform init" must be run, since the test backend config cache created
|
|
|
|
// by this function contains the hash for an empty configuration.
|
2020-11-18 12:41:33 -06:00
|
|
|
func testBackendState(t *testing.T, s *states.State, c int) (*legacy.State, *httptest.Server) {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2017-01-18 22:50:45 -06:00
|
|
|
var b64md5 string
|
|
|
|
buf := bytes.NewBuffer(nil)
|
|
|
|
|
|
|
|
cb := func(resp http.ResponseWriter, req *http.Request) {
|
|
|
|
if req.Method == "PUT" {
|
|
|
|
resp.WriteHeader(c)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
if s == nil {
|
|
|
|
resp.WriteHeader(404)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
resp.Header().Set("Content-MD5", b64md5)
|
|
|
|
resp.Write(buf.Bytes())
|
|
|
|
}
|
|
|
|
|
|
|
|
// If a state was given, make sure we calculate the proper b64md5
|
|
|
|
if s != nil {
|
2020-04-02 11:58:44 -05:00
|
|
|
err := statefile.Write(&statefile.File{State: s}, buf)
|
|
|
|
if err != nil {
|
2017-01-18 22:50:45 -06:00
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
md5 := md5.Sum(buf.Bytes())
|
|
|
|
b64md5 = base64.StdEncoding.EncodeToString(md5[:16])
|
|
|
|
}
|
|
|
|
|
|
|
|
srv := httptest.NewServer(http.HandlerFunc(cb))
|
|
|
|
|
2018-11-07 19:20:46 -06:00
|
|
|
backendConfig := &configs.Backend{
|
|
|
|
Type: "http",
|
|
|
|
Config: configs.SynthBody("<testBackendState>", map[string]cty.Value{}),
|
|
|
|
}
|
2018-11-08 16:38:56 -06:00
|
|
|
b := backendInit.Backend("http")()
|
2018-11-07 19:20:46 -06:00
|
|
|
configSchema := b.ConfigSchema()
|
|
|
|
hash := backendConfig.Hash(configSchema)
|
|
|
|
|
2020-11-18 12:41:33 -06:00
|
|
|
state := legacy.NewState()
|
|
|
|
state.Backend = &legacy.BackendState{
|
2018-03-27 17:31:05 -05:00
|
|
|
Type: "http",
|
|
|
|
ConfigRaw: json.RawMessage(fmt.Sprintf(`{"address":%q}`, srv.URL)),
|
2018-12-18 18:06:49 -06:00
|
|
|
Hash: uint64(hash),
|
2017-01-18 22:50:45 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
return state, srv
|
|
|
|
}
|
|
|
|
|
|
|
|
// testRemoteState is used to make a test HTTP server to return a given
|
|
|
|
// state file that can be used for testing legacy remote state.
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
//
|
2020-11-18 12:41:33 -06:00
|
|
|
// The return values are a *legacy.State instance that should be written
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
// as the "data state" (really: backend state) and the server that the
|
|
|
|
// returned data state refers to.
|
2020-11-18 12:41:33 -06:00
|
|
|
func testRemoteState(t *testing.T, s *states.State, c int) (*legacy.State, *httptest.Server) {
|
2017-08-25 18:23:47 -05:00
|
|
|
t.Helper()
|
|
|
|
|
2017-01-18 22:50:45 -06:00
|
|
|
var b64md5 string
|
|
|
|
buf := bytes.NewBuffer(nil)
|
|
|
|
|
|
|
|
cb := func(resp http.ResponseWriter, req *http.Request) {
|
|
|
|
if req.Method == "PUT" {
|
|
|
|
resp.WriteHeader(c)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
if s == nil {
|
|
|
|
resp.WriteHeader(404)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
resp.Header().Set("Content-MD5", b64md5)
|
|
|
|
resp.Write(buf.Bytes())
|
|
|
|
}
|
|
|
|
|
2020-11-18 12:41:33 -06:00
|
|
|
retState := legacy.NewState()
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
|
2017-01-18 22:50:45 -06:00
|
|
|
srv := httptest.NewServer(http.HandlerFunc(cb))
|
2020-11-18 12:41:33 -06:00
|
|
|
b := &legacy.BackendState{
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
Type: "http",
|
|
|
|
}
|
|
|
|
b.SetConfig(cty.ObjectVal(map[string]cty.Value{
|
|
|
|
"address": cty.StringVal(srv.URL),
|
|
|
|
}), &configschema.Block{
|
|
|
|
Attributes: map[string]*configschema.Attribute{
|
|
|
|
"address": {
|
|
|
|
Type: cty.String,
|
|
|
|
Required: true,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
})
|
|
|
|
retState.Backend = b
|
2017-01-18 22:50:45 -06:00
|
|
|
|
|
|
|
if s != nil {
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
err := statefile.Write(&statefile.File{State: s}, buf)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("failed to write initial state: %v", err)
|
2017-01-18 22:50:45 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
return retState, srv
|
2017-01-18 22:50:45 -06:00
|
|
|
}
|
2017-02-03 14:32:40 -06:00
|
|
|
|
|
|
|
// testlockState calls a separate process to the lock the state file at path.
|
|
|
|
// deferFunc should be called in the caller to properly unlock the file.
|
2018-11-20 02:58:59 -06:00
|
|
|
// Since many tests change the working directory, the sourcedir argument must be
|
2017-02-06 12:26:03 -06:00
|
|
|
// supplied to locate the statelocker.go source.
|
2022-04-08 11:34:16 -05:00
|
|
|
func testLockState(t *testing.T, sourceDir, path string) (func(), error) {
|
2017-02-03 14:56:19 -06:00
|
|
|
// build and run the binary ourselves so we can quickly terminate it for cleanup
|
2022-04-08 11:34:16 -05:00
|
|
|
buildDir := t.TempDir()
|
2017-02-03 14:56:19 -06:00
|
|
|
|
2017-02-06 12:26:03 -06:00
|
|
|
source := filepath.Join(sourceDir, "statelocker.go")
|
2017-02-03 14:56:19 -06:00
|
|
|
lockBin := filepath.Join(buildDir, "statelocker")
|
2017-02-06 12:26:03 -06:00
|
|
|
|
2020-09-23 16:56:19 -05:00
|
|
|
cmd := exec.Command("go", "build", "-o", lockBin, source)
|
2018-11-20 02:58:59 -06:00
|
|
|
cmd.Dir = filepath.Dir(sourceDir)
|
|
|
|
|
|
|
|
out, err := cmd.CombinedOutput()
|
2017-02-03 14:56:19 -06:00
|
|
|
if err != nil {
|
|
|
|
return nil, fmt.Errorf("%s %s", err, out)
|
|
|
|
}
|
|
|
|
|
|
|
|
locker := exec.Command(lockBin, path)
|
2017-02-03 14:32:40 -06:00
|
|
|
pr, pw, err := os.Pipe()
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
defer pr.Close()
|
|
|
|
defer pw.Close()
|
|
|
|
locker.Stderr = pw
|
|
|
|
locker.Stdout = pw
|
|
|
|
|
|
|
|
if err := locker.Start(); err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
deferFunc := func() {
|
|
|
|
locker.Process.Signal(syscall.SIGTERM)
|
|
|
|
locker.Wait()
|
|
|
|
}
|
|
|
|
|
|
|
|
// wait for the process to lock
|
|
|
|
buf := make([]byte, 1024)
|
|
|
|
n, err := pr.Read(buf)
|
|
|
|
if err != nil {
|
|
|
|
return deferFunc, fmt.Errorf("read from statelocker returned: %s", err)
|
|
|
|
}
|
|
|
|
|
2017-02-15 10:53:19 -06:00
|
|
|
output := string(buf[:n])
|
|
|
|
if !strings.HasPrefix(output, "LOCKID") {
|
2017-02-03 14:56:19 -06:00
|
|
|
return deferFunc, fmt.Errorf("statelocker wrote: %s", string(buf[:n]))
|
2017-02-03 14:32:40 -06:00
|
|
|
}
|
|
|
|
return deferFunc, nil
|
|
|
|
}
|
2018-10-14 18:35:59 -05:00
|
|
|
|
2020-10-07 11:48:25 -05:00
|
|
|
// testCopyDir recursively copies a directory tree, attempting to preserve
|
2021-09-01 19:01:44 -05:00
|
|
|
// permissions. Source directory must exist, destination directory may exist
|
|
|
|
// but will be created if not; it should typically be a temporary directory,
|
|
|
|
// and thus already created using os.MkdirTemp or similar.
|
|
|
|
// Symlinks are ignored and skipped.
|
2020-10-07 11:48:25 -05:00
|
|
|
func testCopyDir(t *testing.T, src, dst string) {
|
|
|
|
t.Helper()
|
|
|
|
|
|
|
|
src = filepath.Clean(src)
|
|
|
|
dst = filepath.Clean(dst)
|
|
|
|
|
|
|
|
si, err := os.Stat(src)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
if !si.IsDir() {
|
|
|
|
t.Fatal("source is not a directory")
|
|
|
|
}
|
|
|
|
|
|
|
|
_, err = os.Stat(dst)
|
|
|
|
if err != nil && !os.IsNotExist(err) {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
err = os.MkdirAll(dst, si.Mode())
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
entries, err := ioutil.ReadDir(src)
|
|
|
|
if err != nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, entry := range entries {
|
|
|
|
srcPath := filepath.Join(src, entry.Name())
|
|
|
|
dstPath := filepath.Join(dst, entry.Name())
|
|
|
|
|
|
|
|
// If the entry is a symlink, we copy the contents
|
|
|
|
for entry.Mode()&os.ModeSymlink != 0 {
|
|
|
|
target, err := os.Readlink(srcPath)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
entry, err = os.Stat(target)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if entry.IsDir() {
|
|
|
|
testCopyDir(t, srcPath, dstPath)
|
|
|
|
} else {
|
|
|
|
err = copy.CopyFile(srcPath, dstPath)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-10-14 18:35:59 -05:00
|
|
|
// normalizeJSON removes all insignificant whitespace from the given JSON buffer
|
|
|
|
// and returns it as a string for easier comparison.
|
|
|
|
func normalizeJSON(t *testing.T, src []byte) string {
|
|
|
|
t.Helper()
|
|
|
|
var buf bytes.Buffer
|
|
|
|
err := json.Compact(&buf, src)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("error normalizing JSON: %s", err)
|
|
|
|
}
|
|
|
|
return buf.String()
|
|
|
|
}
|
2020-01-04 07:29:25 -06:00
|
|
|
|
2020-03-23 14:26:18 -05:00
|
|
|
func mustResourceAddr(s string) addrs.ConfigResource {
|
2020-01-04 07:29:25 -06:00
|
|
|
addr, diags := addrs.ParseAbsResourceStr(s)
|
|
|
|
if diags.HasErrors() {
|
|
|
|
panic(diags.Err())
|
|
|
|
}
|
2020-03-23 14:26:18 -05:00
|
|
|
return addr.Config()
|
2020-01-04 07:29:25 -06:00
|
|
|
}
|
2020-05-25 14:24:35 -05:00
|
|
|
|
|
|
|
// This map from provider type name to namespace is used by the fake registry
|
|
|
|
// when called via LookupLegacyProvider. Providers not in this map will return
|
|
|
|
// a 404 Not Found error.
|
|
|
|
var legacyProviderNamespaces = map[string]string{
|
|
|
|
"foo": "hashicorp",
|
|
|
|
"bar": "hashicorp",
|
|
|
|
"baz": "terraform-providers",
|
2020-08-21 11:29:10 -05:00
|
|
|
"qux": "hashicorp",
|
|
|
|
}
|
|
|
|
|
|
|
|
// This map is used to mock the provider redirect feature.
|
|
|
|
var movedProviderNamespaces = map[string]string{
|
|
|
|
"qux": "acme",
|
2020-05-25 14:24:35 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// testServices starts up a local HTTP server running a fake provider registry
|
|
|
|
// service which responds only to discovery requests and legacy provider lookup
|
|
|
|
// API calls.
|
|
|
|
//
|
|
|
|
// The final return value is a function to call at the end of a test function
|
|
|
|
// to shut down the test server. After you call that function, the discovery
|
|
|
|
// object becomes useless.
|
|
|
|
func testServices(t *testing.T) (services *disco.Disco, cleanup func()) {
|
|
|
|
server := httptest.NewServer(http.HandlerFunc(fakeRegistryHandler))
|
|
|
|
|
|
|
|
services = disco.New()
|
|
|
|
services.ForceHostServices(svchost.Hostname("registry.terraform.io"), map[string]interface{}{
|
|
|
|
"providers.v1": server.URL + "/providers/v1/",
|
|
|
|
})
|
|
|
|
|
|
|
|
return services, func() {
|
|
|
|
server.Close()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// testRegistrySource is a wrapper around testServices that uses the created
|
|
|
|
// discovery object to produce a Source instance that is ready to use with the
|
|
|
|
// fake registry services.
|
|
|
|
//
|
|
|
|
// As with testServices, the final return value is a function to call at the end
|
|
|
|
// of your test in order to shut down the test server.
|
|
|
|
func testRegistrySource(t *testing.T) (source *getproviders.RegistrySource, cleanup func()) {
|
|
|
|
services, close := testServices(t)
|
|
|
|
source = getproviders.NewRegistrySource(services)
|
|
|
|
return source, close
|
|
|
|
}
|
|
|
|
|
|
|
|
func fakeRegistryHandler(resp http.ResponseWriter, req *http.Request) {
|
|
|
|
path := req.URL.EscapedPath()
|
|
|
|
|
|
|
|
if !strings.HasPrefix(path, "/providers/v1/") {
|
|
|
|
resp.WriteHeader(404)
|
|
|
|
resp.Write([]byte(`not a provider registry endpoint`))
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
pathParts := strings.Split(path, "/")[3:]
|
|
|
|
|
|
|
|
if len(pathParts) != 3 {
|
|
|
|
resp.WriteHeader(404)
|
|
|
|
resp.Write([]byte(`unrecognized path scheme`))
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2020-08-21 11:29:10 -05:00
|
|
|
if pathParts[2] != "versions" {
|
2020-05-25 14:24:35 -05:00
|
|
|
resp.WriteHeader(404)
|
|
|
|
resp.Write([]byte(`this registry only supports legacy namespace lookup requests`))
|
2020-08-21 11:29:10 -05:00
|
|
|
return
|
2020-05-25 14:24:35 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
name := pathParts[1]
|
2020-08-21 11:29:10 -05:00
|
|
|
|
|
|
|
// Legacy lookup
|
|
|
|
if pathParts[0] == "-" {
|
|
|
|
if namespace, ok := legacyProviderNamespaces[name]; ok {
|
|
|
|
resp.Header().Set("Content-Type", "application/json")
|
|
|
|
resp.WriteHeader(200)
|
|
|
|
if movedNamespace, ok := movedProviderNamespaces[name]; ok {
|
|
|
|
resp.Write([]byte(fmt.Sprintf(`{"id":"%s/%s","moved_to":"%s/%s","versions":[{"version":"1.0.0","protocols":["4"]}]}`, namespace, name, movedNamespace, name)))
|
|
|
|
} else {
|
|
|
|
resp.Write([]byte(fmt.Sprintf(`{"id":"%s/%s","versions":[{"version":"1.0.0","protocols":["4"]}]}`, namespace, name)))
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
resp.WriteHeader(404)
|
|
|
|
resp.Write([]byte(`provider not found`))
|
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// Also return versions for redirect target
|
|
|
|
if namespace, ok := movedProviderNamespaces[name]; ok && pathParts[0] == namespace {
|
2020-05-25 14:24:35 -05:00
|
|
|
resp.Header().Set("Content-Type", "application/json")
|
|
|
|
resp.WriteHeader(200)
|
2020-08-21 11:29:10 -05:00
|
|
|
resp.Write([]byte(fmt.Sprintf(`{"id":"%s/%s","versions":[{"version":"1.0.0","protocols":["4"]}]}`, namespace, name)))
|
2020-05-25 14:24:35 -05:00
|
|
|
} else {
|
|
|
|
resp.WriteHeader(404)
|
|
|
|
resp.Write([]byte(`provider not found`))
|
|
|
|
}
|
|
|
|
}
|
cli: Add initial command views abstraction
Terraform supports multiple output formats for several sub-commands.
The default format is user-readable text, but many sub-commands support
a `-json` flag to output a machine-readable format for the result. The
output command also supports a `-raw` flag for a simpler, scripting-
focused machine readable format.
This commit adds a "views" abstraction, intended to help ensure
consistency between the various output formats. This extracts the render
specific code from the command package, and moves it into a views
package. Each command is expected to create an interface for its view,
and one or more implementations of that interface.
By doing so, we separate the concerns of generating the sub-command
result from rendering the result in the specified output format. This
should make it easier to ensure that all output formats will be updated
together when changes occur in the result-generating phase.
There are some other consequences of this restructuring:
- Views now directly access the terminal streams, rather than the
now-redundant cli.Ui instance;
- With the reorganization of commands, parsing CLI arguments is now the
responsibility of a separate "arguments" package.
For now, views are added only for the output sub-command, as an example.
Because this command uses code which is shared with the apply and
refresh commands, those are also partially updated.
2021-01-27 14:51:40 -06:00
|
|
|
|
|
|
|
func testView(t *testing.T) (*views.View, func(*testing.T) *terminal.TestOutput) {
|
|
|
|
streams, done := terminal.StreamsForTesting(t)
|
|
|
|
return views.NewView(streams), done
|
|
|
|
}
|
2022-07-12 16:00:36 -05:00
|
|
|
|
|
|
|
// checkGoldenReference compares the given test output with a known "golden" output log
|
|
|
|
// located under the specified fixture path.
|
|
|
|
//
|
|
|
|
// If any of these tests fail, please communicate with Terraform Cloud folks before resolving,
|
|
|
|
// as changes to UI output may also affect the behavior of Terraform Cloud's structured run output.
|
|
|
|
func checkGoldenReference(t *testing.T, output *terminal.TestOutput, fixturePathName string) {
|
|
|
|
t.Helper()
|
|
|
|
|
|
|
|
// Load the golden reference fixture
|
|
|
|
wantFile, err := os.Open(path.Join(testFixturePath(fixturePathName), "output.jsonlog"))
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("failed to open output file: %s", err)
|
|
|
|
}
|
|
|
|
defer wantFile.Close()
|
|
|
|
wantBytes, err := ioutil.ReadAll(wantFile)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("failed to read output file: %s", err)
|
|
|
|
}
|
|
|
|
want := string(wantBytes)
|
|
|
|
|
|
|
|
got := output.Stdout()
|
|
|
|
|
|
|
|
// Split the output and the reference into lines so that we can compare
|
|
|
|
// messages
|
|
|
|
got = strings.TrimSuffix(got, "\n")
|
|
|
|
gotLines := strings.Split(got, "\n")
|
|
|
|
|
|
|
|
want = strings.TrimSuffix(want, "\n")
|
|
|
|
wantLines := strings.Split(want, "\n")
|
|
|
|
|
|
|
|
if len(gotLines) != len(wantLines) {
|
|
|
|
t.Errorf("unexpected number of log lines: got %d, want %d\n"+
|
|
|
|
"NOTE: This failure may indicate a UI change affecting the behavior of structured run output on TFC.\n"+
|
|
|
|
"Please communicate with Terraform Cloud team before resolving", len(gotLines), len(wantLines))
|
|
|
|
}
|
|
|
|
|
|
|
|
// Verify that the log starts with a version message
|
|
|
|
type versionMessage struct {
|
|
|
|
Level string `json:"@level"`
|
|
|
|
Message string `json:"@message"`
|
|
|
|
Type string `json:"type"`
|
|
|
|
Terraform string `json:"terraform"`
|
|
|
|
UI string `json:"ui"`
|
|
|
|
}
|
|
|
|
var gotVersion versionMessage
|
|
|
|
if err := json.Unmarshal([]byte(gotLines[0]), &gotVersion); err != nil {
|
|
|
|
t.Errorf("failed to unmarshal version line: %s\n%s", err, gotLines[0])
|
|
|
|
}
|
|
|
|
wantVersion := versionMessage{
|
|
|
|
"info",
|
|
|
|
fmt.Sprintf("Terraform %s", version.String()),
|
|
|
|
"version",
|
|
|
|
version.String(),
|
|
|
|
views.JSON_UI_VERSION,
|
|
|
|
}
|
|
|
|
if !cmp.Equal(wantVersion, gotVersion) {
|
|
|
|
t.Errorf("unexpected first message:\n%s", cmp.Diff(wantVersion, gotVersion))
|
|
|
|
}
|
|
|
|
|
|
|
|
// Compare the rest of the lines against the golden reference
|
|
|
|
var gotLineMaps []map[string]interface{}
|
|
|
|
for i, line := range gotLines[1:] {
|
|
|
|
index := i + 1
|
|
|
|
var gotMap map[string]interface{}
|
|
|
|
if err := json.Unmarshal([]byte(line), &gotMap); err != nil {
|
|
|
|
t.Errorf("failed to unmarshal got line %d: %s\n%s", index, err, gotLines[index])
|
|
|
|
}
|
|
|
|
if _, ok := gotMap["@timestamp"]; !ok {
|
|
|
|
t.Errorf("missing @timestamp field in log: %s", gotLines[index])
|
|
|
|
}
|
|
|
|
delete(gotMap, "@timestamp")
|
|
|
|
gotLineMaps = append(gotLineMaps, gotMap)
|
|
|
|
}
|
|
|
|
var wantLineMaps []map[string]interface{}
|
|
|
|
for i, line := range wantLines[1:] {
|
|
|
|
index := i + 1
|
|
|
|
var wantMap map[string]interface{}
|
|
|
|
if err := json.Unmarshal([]byte(line), &wantMap); err != nil {
|
|
|
|
t.Errorf("failed to unmarshal want line %d: %s\n%s", index, err, gotLines[index])
|
|
|
|
}
|
|
|
|
wantLineMaps = append(wantLineMaps, wantMap)
|
|
|
|
}
|
|
|
|
if diff := cmp.Diff(wantLineMaps, gotLineMaps); diff != "" {
|
|
|
|
t.Errorf("wrong output lines\n%s\n"+
|
|
|
|
"NOTE: This failure may indicate a UI change affecting the behavior of structured run output on TFC.\n"+
|
|
|
|
"Please communicate with Terraform Cloud team before resolving", diff)
|
|
|
|
}
|
|
|
|
}
|