IntenseWebs/opentofu
3
0
Fork 0
mirror of https://github.com/opentofu/opentofu.git synced 2024-12-25 08:21:07 -06:00
Code Issues Packages Projects Releases Wiki Activity
dcfa077adf
opentofu/internal/terraform/graph_builder_plan_test.go

313 lines
9.5 KiB
Go
Raw Normal View History

terraform: tests for the plan graph builder
2016-11-05 19:58:38 -05:00
package terraform
import (
"strings"
"testing"
core: Get tests compiling again After the refactoring to integrate HCL2 many of the tests were no longer using correct types, attribute names, etc. This is a bulk update of all of the tests to make them compile again, with minimal changes otherwise. Although the tests now compile, many of them do not yet pass. The tests will be gradually repaired in subsequent commits, as we continue to complete the refactoring and retrofit work.
2018-05-04 21:24:06 -05:00
Move addrs/ to internal/addrs/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.
2021-05-17 14:00:50 -05:00
"github.com/hashicorp/terraform/internal/addrs"
Move configs/ to internal/configs/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.
2021-05-17 14:17:09 -05:00
"github.com/hashicorp/terraform/internal/configs/configschema"
Move providers/ to internal/providers/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.
2021-05-17 12:40:40 -05:00
"github.com/hashicorp/terraform/internal/providers"
lang: Consider "dynamic" blocks when resolving references The hcldec package has no awareness of the dynamic block extension, so the hcldec.Variables function misses any variables declared inside dynamic blocks. dynblock.VariablesHCLDec is a drop-in replacement for hcldec.Variables that _is_ aware of dynamic blocks, returning all of the same variables that hcldec would find naturally plus also any variables used inside the dynamic block "for_each" and "labels" arguments and inside the nested "content" block.
2019-03-18 19:15:23 -05:00
"github.com/zclconf/go-cty/cty"
terraform: tests for the plan graph builder
2016-11-05 19:58:38 -05:00
)
func TestPlanGraphBuilder_impl(t *testing.T) {
var _ GraphBuilder = new(PlanGraphBuilder)
}
func TestPlanGraphBuilder(t *testing.T) {
replace provider and provisioner types in tests The field assignments and methods are incorrect still, but the type definitions and returns are now updated.
2018-08-17 14:32:35 -05:00
awsProvider := &MockProvider{
Mildwonkey/providers interface renaming (#27805) * providers.Interface: huge renamification This commit renames a handful of functions in the providers.Interface to match changes made in protocol v6. The following commit implements this change across the rest of the codebase; I put this in a separate commit for ease of reviewing and will squash these together when merging. One noteworthy detail: protocol v6 removes the config from the ValidateProviderConfigResponse, since it's never been used. I chose to leave that in place in the interface until we deprecate support for protocol v5 entirely. Note that none of these changes impact current providers using protocol v5; the protocol is unchanged. Only the translation layer between the proto and terraform have changed.
2021-02-18 09:13:43 -06:00
GetProviderSchemaResponse: &providers.GetProviderSchemaResponse{
change mock provider to use GetSchemaResponse This ensures that test providers are using the same types as actual providers.
2021-01-11 14:45:50 -06:00
Provider: providers.Schema{Block: simpleTestSchema()},
ResourceTypes: map[string]providers.Schema{
"aws_security_group": {Block: simpleTestSchema()},
"aws_instance": {Block: simpleTestSchema()},
"aws_load_balancer": {Block: simpleTestSchema()},
core: Fetch schemas during context construction Previously we fetched schemas during the AttachSchemaTransformer, potentially multiple times as that was re-run for each graph built. Now we fetch the schemas just once during context construction, passing that result into each of the graph builders. This only addresses the schema accesses during graph construction. We're still separately loading schemas during the main walk for evaluation purposes. This will be addressed in a later commit.
2018-05-31 14:39:45 -05:00
},
},
}
change mock provider to use GetSchemaResponse This ensures that test providers are using the same types as actual providers.
2021-01-11 14:45:50 -06:00
openstackProvider := mockProviderWithResourceTypeSchema("openstack_floating_ip", simpleTestSchema())
core: Fetch schemas during context construction Previously we fetched schemas during the AttachSchemaTransformer, potentially multiple times as that was re-run for each graph built. Now we fetch the schemas just once during context construction, passing that result into each of the graph builders. This only addresses the schema accesses during graph construction. We're still separately loading schemas during the main walk for evaluation purposes. This will be addressed in a later commit.
2018-05-31 14:39:45 -05:00
components := &basicComponentFactory{
providers: use addrs.Provider as map keys for provider.Factory (#23548) * terraform/context: use new addrs.Provider as map key in provider factories * added NewLegacyProviderType and LegacyString funcs to make it explicit that these are temporary placeholders This PR introduces a new concept, provider fully-qualified name (FQN), encapsulated by the `addrs.Provider` struct.
2019-12-04 10:30:20 -06:00
providers: map[addrs.Provider]providers.Factory{
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
addrs.NewDefaultProvider("aws"): providers.FactoryFixed(awsProvider),
addrs.NewDefaultProvider("openstack"): providers.FactoryFixed(openstackProvider),
core: Fetch schemas during context construction Previously we fetched schemas during the AttachSchemaTransformer, potentially multiple times as that was re-run for each graph built. Now we fetch the schemas just once during context construction, passing that result into each of the graph builders. This only addresses the schema accesses during graph construction. We're still separately loading schemas during the main walk for evaluation purposes. This will be addressed in a later commit.
2018-05-31 14:39:45 -05:00
},
}
terraform: tests for the plan graph builder
2016-11-05 19:58:38 -05:00
b := &PlanGraphBuilder{
core: Fetch schemas during context construction Previously we fetched schemas during the AttachSchemaTransformer, potentially multiple times as that was re-run for each graph built. Now we fetch the schemas just once during context construction, passing that result into each of the graph builders. This only addresses the schema accesses during graph construction. We're still separately loading schemas during the main walk for evaluation purposes. This will be addressed in a later commit.
2018-05-31 14:39:45 -05:00
Config: testModule(t, "graph-builder-plan-basic"),
Components: components,
Schemas: &Schemas{
terraform: use addrs.Provider as map keys for provider schemas (#24002) This is a stepping-stone PR for the provider source project. In this PR "legcay-stype" FQNs are created from the provider name string. Future work involves encoding the FQN directly in the AbsProviderConfig and removing the calls to addrs.NewLegacyProvider().
2020-02-03 07:18:04 -06:00
Providers: map[addrs.Provider]*ProviderSchema{
change mock provider to use GetSchemaResponse This ensures that test providers are using the same types as actual providers.
2021-01-11 14:45:50 -06:00
addrs.NewDefaultProvider("aws"): awsProvider.ProviderSchema(),
addrs.NewDefaultProvider("openstack"): openstackProvider.ProviderSchema(),
core: Get tests compiling again After the refactoring to integrate HCL2 many of the tests were no longer using correct types, attribute names, etc. This is a bulk update of all of the tests to make them compile again, with minimal changes otherwise. Although the tests now compile, many of them do not yet pass. The tests will be gradually repaired in subsequent commits, as we continue to complete the refactoring and retrofit work.
2018-05-04 21:24:06 -05:00
},
},
terraform: tests for the plan graph builder
2016-11-05 19:58:38 -05:00
}
core: Get tests compiling again After the refactoring to integrate HCL2 many of the tests were no longer using correct types, attribute names, etc. This is a bulk update of all of the tests to make them compile again, with minimal changes otherwise. Although the tests now compile, many of them do not yet pass. The tests will be gradually repaired in subsequent commits, as we continue to complete the refactoring and retrofit work.
2018-05-04 21:24:06 -05:00
g, err := b.Build(addrs.RootModuleInstance)
terraform: tests for the plan graph builder
2016-11-05 19:58:38 -05:00
if err != nil {
t.Fatalf("err: %s", err)
}
core: Get tests compiling again After the refactoring to integrate HCL2 many of the tests were no longer using correct types, attribute names, etc. This is a bulk update of all of the tests to make them compile again, with minimal changes otherwise. Although the tests now compile, many of them do not yet pass. The tests will be gradually repaired in subsequent commits, as we continue to complete the refactoring and retrofit work.
2018-05-04 21:24:06 -05:00
if g.Path.String() != addrs.RootModuleInstance.String() {
t.Fatalf("wrong module path %q", g.Path)
terraform: tests for the plan graph builder
2016-11-05 19:58:38 -05:00
}
actual := strings.TrimSpace(g.String())
expected := strings.TrimSpace(testPlanGraphBuilderStr)
if actual != expected {
core: Restore CountBoundaryTransformer to apply, add/adjust tests Moving the transformer wholesale looks like it broke some tests, with some actually doing legit work in normalizing singular resources from a foo.0 notation to just foo. Adjusted the TestPlanGraphBuilder to account for the extra meta.count-boundary nodes in the graph output now, as well as added another context test that tests this case. It appears the issue happens during validate, as this is where the state can be altered to a broken state if things are not properly transformed in the plan graph.
2017-04-20 00:23:52 -05:00
t.Fatalf("expected:\n%s\n\ngot:\n%s", expected, actual)
terraform: tests for the plan graph builder
2016-11-05 19:58:38 -05:00
}
}
lang: Consider "dynamic" blocks when resolving references The hcldec package has no awareness of the dynamic block extension, so the hcldec.Variables function misses any variables declared inside dynamic blocks. dynblock.VariablesHCLDec is a drop-in replacement for hcldec.Variables that _is_ aware of dynamic blocks, returning all of the same variables that hcldec would find naturally plus also any variables used inside the dynamic block "for_each" and "labels" arguments and inside the nested "content" block.
2019-03-18 19:15:23 -05:00
func TestPlanGraphBuilder_dynamicBlock(t *testing.T) {
change mock provider to use GetSchemaResponse This ensures that test providers are using the same types as actual providers.
2021-01-11 14:45:50 -06:00
provider := mockProviderWithResourceTypeSchema("test_thing", &configschema.Block{
Attributes: map[string]*configschema.Attribute{
"id": {Type: cty.String, Computed: true},
"list": {Type: cty.List(cty.String), Computed: true},
},
BlockTypes: map[string]*configschema.NestedBlock{
"nested": {
Nesting: configschema.NestingList,
Block: configschema.Block{
lang: Consider "dynamic" blocks when resolving references The hcldec package has no awareness of the dynamic block extension, so the hcldec.Variables function misses any variables declared inside dynamic blocks. dynblock.VariablesHCLDec is a drop-in replacement for hcldec.Variables that _is_ aware of dynamic blocks, returning all of the same variables that hcldec would find naturally plus also any variables used inside the dynamic block "for_each" and "labels" arguments and inside the nested "content" block.
2019-03-18 19:15:23 -05:00
Attributes: map[string]*configschema.Attribute{
change mock provider to use GetSchemaResponse This ensures that test providers are using the same types as actual providers.
2021-01-11 14:45:50 -06:00
"foo": {Type: cty.String, Optional: true},
lang: Consider "dynamic" blocks when resolving references The hcldec package has no awareness of the dynamic block extension, so the hcldec.Variables function misses any variables declared inside dynamic blocks. dynblock.VariablesHCLDec is a drop-in replacement for hcldec.Variables that _is_ aware of dynamic blocks, returning all of the same variables that hcldec would find naturally plus also any variables used inside the dynamic block "for_each" and "labels" arguments and inside the nested "content" block.
2019-03-18 19:15:23 -05:00
},
},
},
},
change mock provider to use GetSchemaResponse This ensures that test providers are using the same types as actual providers.
2021-01-11 14:45:50 -06:00
})
lang: Consider "dynamic" blocks when resolving references The hcldec package has no awareness of the dynamic block extension, so the hcldec.Variables function misses any variables declared inside dynamic blocks. dynblock.VariablesHCLDec is a drop-in replacement for hcldec.Variables that _is_ aware of dynamic blocks, returning all of the same variables that hcldec would find naturally plus also any variables used inside the dynamic block "for_each" and "labels" arguments and inside the nested "content" block.
2019-03-18 19:15:23 -05:00
components := &basicComponentFactory{
providers: use addrs.Provider as map keys for provider.Factory (#23548) * terraform/context: use new addrs.Provider as map key in provider factories * added NewLegacyProviderType and LegacyString funcs to make it explicit that these are temporary placeholders This PR introduces a new concept, provider fully-qualified name (FQN), encapsulated by the `addrs.Provider` struct.
2019-12-04 10:30:20 -06:00
providers: map[addrs.Provider]providers.Factory{
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
addrs.NewDefaultProvider("test"): providers.FactoryFixed(provider),
lang: Consider "dynamic" blocks when resolving references The hcldec package has no awareness of the dynamic block extension, so the hcldec.Variables function misses any variables declared inside dynamic blocks. dynblock.VariablesHCLDec is a drop-in replacement for hcldec.Variables that _is_ aware of dynamic blocks, returning all of the same variables that hcldec would find naturally plus also any variables used inside the dynamic block "for_each" and "labels" arguments and inside the nested "content" block.
2019-03-18 19:15:23 -05:00
},
}
b := &PlanGraphBuilder{
Config: testModule(t, "graph-builder-plan-dynblock"),
Components: components,
Schemas: &Schemas{
terraform: use addrs.Provider as map keys for provider schemas (#24002) This is a stepping-stone PR for the provider source project. In this PR "legcay-stype" FQNs are created from the provider name string. Future work involves encoding the FQN directly in the AbsProviderConfig and removing the calls to addrs.NewLegacyProvider().
2020-02-03 07:18:04 -06:00
Providers: map[addrs.Provider]*ProviderSchema{
change mock provider to use GetSchemaResponse This ensures that test providers are using the same types as actual providers.
2021-01-11 14:45:50 -06:00
addrs.NewDefaultProvider("test"): provider.ProviderSchema(),
lang: Consider "dynamic" blocks when resolving references The hcldec package has no awareness of the dynamic block extension, so the hcldec.Variables function misses any variables declared inside dynamic blocks. dynblock.VariablesHCLDec is a drop-in replacement for hcldec.Variables that _is_ aware of dynamic blocks, returning all of the same variables that hcldec would find naturally plus also any variables used inside the dynamic block "for_each" and "labels" arguments and inside the nested "content" block.
2019-03-18 19:15:23 -05:00
},
},
}
g, err := b.Build(addrs.RootModuleInstance)
if err != nil {
t.Fatalf("err: %s", err)
}
if g.Path.String() != addrs.RootModuleInstance.String() {
t.Fatalf("wrong module path %q", g.Path)
}
// This test is here to make sure we properly detect references inside
// the special "dynamic" block construct. The most important thing here
// is that at the end test_thing.c depends on both test_thing.a and
// test_thing.b. Other details might shift over time as other logic in
// the graph builders changes.
actual := strings.TrimSpace(g.String())
expected := strings.TrimSpace(`
meta.count-boundary (EachMode fixup)
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
test_thing.c (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/test"]
provider["registry.terraform.io/hashicorp/test"] (close)
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
test_thing.c (expand)
lang: Consider "dynamic" blocks when resolving references The hcldec package has no awareness of the dynamic block extension, so the hcldec.Variables function misses any variables declared inside dynamic blocks. dynblock.VariablesHCLDec is a drop-in replacement for hcldec.Variables that _is_ aware of dynamic blocks, returning all of the same variables that hcldec would find naturally plus also any variables used inside the dynamic block "for_each" and "labels" arguments and inside the nested "content" block.
2019-03-18 19:15:23 -05:00
root
meta.count-boundary (EachMode fixup)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/test"] (close)
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
test_thing.a (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/test"]
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
test_thing.b (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/test"]
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
test_thing.c (expand)
test_thing.a (expand)
test_thing.b (expand)
lang: Consider "dynamic" blocks when resolving references The hcldec package has no awareness of the dynamic block extension, so the hcldec.Variables function misses any variables declared inside dynamic blocks. dynblock.VariablesHCLDec is a drop-in replacement for hcldec.Variables that _is_ aware of dynamic blocks, returning all of the same variables that hcldec would find naturally plus also any variables used inside the dynamic block "for_each" and "labels" arguments and inside the nested "content" block.
2019-03-18 19:15:23 -05:00
`)
if actual != expected {
t.Fatalf("expected:\n%s\n\ngot:\n%s", expected, actual)
}
}
lang: Detect references when a list/set attr is defined using blocks For compatibility with documented patterns from existing providers we are now allowing (via a pre-processing step) any attribute whose type is a list-of-object or set-of-object type to optionally be assigned using one or more blocks whose type is the attribute name. The pre-processing functionality was implemented in previous commits but we were not correctly detecting references within these blocks that are, from the perspective of the primary schema, invalid. Now we'll use an alternative implementation of variable detection that is able to apply the same schema rewriting technique we used to implement the transform and thus can find all of the references as if they were already in their final locations.
2019-03-28 12:07:16 -05:00
func TestPlanGraphBuilder_attrAsBlocks(t *testing.T) {
change mock provider to use GetSchemaResponse This ensures that test providers are using the same types as actual providers.
2021-01-11 14:45:50 -06:00
provider := mockProviderWithResourceTypeSchema("test_thing", &configschema.Block{
Attributes: map[string]*configschema.Attribute{
"id": {Type: cty.String, Computed: true},
"nested": {
Type: cty.List(cty.Object(map[string]cty.Type{
"foo": cty.String,
})),
Optional: true,
lang: Detect references when a list/set attr is defined using blocks For compatibility with documented patterns from existing providers we are now allowing (via a pre-processing step) any attribute whose type is a list-of-object or set-of-object type to optionally be assigned using one or more blocks whose type is the attribute name. The pre-processing functionality was implemented in previous commits but we were not correctly detecting references within these blocks that are, from the perspective of the primary schema, invalid. Now we'll use an alternative implementation of variable detection that is able to apply the same schema rewriting technique we used to implement the transform and thus can find all of the references as if they were already in their final locations.
2019-03-28 12:07:16 -05:00
},
},
change mock provider to use GetSchemaResponse This ensures that test providers are using the same types as actual providers.
2021-01-11 14:45:50 -06:00
})
lang: Detect references when a list/set attr is defined using blocks For compatibility with documented patterns from existing providers we are now allowing (via a pre-processing step) any attribute whose type is a list-of-object or set-of-object type to optionally be assigned using one or more blocks whose type is the attribute name. The pre-processing functionality was implemented in previous commits but we were not correctly detecting references within these blocks that are, from the perspective of the primary schema, invalid. Now we'll use an alternative implementation of variable detection that is able to apply the same schema rewriting technique we used to implement the transform and thus can find all of the references as if they were already in their final locations.
2019-03-28 12:07:16 -05:00
components := &basicComponentFactory{
providers: use addrs.Provider as map keys for provider.Factory (#23548) * terraform/context: use new addrs.Provider as map key in provider factories * added NewLegacyProviderType and LegacyString funcs to make it explicit that these are temporary placeholders This PR introduces a new concept, provider fully-qualified name (FQN), encapsulated by the `addrs.Provider` struct.
2019-12-04 10:30:20 -06:00
providers: map[addrs.Provider]providers.Factory{
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
addrs.NewDefaultProvider("test"): providers.FactoryFixed(provider),
lang: Detect references when a list/set attr is defined using blocks For compatibility with documented patterns from existing providers we are now allowing (via a pre-processing step) any attribute whose type is a list-of-object or set-of-object type to optionally be assigned using one or more blocks whose type is the attribute name. The pre-processing functionality was implemented in previous commits but we were not correctly detecting references within these blocks that are, from the perspective of the primary schema, invalid. Now we'll use an alternative implementation of variable detection that is able to apply the same schema rewriting technique we used to implement the transform and thus can find all of the references as if they were already in their final locations.
2019-03-28 12:07:16 -05:00
},
}
b := &PlanGraphBuilder{
Config: testModule(t, "graph-builder-plan-attr-as-blocks"),
Components: components,
Schemas: &Schemas{
terraform: use addrs.Provider as map keys for provider schemas (#24002) This is a stepping-stone PR for the provider source project. In this PR "legcay-stype" FQNs are created from the provider name string. Future work involves encoding the FQN directly in the AbsProviderConfig and removing the calls to addrs.NewLegacyProvider().
2020-02-03 07:18:04 -06:00
Providers: map[addrs.Provider]*ProviderSchema{
change mock provider to use GetSchemaResponse This ensures that test providers are using the same types as actual providers.
2021-01-11 14:45:50 -06:00
addrs.NewDefaultProvider("test"): provider.ProviderSchema(),
lang: Detect references when a list/set attr is defined using blocks For compatibility with documented patterns from existing providers we are now allowing (via a pre-processing step) any attribute whose type is a list-of-object or set-of-object type to optionally be assigned using one or more blocks whose type is the attribute name. The pre-processing functionality was implemented in previous commits but we were not correctly detecting references within these blocks that are, from the perspective of the primary schema, invalid. Now we'll use an alternative implementation of variable detection that is able to apply the same schema rewriting technique we used to implement the transform and thus can find all of the references as if they were already in their final locations.
2019-03-28 12:07:16 -05:00
},
},
}
g, err := b.Build(addrs.RootModuleInstance)
if err != nil {
t.Fatalf("err: %s", err)
}
if g.Path.String() != addrs.RootModuleInstance.String() {
t.Fatalf("wrong module path %q", g.Path)
}
// This test is here to make sure we properly detect references inside
// the "nested" block that is actually defined in the schema as a
// list-of-objects attribute. This requires some special effort
// inside lang.ReferencesInBlock to make sure it searches blocks of
// type "nested" along with an attribute named "nested".
actual := strings.TrimSpace(g.String())
expected := strings.TrimSpace(`
meta.count-boundary (EachMode fixup)
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
test_thing.b (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/test"]
provider["registry.terraform.io/hashicorp/test"] (close)
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
test_thing.b (expand)
lang: Detect references when a list/set attr is defined using blocks For compatibility with documented patterns from existing providers we are now allowing (via a pre-processing step) any attribute whose type is a list-of-object or set-of-object type to optionally be assigned using one or more blocks whose type is the attribute name. The pre-processing functionality was implemented in previous commits but we were not correctly detecting references within these blocks that are, from the perspective of the primary schema, invalid. Now we'll use an alternative implementation of variable detection that is able to apply the same schema rewriting technique we used to implement the transform and thus can find all of the references as if they were already in their final locations.
2019-03-28 12:07:16 -05:00
root
meta.count-boundary (EachMode fixup)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/test"] (close)
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
test_thing.a (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/test"]
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
test_thing.b (expand)
test_thing.a (expand)
lang: Detect references when a list/set attr is defined using blocks For compatibility with documented patterns from existing providers we are now allowing (via a pre-processing step) any attribute whose type is a list-of-object or set-of-object type to optionally be assigned using one or more blocks whose type is the attribute name. The pre-processing functionality was implemented in previous commits but we were not correctly detecting references within these blocks that are, from the perspective of the primary schema, invalid. Now we'll use an alternative implementation of variable detection that is able to apply the same schema rewriting technique we used to implement the transform and thus can find all of the references as if they were already in their final locations.
2019-03-28 12:07:16 -05:00
`)
if actual != expected {
t.Fatalf("expected:\n%s\n\ngot:\n%s", expected, actual)
}
}
terraform: don't include providers if not targeted Fixes #12009 This is a simple change similar to #10911 where we need to exclude providers that aren't targeted.
2017-02-17 11:21:29 -06:00
func TestPlanGraphBuilder_targetModule(t *testing.T) {
b := &PlanGraphBuilder{
core: Fix tests for TestPlanGraphBuilder Previously this was just stubbing out provider types, but we now need to include schema for each of the providers and resource types the tests use in order for the references to be properly detected. The test fixtures are adjusted slightly here so we can use the simpleTestSchema as the schema for all of the different blocks in these tests. The relationships between the resources are still preserved, but the attributes are renamed to comply with this schema.
2018-05-10 11:56:32 -05:00
Config: testModule(t, "graph-builder-plan-target-module-provider"),
Components: simpleMockComponentFactory(),
core: Fetch schemas during context construction Previously we fetched schemas during the AttachSchemaTransformer, potentially multiple times as that was re-run for each graph built. Now we fetch the schemas just once during context construction, passing that result into each of the graph builders. This only addresses the schema accesses during graph construction. We're still separately loading schemas during the main walk for evaluation purposes. This will be addressed in a later commit.
2018-05-31 14:39:45 -05:00
Schemas: simpleTestSchemas(),
core: Get tests compiling again After the refactoring to integrate HCL2 many of the tests were no longer using correct types, attribute names, etc. This is a bulk update of all of the tests to make them compile again, with minimal changes otherwise. Although the tests now compile, many of them do not yet pass. The tests will be gradually repaired in subsequent commits, as we continue to complete the refactoring and retrofit work.
2018-05-04 21:24:06 -05:00
Targets: []addrs.Targetable{
addrs.RootModuleInstance.Child("child2", addrs.NoKey),
},
terraform: don't include providers if not targeted Fixes #12009 This is a simple change similar to #10911 where we need to exclude providers that aren't targeted.
2017-02-17 11:21:29 -06:00
}
core: Get tests compiling again After the refactoring to integrate HCL2 many of the tests were no longer using correct types, attribute names, etc. This is a bulk update of all of the tests to make them compile again, with minimal changes otherwise. Although the tests now compile, many of them do not yet pass. The tests will be gradually repaired in subsequent commits, as we continue to complete the refactoring and retrofit work.
2018-05-04 21:24:06 -05:00
g, err := b.Build(addrs.RootModuleInstance)
terraform: don't include providers if not targeted Fixes #12009 This is a simple change similar to #10911 where we need to exclude providers that aren't targeted.
2017-02-17 11:21:29 -06:00
if err != nil {
t.Fatalf("err: %s", err)
}
t.Logf("Graph: %s", g.String())
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
testGraphNotContains(t, g, `module.child1.provider["registry.terraform.io/hashicorp/test"]`)
core: Fix tests for TestPlanGraphBuilder Previously this was just stubbing out provider types, but we now need to include schema for each of the providers and resource types the tests use in order for the references to be properly detected. The test fixtures are adjusted slightly here so we can use the simpleTestSchema as the schema for all of the different blocks in these tests. The relationships between the resources are still preserved, but the attributes are renamed to comply with this schema.
2018-05-10 11:56:32 -05:00
testGraphNotContains(t, g, "module.child1.test_object.foo")
terraform: don't include providers if not targeted Fixes #12009 This is a simple change similar to #10911 where we need to exclude providers that aren't targeted.
2017-02-17 11:21:29 -06:00
}
Resource for_each
2019-06-12 10:07:32 -05:00
func TestPlanGraphBuilder_forEach(t *testing.T) {
change mock provider to use GetSchemaResponse This ensures that test providers are using the same types as actual providers.
2021-01-11 14:45:50 -06:00
awsProvider := mockProviderWithResourceTypeSchema("aws_instance", simpleTestSchema())
Resource for_each
2019-06-12 10:07:32 -05:00
components := &basicComponentFactory{
providers: use addrs.Provider as map keys for provider.Factory (#23548) * terraform/context: use new addrs.Provider as map key in provider factories * added NewLegacyProviderType and LegacyString funcs to make it explicit that these are temporary placeholders This PR introduces a new concept, provider fully-qualified name (FQN), encapsulated by the `addrs.Provider` struct.
2019-12-04 10:30:20 -06:00
providers: map[addrs.Provider]providers.Factory{
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
addrs.NewDefaultProvider("aws"): providers.FactoryFixed(awsProvider),
Resource for_each
2019-06-12 10:07:32 -05:00
},
}
b := &PlanGraphBuilder{
Config: testModule(t, "plan-for-each"),
Components: components,
Schemas: &Schemas{
terraform: use addrs.Provider as map keys for provider schemas (#24002) This is a stepping-stone PR for the provider source project. In this PR "legcay-stype" FQNs are created from the provider name string. Future work involves encoding the FQN directly in the AbsProviderConfig and removing the calls to addrs.NewLegacyProvider().
2020-02-03 07:18:04 -06:00
Providers: map[addrs.Provider]*ProviderSchema{
change mock provider to use GetSchemaResponse This ensures that test providers are using the same types as actual providers.
2021-01-11 14:45:50 -06:00
addrs.NewDefaultProvider("aws"): awsProvider.ProviderSchema(),
Resource for_each
2019-06-12 10:07:32 -05:00
},
},
}
g, err := b.Build(addrs.RootModuleInstance)
if err != nil {
t.Fatalf("err: %s", err)
}
if g.Path.String() != addrs.RootModuleInstance.String() {
t.Fatalf("wrong module path %q", g.Path)
}
actual := strings.TrimSpace(g.String())
// We're especially looking for the edge here, where aws_instance.bat
// has a dependency on aws_instance.boo
expected := strings.TrimSpace(testPlanGraphBuilderForEachStr)
if actual != expected {
t.Fatalf("expected:\n%s\n\ngot:\n%s", expected, actual)
}
}
terraform: tests for the plan graph builder
2016-11-05 19:58:38 -05:00
const testPlanGraphBuilderStr = `
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
aws_instance.web (expand)
aws_security_group.firewall (expand)
terraform: tests for the plan graph builder
2016-11-05 19:58:38 -05:00
var.foo
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
aws_load_balancer.weblb (expand)
aws_instance.web (expand)
aws_security_group.firewall (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/aws"]
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
local.instance_id (expand)
aws_instance.web (expand)
core: update test fixtures for new name of the "count boundary" vertex
2018-09-07 18:58:32 -05:00
meta.count-boundary (EachMode fixup)
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
aws_load_balancer.weblb (expand)
remove the need for destroyRootOutputTransformer Since root outputs can now use the planned changes, we can directly insert the correct applyable or destroyable node into the graph during plan and apply, and it will remove the outputs if they are being destroyed.
2020-10-09 16:24:10 -05:00
output.instance_id
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
openstack_floating_ip.random (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/openstack"]
remove the need for destroyRootOutputTransformer Since root outputs can now use the planned changes, we can directly insert the correct applyable or destroyable node into the graph during plan and apply, and it will remove the outputs if they are being destroyed.
2020-10-09 16:24:10 -05:00
output.instance_id
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
local.instance_id (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/aws"]
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
openstack_floating_ip.random (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/aws"] (close)
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
aws_load_balancer.weblb (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/openstack"]
provider["registry.terraform.io/hashicorp/openstack"] (close)
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
openstack_floating_ip.random (expand)
Add the close provider and provisioner transformers (#13102)
2017-04-12 16:25:15 -05:00
root
core: update test fixtures for new name of the "count boundary" vertex
2018-09-07 18:58:32 -05:00
meta.count-boundary (EachMode fixup)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/aws"] (close)
provider["registry.terraform.io/hashicorp/openstack"] (close)
terraform: tests for the plan graph builder
2016-11-05 19:58:38 -05:00
var.foo
`
Resource for_each
2019-06-12 10:07:32 -05:00
const testPlanGraphBuilderForEachStr = `
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
aws_instance.bar (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/aws"]
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
aws_instance.bar2 (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/aws"]
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
aws_instance.bat (expand)
aws_instance.boo (expand)
aws_instance.baz (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/aws"]
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
aws_instance.boo (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/aws"]
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
aws_instance.foo (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/aws"]
Resource for_each
2019-06-12 10:07:32 -05:00
meta.count-boundary (EachMode fixup)
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
aws_instance.bar (expand)
aws_instance.bar2 (expand)
aws_instance.bat (expand)
aws_instance.baz (expand)
aws_instance.foo (expand)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/aws"]
provider["registry.terraform.io/hashicorp/aws"] (close)
update test strings Match the new names output by the expander nodes
2020-05-12 09:54:43 -05:00
aws_instance.bar (expand)
aws_instance.bar2 (expand)
aws_instance.bat (expand)
aws_instance.baz (expand)
aws_instance.foo (expand)
Resource for_each
2019-06-12 10:07:32 -05:00
root
meta.count-boundary (EachMode fixup)
Mildwonkey/tests (#24522) * terraform: add helper functions for creating test state testSetResourceInstanceCurrent and testSetResourceInstanceTainted are wrapper functions around states.Module.SetResourceInstanceCurrent() used to set a resource in state. They work with current, non-deposed resources with no dependencies. testSetResourceInstanceDeposed can be used to set a desosed resource in state. * terraform: update all tests to use modern providers and state
2020-04-01 12:13:40 -05:00
provider["registry.terraform.io/hashicorp/aws"] (close)
Resource for_each
2019-06-12 10:07:32 -05:00
`
Reference in New Issue Copy Permalink