allow depends_on in module call

This commit is contained in:
James Bardin 2020-04-28 17:14:15 -04:00
parent d73fde47ac
commit 1b8fb4083a
2 changed files with 0 additions and 9 deletions

View File

@ -87,14 +87,6 @@ func decodeModuleBlock(block *hcl.Block, override bool) (*ModuleCall, hcl.Diagno
deps, depsDiags := decodeDependsOn(attr) deps, depsDiags := decodeDependsOn(attr)
diags = append(diags, depsDiags...) diags = append(diags, depsDiags...)
mc.DependsOn = append(mc.DependsOn, deps...) mc.DependsOn = append(mc.DependsOn, deps...)
// We currently parse this, but don't yet do anything with it.
diags = append(diags, &hcl.Diagnostic{
Severity: hcl.DiagError,
Summary: "Reserved argument name in module block",
Detail: fmt.Sprintf("The name %q is reserved for use in a future version of Terraform.", attr.Name),
Subject: &attr.NameRange,
})
} }
if attr, exists := content.Attributes["providers"]; exists { if attr, exists := content.Attributes["providers"]; exists {

View File

@ -20,7 +20,6 @@ func TestLoadModuleCall(t *testing.T) {
file, diags := parser.LoadConfigFile("module-calls.tf") file, diags := parser.LoadConfigFile("module-calls.tf")
assertExactDiagnostics(t, diags, []string{ assertExactDiagnostics(t, diags, []string{
`module-calls.tf:22,3-13: Reserved argument name in module block; The name "depends_on" is reserved for use in a future version of Terraform.`,
`module-calls.tf:20,3-11: Invalid combination of "count" and "for_each"; The "count" and "for_each" meta-arguments are mutually-exclusive, only one should be used to be explicit about the number of resources to be created.`, `module-calls.tf:20,3-11: Invalid combination of "count" and "for_each"; The "count" and "for_each" meta-arguments are mutually-exclusive, only one should be used to be explicit about the number of resources to be created.`,
}) })