From 325fd751eb003260bc7fb0402053f930b79db50b Mon Sep 17 00:00:00 2001 From: clint shryock Date: Thu, 19 Nov 2015 16:27:56 -0600 Subject: [PATCH] update TestAccAWSFlowLog_subnet to use new cloudwatch resource, not needing env var anymore --- builtin/providers/aws/resource_aws_flow_log_test.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/builtin/providers/aws/resource_aws_flow_log_test.go b/builtin/providers/aws/resource_aws_flow_log_test.go index 1ffedc3f08..02fb3cfd8a 100644 --- a/builtin/providers/aws/resource_aws_flow_log_test.go +++ b/builtin/providers/aws/resource_aws_flow_log_test.go @@ -33,10 +33,6 @@ func TestAccAWSFlowLog_basic(t *testing.T) { func TestAccAWSFlowLog_subnet(t *testing.T) { var flowLog ec2.FlowLog - lgn := os.Getenv("LOG_GROUP_NAME") - if lgn == "" { - t.Fatalf("LOG_GROUP_NAME env var needed for TestAccAWSFlowLog_subnet") - } resource.Test(t, resource.TestCase{ PreCheck: func() { testAccPreCheck(t) }, @@ -44,7 +40,7 @@ func TestAccAWSFlowLog_subnet(t *testing.T) { CheckDestroy: testAccCheckFlowLogDestroy, Steps: []resource.TestStep{ resource.TestStep{ - Config: fmt.Sprintf(testAccFlowLogConfig_subnet, lgn), + Config: testAccFlowLogConfig_subnet, Check: resource.ComposeTestCheckFunc( testAccCheckFlowLogExists("aws_flow_log.test_flow_log_subnet", &flowLog), testAccCheckAWSFlowLogAttributes(&flowLog), @@ -203,11 +199,14 @@ resource "aws_iam_role" "test_role" { } EOF } +resource "aws_cloudwatch_log_group" "foobar" { + name = "foo-bar" +} resource "aws_flow_log" "test_flow_log_subnet" { # log_group_name needs to exist before hand # until we have a CloudWatch Log Group Resource - log_group_name = "%s" + log_group_name = "${aws_cloudwatch_log_group.foobar.name}" iam_role_arn = "${aws_iam_role.test_role.arn}" subnet_id = "${aws_subnet.test_subnet.id}" traffic_type = "ALL"