IntenseWebs/opentofu
3
0
Fork 0
mirror of https://github.com/opentofu/opentofu.git synced 2024-12-26 17:01:04 -06:00
Code Issues Packages Projects Releases Wiki Activity

Use evaluateCountExpressionValue in validate step

Browse Source 
There was a special, duplicate function that could be replaced by
calling evaluateCountExpressionValue, and removes duplicate code
This commit is contained in:
Pam Selle 2021-01-05 11:24:51 -05:00
parent e9748574b9
commit 33c31dce2b
1 changed files with 6 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
terraform/node_resource_validate.go
View File

@ -11,8 +11,6 @@ import (
"github.com/hashicorp/terraform/provisioners" "github.com/hashicorp/terraform/provisioners"
"github.com/hashicorp/terraform/tfdiags" "github.com/hashicorp/terraform/tfdiags"
"github.com/zclconf/go-cty/cty" "github.com/zclconf/go-cty/cty"
"github.com/zclconf/go-cty/cty/convert"
"github.com/zclconf/go-cty/cty/gocty"
) )
// NodeValidatableResource represents a resource that is used for validation // NodeValidatableResource represents a resource that is used for validation
@ -410,69 +408,16 @@ func (n *NodeValidatableResource) validateResource(ctx EvalContext) tfdiags.Diag
return diags return diags
} }
func validateCount(ctx EvalContext, expr hcl.Expression) tfdiags.Diagnostics { func validateCount(ctx EvalContext, expr hcl.Expression) (diags tfdiags.Diagnostics) {
if expr == nil { val, countDiags := evaluateCountExpressionValue(expr, ctx)
return nil
}
var diags tfdiags.Diagnostics
countVal, countDiags := ctx.EvaluateExpr(expr, cty.Number, nil)
diags = diags.Append(countDiags)
if diags.HasErrors() {
return diags
}
if countVal.IsNull() {
diags = diags.Append(&hcl.Diagnostic{
Severity: hcl.DiagError,
Summary: "Invalid count argument",
Detail: `The given "count" argument value is null. An integer is required.`,
Subject: expr.Range().Ptr(),
})
return diags
}
var err error
countVal, err = convert.Convert(countVal, cty.Number)
if err != nil {
diags = diags.Append(&hcl.Diagnostic{
Severity: hcl.DiagError,
Summary: "Invalid count argument",
Detail: fmt.Sprintf(`The given "count" argument value is unsuitable: %s.`, err),
Subject: expr.Range().Ptr(),
})
return diags
}
// If the value isn't known then that's the best we can do for now, but // If the value isn't known then that's the best we can do for now, but
// we'll check more thoroughly during the plan walk. // we'll check more thoroughly during the plan walk
if !countVal.IsKnown() { if !val.IsKnown() {
return diags return diags
} }
// If we _do_ know the value, then we can do a few more checks here. if countDiags.HasErrors() {
var count int diags = diags.Append(countDiags)
err = gocty.FromCtyValue(countVal, &count)
if err != nil {
// Isn't a whole number, etc.
diags = diags.Append(&hcl.Diagnostic{
Severity: hcl.DiagError,
Summary: "Invalid count argument",
Detail: fmt.Sprintf(`The given "count" argument value is unsuitable: %s.`, err),
Subject: expr.Range().Ptr(),
})
return diags
}
if count < 0 {
diags = diags.Append(&hcl.Diagnostic{
Severity: hcl.DiagError,
Summary: "Invalid count argument",
Detail: `The given "count" argument value is unsuitable: count cannot be negative.`,
Subject: expr.Range().Ptr(),
})
return diags
} }
return diags return diags