diff --git a/builtin/providers/aws/resource_aws_redshift_cluster_test.go b/builtin/providers/aws/resource_aws_redshift_cluster_test.go index ecebd84f07..1f699cb5aa 100644 --- a/builtin/providers/aws/resource_aws_redshift_cluster_test.go +++ b/builtin/providers/aws/resource_aws_redshift_cluster_test.go @@ -3,15 +3,16 @@ package aws import ( "fmt" "math/rand" + "regexp" "testing" "time" "github.com/aws/aws-sdk-go/aws" "github.com/aws/aws-sdk-go/aws/awserr" "github.com/aws/aws-sdk-go/service/redshift" + "github.com/hashicorp/terraform/helper/acctest" "github.com/hashicorp/terraform/helper/resource" "github.com/hashicorp/terraform/terraform" - "regexp" ) func TestValidateRedshiftClusterDbName(t *testing.T) { @@ -136,10 +137,7 @@ func TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled(t *testing.T) { func TestAccAWSRedshiftCluster_loggingEnabled(t *testing.T) { var v redshift.Cluster - - ri := rand.New(rand.NewSource(time.Now().UnixNano())).Int() - preConfig := fmt.Sprintf(testAccAWSRedshiftClusterConfig_loggingEnabled, ri) - postConfig := fmt.Sprintf(testAccAWSRedshiftClusterConfig_loggingDisabled, ri) + rInt := acctest.RandInt() resource.Test(t, resource.TestCase{ PreCheck: func() { testAccPreCheck(t) }, @@ -147,18 +145,18 @@ func TestAccAWSRedshiftCluster_loggingEnabled(t *testing.T) { CheckDestroy: testAccCheckAWSRedshiftClusterDestroy, Steps: []resource.TestStep{ { - Config: preConfig, + Config: testAccAWSRedshiftClusterConfig_loggingEnabled(rInt), Check: resource.ComposeTestCheckFunc( testAccCheckAWSRedshiftClusterExists("aws_redshift_cluster.default", &v), resource.TestCheckResourceAttr( "aws_redshift_cluster.default", "enable_logging", "true"), resource.TestCheckResourceAttr( - "aws_redshift_cluster.default", "bucket_name", "tf-redshift-logging-test-bucket"), + "aws_redshift_cluster.default", "bucket_name", fmt.Sprintf("tf-redshift-logging-%d", rInt)), ), }, { - Config: postConfig, + Config: testAccAWSRedshiftClusterConfig_loggingDisabled(rInt), Check: resource.ComposeTestCheckFunc( testAccCheckAWSRedshiftClusterExists("aws_redshift_cluster.default", &v), resource.TestCheckResourceAttr( @@ -204,10 +202,7 @@ func TestAccAWSRedshiftCluster_iamRoles(t *testing.T) { func TestAccAWSRedshiftCluster_publiclyAccessible(t *testing.T) { var v redshift.Cluster - - ri := rand.New(rand.NewSource(time.Now().UnixNano())).Int() - preConfig := fmt.Sprintf(testAccAWSRedshiftClusterConfig_notPubliclyAccessible, ri) - postConfig := fmt.Sprintf(testAccAWSRedshiftClusterConfig_updatePubliclyAccessible, ri) + rInt := acctest.RandInt() resource.Test(t, resource.TestCase{ PreCheck: func() { testAccPreCheck(t) }, @@ -215,7 +210,7 @@ func TestAccAWSRedshiftCluster_publiclyAccessible(t *testing.T) { CheckDestroy: testAccCheckAWSRedshiftClusterDestroy, Steps: []resource.TestStep{ { - Config: preConfig, + Config: testAccAWSRedshiftClusterConfig_notPubliclyAccessible(rInt), Check: resource.ComposeTestCheckFunc( testAccCheckAWSRedshiftClusterExists("aws_redshift_cluster.default", &v), resource.TestCheckResourceAttr( @@ -224,7 +219,7 @@ func TestAccAWSRedshiftCluster_publiclyAccessible(t *testing.T) { }, { - Config: postConfig, + Config: testAccAWSRedshiftClusterConfig_updatePubliclyAccessible(rInt), Check: resource.ComposeTestCheckFunc( testAccCheckAWSRedshiftClusterExists("aws_redshift_cluster.default", &v), resource.TestCheckResourceAttr( @@ -593,63 +588,66 @@ resource "aws_redshift_cluster" "default" { } ` -var testAccAWSRedshiftClusterConfig_loggingDisabled = ` -resource "aws_redshift_cluster" "default" { - cluster_identifier = "tf-redshift-cluster-%d" - availability_zone = "us-west-2a" - database_name = "mydb" - master_username = "foo_test" - master_password = "Mustbe8characters" - node_type = "dc1.large" - automated_snapshot_retention_period = 0 - allow_version_upgrade = false - enable_logging = false +func testAccAWSRedshiftClusterConfig_loggingDisabled(rInt int) string { + return fmt.Sprintf(` + resource "aws_redshift_cluster" "default" { + cluster_identifier = "tf-redshift-cluster-%d" + availability_zone = "us-west-2a" + database_name = "mydb" + master_username = "foo_test" + master_password = "Mustbe8characters" + node_type = "dc1.large" + automated_snapshot_retention_period = 0 + allow_version_upgrade = false + enable_logging = false + }`, rInt) } -` -var testAccAWSRedshiftClusterConfig_loggingEnabled = ` -resource "aws_s3_bucket" "bucket" { - bucket = "tf-redshift-logging-test-bucket" - force_destroy = true - policy = <