IntenseWebs/opentofu
3
0
Fork 0
mirror of https://github.com/opentofu/opentofu.git synced 2025-02-25 18:45:20 -06:00
Code Issues Packages Projects Releases Wiki Activity

configs: fix module for_each call bug (#31091)

Browse Source 
This fixes a bug introduced in 1879a39 in which initialising a module will fail
if that module contains both a provider block and a module call using for_each.
This commit is contained in:
kmoe 2022-05-20 16:58:46 +01:00 committed by GitHub
parent 55edc6a6af
commit 5417975946
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
internal/configs/provider_validation.go
View File

@ -30,28 +30,24 @@ func validateProviderConfigs(parentCall *ModuleCall, cfg *Config, noProviderConf
for name, child := range cfg.Children {
mc := mod.ModuleCalls[name]
childNoProviderConfigRange := noProviderConfigRange
// if the module call has any of count, for_each or depends_on,
// providers are prohibited from being configured in this module, or
// any module beneath this module.
// NOTE: If noProviderConfigRange was already set but we encounter
// a nested conflicting argument then we'll overwrite the caller's
// range, which allows us to report the problem as close to its
// cause as possible.
switch {
case mc.Count != nil:
noProviderConfigRange = mc.Count.Range().Ptr()
childNoProviderConfigRange = mc.Count.Range().Ptr()
case mc.ForEach != nil:
noProviderConfigRange = mc.ForEach.Range().Ptr()
childNoProviderConfigRange = mc.ForEach.Range().Ptr()
case mc.DependsOn != nil:
if len(mc.DependsOn) > 0 {
noProviderConfigRange = mc.DependsOn[0].SourceRange().Ptr()
childNoProviderConfigRange = mc.DependsOn[0].SourceRange().Ptr()
} else {
// Weird! We'll just use the call itself, then.
noProviderConfigRange = mc.DeclRange.Ptr()
childNoProviderConfigRange = mc.DeclRange.Ptr()
}
}
diags = append(diags, validateProviderConfigs(mc, child, noProviderConfigRange)...)
diags = append(diags, validateProviderConfigs(mc, child, childNoProviderConfigRange)...)
}
// the set of provider configuration names passed into the module, with the