From 5b615882e228e0654aa0b2067205bb1a84452bc2 Mon Sep 17 00:00:00 2001 From: Martin Atkins Date: Thu, 7 Apr 2022 17:00:44 -0700 Subject: [PATCH] build: "Quick Checks" to run for external contributions The "push" event is only for pushes to branches within the same repository. Since external contributors make commits in their own repositories rather than directly in the target repository, we also need the pull_request event to react to opening a pull request and to pushing new code to an external branch associated with a pull request. Since internal pull requests would in principle trigger both "push" _and_ "pull_request", we also constrain the push event only to the branches we typically release from, on the assumption that all other branches will merge into those via pull requests. This avoids redundantly running the same checks in response to two events at the same time. --- .github/workflows/checks.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index d0cedfcb1d..5a02be23cb 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -16,7 +16,14 @@ name: Quick Checks on: + pull_request: push: + branches: + - main + - 'v[0-9]+.[0-9]+' + - checks-workflow-dev/* + tags: + - 'v[0-9]+.[0-9]+.[0-9]+*' # This workflow runs for not-yet-reviewed external contributions and so it # intentionally has no write access and only limited read access to the