diff --git a/internal/cloud/backend_plan.go b/internal/cloud/backend_plan.go index e6d3a60bf8..f678738b67 100644 --- a/internal/cloud/backend_plan.go +++ b/internal/cloud/backend_plan.go @@ -560,7 +560,7 @@ func shouldRenderPlan(run *tfe.Run) bool { func shouldGenerateConfig(out string, run *tfe.Run) bool { return (run.Plan.Status == tfe.PlanErrored || run.Plan.Status == tfe.PlanFinished) && - run.Plan.GeneratedConfiguration == true && len(out) > 0 + run.Plan.GeneratedConfiguration && len(out) > 0 } const planDefaultHeader = ` diff --git a/internal/cloud/tfe_client_mock.go b/internal/cloud/tfe_client_mock.go index 9459941894..83878c7e47 100644 --- a/internal/cloud/tfe_client_mock.go +++ b/internal/cloud/tfe_client_mock.go @@ -1044,7 +1044,7 @@ func (m *MockRuns) Create(ctx context.Context, options tfe.RunCreateOptions) (*t r.RefreshOnly = *options.RefreshOnly } - if options.AllowConfigGeneration != nil && *options.AllowConfigGeneration == true { + if options.AllowConfigGeneration != nil && *options.AllowConfigGeneration { r.Plan.GeneratedConfiguration = true } diff --git a/internal/genconfig/generate_config_write.go b/internal/genconfig/generate_config_write.go index 1764e936a3..99231bd234 100644 --- a/internal/genconfig/generate_config_write.go +++ b/internal/genconfig/generate_config_write.go @@ -9,11 +9,8 @@ import ( ) func ShouldWriteConfig(out string) bool { - if len(out) == 0 { - // No specified out file, so don't write anything. - return false - } - return true + // No specified out file, so don't write anything. + return len(out) != 0 } func ValidateTargetFile(out string) (diags tfdiags.Diagnostics) {