diff --git a/scripts/goimportscheck.sh b/scripts/goimportscheck.sh index 912a548561..e53cafe54d 100755 --- a/scripts/goimportscheck.sh +++ b/scripts/goimportscheck.sh @@ -29,7 +29,11 @@ fi # "IFS" environment variable, but the primary place we want to run this right # now is in our "quick checks" workflow and that _does_ have a reasonably # modern version of Bash. -readarray -t target_files < <(git diff --name-only ${base_branch} --diff-filter=MA | grep "\.go") +readarray -t target_files < <(git diff --name-only ${base_branch} --diff-filter=MA | grep "\.go" | grep -v ".pb.go") + +# NOTE: The above intentionally excludes .pb.go files because those are +# generated by a tool (protoc-gen-go) which itself doesn't produce +# style-compliant imports. if [[ "${#target_files[@]}" -eq 0 ]]; then echo "No files have changed relative to branch ${base_branch}, so there's nothing to check!"