helper/schema: disallow negative hash codes

helper/schema/set.go

@@ -123,6 +123,9 @@ func (s *Set) add(item interface{}) int {
 	s.once.Do(s.init)
 
 	code := s.F(item)
+	if code < 0 {
+		code *= -1
+	}
 	if _, ok := s.m[code]; !ok {
 		s.m[code] = item
 	}

helper/schema/set_test.go

@@ -18,6 +18,20 @@ func TestSetAdd(t *testing.T) {
 	}
 }
 
+func TestSetAdd_negative(t *testing.T) {
+	// Since we don't allow negative hashes, this should just hash to the
+	// same thing...
+	s := &Set{F: testSetInt}
+	s.Add(-1)
+	s.Add(1)
+
+	expected := []interface{}{-1}
+	actual := s.List()
+	if !reflect.DeepEqual(actual, expected) {
+		t.Fatalf("bad: %#v", actual)
+	}
+}
+
 func TestSetContains(t *testing.T) {
 	s := &Set{F: testSetInt}
 	s.Add(5)