From 7cefa0df5b1e249d0b4980d40cb7058d44caf74c Mon Sep 17 00:00:00 2001 From: RLRabinowitz Date: Wed, 23 Aug 2023 10:44:43 +0300 Subject: [PATCH] Update README in internal/ipaddr to match OpenTF --- internal/ipaddr/README.md | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/internal/ipaddr/README.md b/internal/ipaddr/README.md index f0d54988f5..e46bebf951 100644 --- a/internal/ipaddr/README.md +++ b/internal/ipaddr/README.md @@ -5,7 +5,7 @@ as of Go 1.16, used under the Go project license which we've included here in [`LICENSE`](LICENSE) and [`PATENTS`](PATENTS), which are also copied from the Go project. -Terraform has its own fork of these functions because Go 1.17 included a +OpenTF has its own fork of these functions because Go 1.17 included a breaking change to reject IPv4 address octets written with leading zeros. The Go project rationale for that change was that Go historically interpreted @@ -19,14 +19,6 @@ implementations may cause naive validation or policy checks to produce incorrect results, and thus it's a potential security concern. For more information, see [Go issue #30999](https://golang.org/issue/30999). -After careful consideration, the Terraform team has concluded that Terraform's -use of these functions as part of the implementation of the `cidrhost`, -`cidrsubnet`, `cidrsubnets`, and `cidrnetmask` functions has a more limited -impact than the general availability of these functions in the Go standard -library, and so we can't justify a similar exception to our Terraform 1.0 -compatibility promises as the Go team made to their Go 1.0 compatibility -promises. - If you're considering using this package for new functionality _other than_ the built-in functions mentioned above, please do so only if consistency with the behavior of those functions is important. Otherwise, new features are not