From 801f60fda8dc1c87b9733b2dd5d8e0682904d16a Mon Sep 17 00:00:00 2001 From: James Bardin Date: Tue, 22 Sep 2020 15:44:12 -0400 Subject: [PATCH] only ignore changes from the configuration ignore_changes should only exclude changes to the resource arguments, and not alter the returned value from PlanResourceChange. This would effect very few providers, since most current providers don't actively create their plan, and those that do should be generating computed values here rather than modifying existing ones. --- terraform/eval_diff.go | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/terraform/eval_diff.go b/terraform/eval_diff.go index f8fa83a961..7375054760 100644 --- a/terraform/eval_diff.go +++ b/terraform/eval_diff.go @@ -334,16 +334,6 @@ func (n *EvalDiff) Eval(ctx EvalContext) (interface{}, error) { } } - // TODO: We should be able to remove this repeat of processing ignored changes - // after the plan, which helps providers relying on old behavior "just work" - // in the next major version, such that we can be stricter about ignore_changes - // values - plannedNewVal, ignoreChangeDiags = n.processIgnoreChanges(priorVal, plannedNewVal) - diags = diags.Append(ignoreChangeDiags) - if ignoreChangeDiags.HasErrors() { - return nil, diags.Err() - } - // The provider produces a list of paths to attributes whose changes mean // that we must replace rather than update an existing remote object. // However, we only need to do that if the identified attributes _have_