Use Equal instead of address strings (#2172)

Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
This commit is contained in:
Jon Johnson 2024-11-18 00:53:19 -08:00 committed by GitHub
parent 0e189b33f8
commit 821e67feed
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -126,9 +126,8 @@ func (cs *ChangesSync) RemoveResourceInstanceChange(addr addrs.AbsResourceInstan
dk = realDK
}
addrStr := addr.String()
for i, r := range cs.changes.Resources {
if r.Addr.String() != addrStr || r.DeposedKey != dk {
if !r.Addr.Equal(addr) || r.DeposedKey != dk {
continue
}
copy(cs.changes.Resources[i:], cs.changes.Resources[i+1:])
@ -214,10 +213,8 @@ func (cs *ChangesSync) RemoveOutputChange(addr addrs.AbsOutputValue) {
cs.lock.Lock()
defer cs.lock.Unlock()
addrStr := addr.String()
for i, o := range cs.changes.Outputs {
if o.Addr.String() != addrStr {
if !o.Addr.Equal(addr) {
continue
}
copy(cs.changes.Outputs[i:], cs.changes.Outputs[i+1:])