From a49b162dd1782d35f69d895ac4fba7549b0304d3 Mon Sep 17 00:00:00 2001
From: James Nugent <james@jen20.com>
Date: Tue, 10 Nov 2015 13:31:15 -0500
Subject: [PATCH] Prompt for input variables before context validate

Also adds a regression test using Mock UI. Fixes #3767.
---
 command/plan.go      |  8 +++++---
 command/plan_test.go | 25 +++++++++++++++++++++++++
 2 files changed, 30 insertions(+), 3 deletions(-)

diff --git a/command/plan.go b/command/plan.go
index cd1aeaec6f..8c5fda5cc9 100644
--- a/command/plan.go
+++ b/command/plan.go
@@ -68,14 +68,16 @@ func (c *PlanCommand) Run(args []string) int {
 		c.Ui.Error(err.Error())
 		return 1
 	}
-	if !validateContext(ctx, c.Ui) {
-		return 1
-	}
+
 	if err := ctx.Input(c.InputMode()); err != nil {
 		c.Ui.Error(fmt.Sprintf("Error configuring: %s", err))
 		return 1
 	}
 
+	if !validateContext(ctx, c.Ui) {
+		return 1
+	}
+
 	if refresh {
 		c.Ui.Output("Refreshing Terraform state prior to plan...\n")
 		state, err := ctx.Refresh()
diff --git a/command/plan_test.go b/command/plan_test.go
index d49200a5fe..d0d14bc567 100644
--- a/command/plan_test.go
+++ b/command/plan_test.go
@@ -1,6 +1,7 @@
 package command
 
 import (
+	"bytes"
 	"io/ioutil"
 	"os"
 	"path/filepath"
@@ -330,6 +331,30 @@ func TestPlan_vars(t *testing.T) {
 	}
 }
 
+func TestPlan_varsUnset(t *testing.T) {
+	// Disable test mode so input would be asked
+	test = false
+	defer func() { test = true }()
+
+	defaultInputReader = bytes.NewBufferString("bar\n")
+
+	p := testProvider()
+	ui := new(cli.MockUi)
+	c := &PlanCommand{
+		Meta: Meta{
+			ContextOpts: testCtxConfig(p),
+			Ui:          ui,
+		},
+	}
+
+	args := []string{
+		testFixturePath("plan-vars"),
+	}
+	if code := c.Run(args); code != 0 {
+		t.Fatalf("bad: %d\n\n%s", code, ui.ErrorWriter.String())
+	}
+}
+
 func TestPlan_varFile(t *testing.T) {
 	varFilePath := testTempFile(t)
 	if err := ioutil.WriteFile(varFilePath, []byte(planVarFile), 0644); err != nil {