From ab9c9950645d10c3919fd034885ddf6aca577cd8 Mon Sep 17 00:00:00 2001
From: Oleksandr Levchenkov <ollevche@gmail.com>
Date: Mon, 3 Jun 2024 16:29:14 +0300
Subject: [PATCH] fix tofu installation tests (#1695)

Signed-off-by: ollevche <ollevche@gmail.com>
---
 .github/workflows/checks.yml                  | 21 ++++++++++---------
 .../docs/intro/install/alpine-convenience.sh  |  2 +-
 website/docs/intro/install/deb-convenience.sh |  2 +-
 website/docs/intro/install/rpm-convenience.sh |  2 +-
 .../docs/intro/install/standalone-install.sh  |  2 +-
 .../install/test-install-instructions.sh      |  2 +-
 6 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
index 5753e39b52..462234ee69 100644
--- a/.github/workflows/checks.yml
+++ b/.github/workflows/checks.yml
@@ -257,13 +257,14 @@ jobs:
         with:
           path: ".licensei.cache"
           key: licensei-cache-${{ hashFiles('go.sum') }}
-#  installation-instructions:
-#    name: "Test Installation Instructions"
-#    runs-on: ubuntu-latest
-#
-#    steps:
-#      - name: "Fetch source code"
-#        uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
-#
-#      - name: "Run Installation Instructions Test"
-#        run: make test-linux-install-instructions
+ 
+  installation-instructions:
+    name: "Test Installation Instructions"
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: "Fetch source code"
+        uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
+
+      - name: "Run Installation Instructions Test"
+        run: make test-linux-install-instructions
diff --git a/website/docs/intro/install/alpine-convenience.sh b/website/docs/intro/install/alpine-convenience.sh
index 18411c112a..97505cd211 100644
--- a/website/docs/intro/install/alpine-convenience.sh
+++ b/website/docs/intro/install/alpine-convenience.sh
@@ -11,4 +11,4 @@ chmod +x install-opentofu.sh
 ./install-opentofu.sh --install-method apk
 
 # Remove the installer:
-rm install-opentofu.sh
\ No newline at end of file
+rm -f install-opentofu.sh
\ No newline at end of file
diff --git a/website/docs/intro/install/deb-convenience.sh b/website/docs/intro/install/deb-convenience.sh
index 80ef978ddb..8105fc8aa4 100644
--- a/website/docs/intro/install/deb-convenience.sh
+++ b/website/docs/intro/install/deb-convenience.sh
@@ -11,4 +11,4 @@ chmod +x install-opentofu.sh
 ./install-opentofu.sh --install-method deb
 
 # Remove the installer:
-rm install-opentofu.sh
\ No newline at end of file
+rm -f install-opentofu.sh
\ No newline at end of file
diff --git a/website/docs/intro/install/rpm-convenience.sh b/website/docs/intro/install/rpm-convenience.sh
index e0ad0de033..a5d7a29285 100644
--- a/website/docs/intro/install/rpm-convenience.sh
+++ b/website/docs/intro/install/rpm-convenience.sh
@@ -11,4 +11,4 @@ chmod +x install-opentofu.sh
 ./install-opentofu.sh --install-method rpm
 
 # Remove the installer:
-rm install-opentofu.sh
\ No newline at end of file
+rm -f install-opentofu.sh
\ No newline at end of file
diff --git a/website/docs/intro/install/standalone-install.sh b/website/docs/intro/install/standalone-install.sh
index 5a9333e20d..6f8e93db58 100644
--- a/website/docs/intro/install/standalone-install.sh
+++ b/website/docs/intro/install/standalone-install.sh
@@ -11,4 +11,4 @@ chmod +x install-opentofu.sh
 ./install-opentofu.sh --install-method standalone
 
 # Remove the installer:
-rm install-opentofu.sh
\ No newline at end of file
+rm -f install-opentofu.sh
\ No newline at end of file
diff --git a/website/docs/intro/install/test-install-instructions.sh b/website/docs/intro/install/test-install-instructions.sh
index c235bc7ebb..97374c2db8 100755
--- a/website/docs/intro/install/test-install-instructions.sh
+++ b/website/docs/intro/install/test-install-instructions.sh
@@ -28,7 +28,7 @@ for SERVICE in $SERVICES; do
     echo -e "::group::\033[0;32m✅  ${SERVICE}\033[0m"
   else
     echo -e "::group::\033[0;31m❌  ${SERVICE}\033[0m"
-    FAILED=$(("${FAILED}"+1))
+    FAILED=$((${FAILED}+1))
   fi
   cat $TEMPFILE | grep -a -E "^[a-zA-Z]+-${SERVICE}-1\s+\| " | sed -E "s/^[a-zA-Z]+-${SERVICE}-1\s+\| //"
   echo "::endgroup::"