IntenseWebs/opentofu
3
0
Fork 0
mirror of https://github.com/opentofu/opentofu.git synced 2025-02-25 18:45:20 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #11383 from brad-larson/brad-fix-regexp-validation

Browse Source 
Fix: Incorrect AWS Lambda Qualifier Regexp
This commit is contained in:
Clint 2017-01-26 16:38:00 -06:00 committed by GitHub
commit e3c89da542
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
builtin/providers/aws/validators.go
View File

@ -251,7 +251,7 @@ func validateLambdaQualifier(v interface{}, k string) (ws []string, errors []err
"%q cannot be longer than 128 characters: %q", k, value)) "%q cannot be longer than 128 characters: %q", k, value))
} }
// http://docs.aws.amazon.com/lambda/latest/dg/API_AddPermission.html // http://docs.aws.amazon.com/lambda/latest/dg/API_AddPermission.html
pattern := `^[a-zA-Z0-9$_]+$` pattern := `^[a-zA-Z0-9$_-]+$`
if !regexp.MustCompile(pattern).MatchString(value) { if !regexp.MustCompile(pattern).MatchString(value) {
errors = append(errors, fmt.Errorf( errors = append(errors, fmt.Errorf(
"%q doesn't comply with restrictions (%q): %q", "%q doesn't comply with restrictions (%q): %q",

2
builtin/providers/aws/validators_test.go
View File

@ -111,6 +111,8 @@ func TestValidateLambdaQualifier(t *testing.T) {
"prod", "prod",
"PROD", "PROD",
"MyTestEnv", "MyTestEnv",
"contains-dashes",
"contains_underscores",
"$LATEST", "$LATEST",
} }
for _, v := range validNames { for _, v := range validNames {