Merge pull request #102 from opentffoundation/opentf-user-facing-internal-ipaddr

Adapt user-facing usages of terraform in `internal/ipaddr`
This commit is contained in:
RLRabinowitz 2023-08-23 13:55:23 +03:00 committed by GitHub
commit e56251e2f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -5,7 +5,7 @@ as of Go 1.16, used under the Go project license which we've included here
in [`LICENSE`](LICENSE) and [`PATENTS`](PATENTS), which are also copied from
the Go project.
Terraform has its own fork of these functions because Go 1.17 included a
OpenTF has its own fork of these functions because Go 1.17 included a
breaking change to reject IPv4 address octets written with leading zeros.
The Go project rationale for that change was that Go historically interpreted
@ -19,7 +19,7 @@ implementations may cause naive validation or policy checks to produce
incorrect results, and thus it's a potential security concern. For more
information, see [Go issue #30999](https://golang.org/issue/30999).
After careful consideration, the Terraform team has concluded that Terraform's
After careful consideration, it was concluded that OpenTF's
use of these functions as part of the implementation of the `cidrhost`,
`cidrsubnet`, `cidrsubnets`, and `cidrnetmask` functions has a more limited
impact than the general availability of these functions in the Go standard