From e5f8adfc1a329adb0bb4855ba340e1e92ccb2f0a Mon Sep 17 00:00:00 2001
From: James Bardin <j.bardin@gmail.com>
Date: Mon, 19 Mar 2018 20:32:37 -0400
Subject: [PATCH] add failing test for invalid output with targets

Outputs that are missing references aren't always removed from the
graph, due to being filtered before their dependents are removed.
---
 terraform/context_plan_test.go                | 22 +++++++++++++++++++
 .../plan-untargeted-resource-output/main.tf   |  8 +++++++
 .../mod/main.tf                               | 15 +++++++++++++
 3 files changed, 45 insertions(+)
 create mode 100644 terraform/test-fixtures/plan-untargeted-resource-output/main.tf
 create mode 100644 terraform/test-fixtures/plan-untargeted-resource-output/mod/main.tf

diff --git a/terraform/context_plan_test.go b/terraform/context_plan_test.go
index 8b680879dc..8afb4c320f 100644
--- a/terraform/context_plan_test.go
+++ b/terraform/context_plan_test.go
@@ -2969,6 +2969,28 @@ STATE:
 	}
 }
 
+// ensure that outputs missing references due to targetting are removed from
+// the graph.
+func TestContext2Plan_outputContainsTargetedResource(t *testing.T) {
+	m := testModule(t, "plan-untargeted-resource-output")
+	p := testProvider("aws")
+	p.DiffFn = testDiffFn
+	ctx := testContext2(t, &ContextOpts{
+		Module: m,
+		ProviderResolver: ResourceProviderResolverFixed(
+			map[string]ResourceProviderFactory{
+				"aws": testProviderFuncFixed(p),
+			},
+		),
+		Targets: []string{"module.mod.aws_instance.a"},
+	})
+
+	_, err := ctx.Plan()
+	if err != nil {
+		t.Fatalf("err: %s", err)
+	}
+}
+
 // https://github.com/hashicorp/terraform/issues/4515
 func TestContext2Plan_targetedOverTen(t *testing.T) {
 	m := testModule(t, "plan-targeted-over-ten")
diff --git a/terraform/test-fixtures/plan-untargeted-resource-output/main.tf b/terraform/test-fixtures/plan-untargeted-resource-output/main.tf
new file mode 100644
index 0000000000..9d4a1c882d
--- /dev/null
+++ b/terraform/test-fixtures/plan-untargeted-resource-output/main.tf
@@ -0,0 +1,8 @@
+module "mod" {
+  source = "./mod"
+}
+
+
+resource "aws_instance" "c" {
+  name = "${module.mod.output}"
+}
diff --git a/terraform/test-fixtures/plan-untargeted-resource-output/mod/main.tf b/terraform/test-fixtures/plan-untargeted-resource-output/mod/main.tf
new file mode 100644
index 0000000000..d7ee9a7fa1
--- /dev/null
+++ b/terraform/test-fixtures/plan-untargeted-resource-output/mod/main.tf
@@ -0,0 +1,15 @@
+locals {
+  "one" = 1
+}
+
+resource "aws_instance" "a" {
+  count = "${local.one}"
+}
+
+resource "aws_instance" "b" {
+  count = "${local.one}"
+}
+
+output "output" {
+  value = "${join("", coalescelist(aws_instance.a.*.id, aws_instance.b.*.id))}"
+}