Catch invalid name in provider_meta before it causes a crash (#2347)

Signed-off-by: Marcin Wyszynski <marcin.pixie@gmail.com>

CHANGELOG.md

@@ -17,6 +17,7 @@ ENHANCEMENTS:
 
 BUG FIXES:
 
+- Fixed an issue where an invalid provider name in the `provider_meta` block would crash OpenTofu rather than report an error ([#2347](https://github.com/opentofu/opentofu/pull/2347))
 
 ## Previous Releases
 

internal/configs/provider_meta.go

@@ -30,8 +30,11 @@ func decodeProviderMetaBlock(block *hcl.Block) (*ProviderMeta, hcl.Diagnostics)
 		diags = append(diags, d...)
 	}
 
-	// verify that the local name is already localized or produce an error.
-	diags = append(diags, checkProviderNameNormalized(block.Labels[0], block.DefRange)...)
+	// If the name is invalid, we return an error early, lest the invalid value
+	// is used by the caller and causes a panic further down the line.
+	if diags = append(diags, checkProviderNameNormalized(block.Labels[0], block.DefRange)...); diags.HasErrors() {
+		return nil, diags
+	}
 
 	return &ProviderMeta{
 		Provider:      block.Labels[0],

internal/configs/testdata/invalid-modules/provider-meta-invalid-interpolation/main.tf

@@ -7,4 +7,3 @@ terraform {
 variable "name" {
   type = string
 }
-

internal/configs/testdata/invalid-modules/provider-meta-invalid-name/main.tf

@@ -0,0 +1,5 @@
+terraform {
+  provider_meta "chunky_bacon" {
+    hello = "world"
+  }
+}