Commit Graph

143 Commits

Author SHA1 Message Date
modrake
0d7c718263
build: go-version action no longer uses deprecated "set-output" mechanism
GitHub has deprecated this in favor of appending to a temporary file instead:
     https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
2023-05-30 11:32:12 -07:00
Alisdair McDiarmid
048cc65787
Update PR template to target 1.5.x by default 2023-05-19 09:42:53 -04:00
hashicorp-copywrite[bot]
325d18262e [COMPLIANCE] Add Copyright and License Headers 2023-05-02 15:33:06 +00:00
Scott Macfarlane
fa3980b77d
Disable reproducability check in actions-go-build (#33095)
Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com>
2023-04-26 19:42:00 +01:00
Liam Cervante
1a36d07ead
Add new actions for executing the equivalence tests after a CRT release (#32959)
* add new actions for executing the equivalence tests after a CRT release

* ready for review

* Update .github/actions/equivalence-test/action.yml

Co-authored-by: CJ Horton <17039873+radditude@users.noreply.github.com>

* address comments

---------

Co-authored-by: CJ Horton <17039873+radditude@users.noreply.github.com>
2023-04-17 10:51:04 +02:00
Daniel Kimsey
1d9581682b ci: Smoke test docker builds
This adds a test to catch the glibc build issue that caused #32947. We check
both the container executes and the version is correct.
2023-04-05 12:32:27 -05:00
Daniel Kimsey
64c4e1b4c1
Merge pull request #32951 from hashicorp/fix-incorrect-cgo-flag
ci: Correctly pass cgo_enabled=0 flag
2023-03-30 13:45:02 -05:00
Daniel Kimsey
e9628c5eba
ci: Correctly pass cgo_enabled=0 flag
This flag was not being passed correctly, it caused the value to be read as unset. Which effectively defaults to enabled.

Related to incident 230330-1
2023-03-30 13:38:50 -05:00
emily neil
649d6d3f12
Upload ECR image to correct ECR repo (#32948)
Co-authored-by: emilymianeil <eneil@hashicorp.com>
2023-03-30 11:38:02 -07:00
emily neil
880b87a0e7
Releng/migrate common release tooling (#32797)
* Migrate set-output to GITHUB_OUTPUT

Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com>

* Migrate terraform to CRT

* Update ci branches & ci notification channel

* Use version/VERSION file to parse version

* Remove fetch raw version script and update pipeline to run on current branch

* PR feedback: cgo-enabled now required flag, updated comments & include promotion steps in ci.hcl

* Update version for main

---------

Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com>
Co-authored-by: Scott Macfarlane <smacfarlane@hashicorp.com>
Co-authored-by: emilymianeil <eneil@hashicorp.com>
2023-03-28 10:39:37 -07:00
Ashlee M Boyer
b431b4ab80
Update check-legacy-links-format.yml 2023-03-09 13:12:27 -05:00
Ashlee M Boyer
e793729602
Delete test-link-rewrites.yml 2023-03-06 15:25:37 -05:00
Ashlee Boyer
c850399c0d Updating main-branch-preview-url 2023-02-23 12:57:23 -05:00
Ashlee Boyer
534366d0ff Adding test-link-rewrites workflow 2023-02-23 12:04:12 -05:00
Ashlee Boyer
e81c849617 Adding docs-content-check-legacy-links-format workflow 2023-02-23 12:04:12 -05:00
CJ Horton
25d8f26e41
Remove docs bundle from build workflow 2023-02-17 19:56:45 -08:00
Liam Cervante
6a1a9928a2
[equivalence tests] Use the latest equivalence testing version when executing equivalence tests. (#32659) 2023-02-13 15:40:02 +01:00
Liam Cervante
2325ec716c
Update Terraform equivalence tests to remove unneeded input. (#32288)
* test

* update equivalence testing framework version

* Remove debugging statements

* remove more debugging statements

* s/liamcervante/hashicorp/g

* remove and update deprecated set-output statements
2022-12-02 11:22:02 +01:00
Liam Cervante
37b88b33ce
Rollout equivalence testing during Terraform releases and builds (#31928)
* add some basic equivalence tests and execute them in the build pipeline

* remove old file, now unused

* update terraform-equivalence-testing to v0.2.0

* add separate action

* make sure to read from hashicorp repo

* remove elevated github token where possible

* Don't need elevated token anymore

* update with official mock provider

* last change: don't need the authorization header for public repositories.
2022-11-24 14:00:08 +01:00
Craig Wright
3b8e97c38c
Update CONTRIBUTING.md
Removing the statement which does not reflect the current status for reviews of community-contributed pull requests.
2022-10-28 11:28:54 -07:00
Craig Wright
ae4a8ba77b
Fixing a bug introduced in the review process. 2022-10-17 14:40:47 -07:00
Craig Wright
1650bb9892
Merge pull request #31951 from hashicorp/docs-issue-form
Add Documentation Issue form template
2022-10-14 15:35:16 -07:00
Craig Wright
d40b5c7755
Update .github/ISSUE_TEMPLATE/documentation_issue.yml
Co-authored-by: Judith Malnick <judith.patudith@gmail.com>
2022-10-14 15:35:08 -07:00
Craig Wright
a8d6d5c913
Correcting a line break visual issue. 2022-10-06 10:00:13 -07:00
Craig Wright
b1c720a633
Update .github/ISSUE_TEMPLATE/documentation_issue.yml
Thanks!

Co-authored-by: Judith Malnick <judith.patudith@gmail.com>
2022-10-06 09:58:44 -07:00
Craig Wright
f058392421
Apply suggestions from code review
Thanks!

Co-authored-by: Judith Malnick <judith.patudith@gmail.com>
2022-10-06 09:58:09 -07:00
Liam Cervante
4d7ba14f72
Add skeleton action for equivalence tests (#31940) 2022-10-06 12:11:27 +02:00
Craig Wright
3afa9bd08e
Create documentation_issue.yml
Closes https://github.com/hashicorp/terraform/issues/31552. 

Adds a new issue form type for documentation issues. Format discussed with docs team.
2022-10-05 14:45:24 -07:00
Alisdair McDiarmid
3ff89c9cec
Update pull_request_template.md 2022-09-22 09:17:31 -04:00
Alisdair McDiarmid
99fcb747e9
Revise markup to avoid unwanted checklist UI 2022-09-19 11:40:35 -04:00
Alisdair McDiarmid
6c75e54681 Add initial pull request template
This is intended to add some structure to pull request descriptions, and
encourage peer review of changelog entries before merging a PR.
2022-09-19 10:11:36 -04:00
Martin Atkins
d735de3656 build: checks.yml GitHub Actions workflow doesn't need goimports installed
The importscheck script now uses "go run" to run this program and so
the Go toolchain will install it automatically using the version number
of golang.org/x/tools specified in our go.mod file.
2022-08-26 09:47:30 -07:00
Craig Wright
a63a2e3ec8 Minor copy fixes for the issue form title reminder text. 2022-08-19 17:11:13 -07:00
Craig Wright
9ca1b18988 Fixing placeholder values, adding usage note to bottom of the form. 2022-08-19 17:07:03 -07:00
Craig Wright
dc0f196cbb
Merge pull request #31651 from hashicorp/issue-forms
Migrating from Markdown to Form style Github issues.
2022-08-19 16:44:43 -07:00
Craig Wright
95c133f2ec Modifying the version input to use shell rendering.
This simplifies entry for the user, no longer requiring markdown
formatting wrappers.
2022-08-19 16:29:42 -07:00
Alvin Huang
634c875bea set PRODUCT_VERSION for default docker build 2022-08-18 12:50:41 -04:00
Craig Wright
aba0ac0fae Migrating from Markdown to Form style Github issues.
The goal of this change is to simplify the process of filing
issues with hashicorp/terraform. In the previous Markdown syntax,
the instructions tended to get washed out in a sea of comment
markers. The new Github Form Issues breaks each section into a form
element, with instructions printed clearly as HTML in the page.

We are further hoping to guide users to the correct repository when
filing provider issues, or the community forums when asking usage
questions.
2022-08-16 12:12:48 -07:00
Liam Cervante
afd273d636
Add goimports as a check to the Github commit actions (#31432)
* Add goimports as a check to the Github commit actions

* check diff against main instead of last commit

* goimports should fix the problems

* fix up conditionals and wildcard matching

* specify origin/main in diff

* fetch main branch when checkout

* back to origin main
2022-07-19 10:14:28 +01:00
Martin Atkins
284a38a04c build: Accept version numbers with prereleases containing dashes
Previously we'd discard everything after the second dash.
2022-05-23 16:48:34 -07:00
Martin Atkins
096f0dc0da build: Write the detected version number into the generated executable
This also sets an additional variable if it detects that this is an alpha
or development build, which currently does nothing but might eventually
turn on the ability to use experimental features, if we make that
something available only in prereleases.
2022-05-23 16:48:34 -07:00
Martin Atkins
7dd3cdfab4 build: Fetch all tags before deciding which version we're building
The actions/checkout workflow does some heroics to try to fetch exactly
the commit being built and nothing else, even if asked to fetch the
history leading up to that commit. That means we don't end up having
enough information to get an accurate answer from "git describe".

Since we're intentionally relying on the git history here, we'll fetch
all of the tags explicitly after initial checkout. Although that does add
some delay to this step, we're intentionally doing this version
calculation only once as a separate workflow job so that all of the other
jobs can still benefit from this action's quicker checkout behavior.
2022-05-23 16:48:34 -07:00
James Bardin
2bd72914d8 add internal/states to the race detector tests
This runs relatively quickly, and there is at least 1 test with
concurrent operations.
2022-04-28 11:44:32 -04:00
Claire Labry
dd2decf921
change action to pull v1 instead of main 2022-04-22 13:54:40 -04:00
James Bardin
0693c8dfe7 enable the race detector in tests 2022-04-20 16:32:39 -04:00
Martin Atkins
5b615882e2
build: "Quick Checks" to run for external contributions
The "push" event is only for pushes to branches within the same repository.

Since external contributors make commits in their own repositories rather than directly in the target repository, we also need the pull_request event to react to opening a pull request and to pushing new code to an external branch associated with a pull request.

Since internal pull requests would in principle trigger both "push" _and_ "pull_request", we also constrain the push event only to the branches we typically release from, on the assumption that all other branches will merge into those via pull requests. This avoids redundantly running the same checks in response to two events at the same time.
2022-04-07 17:00:44 -07:00
Martin Atkins
bbf540e0e3 build: "Quick Checks" caches protoc between runs
Building our protobuf files requires the protoc tool, which takes a little
while to download and install. Hopefully downloading it out of the GitHub
Actions cache will make it a little faster in the common case where we're
still using the same version as the previous run.
2022-04-04 08:12:44 -07:00
Martin Atkins
42a618f7c1 build: "Quick Checks" runs consistency checks concurrently with others
Originally we had this running as part of the Unit Tests job because most
of the checks are relatively fast. However, the addition of the protobuf
generation check made that no longer be true because it needs to download
and run protoc.

With that extra overhead it now _is_ productive to spend the time booting
and installing Go on third worker, as long as GitHub Actions continues
to let us run all three of these jobs concurrently most of the time.
2022-04-04 08:12:44 -07:00
Martin Atkins
95f26b340b build: "Quick Checks" no longer uses goenv
goenv was making things more complicated than needed since it's really
designed to help with interactive use in a shell more than automated use
like this.

Instead, we'll follow the same strategy that our build.yml was doing of
just reading the .go-version file directly and then using the official
actions/setup-go action to do the actual installation. The key advantage
here is that Go ends up installed in a way where just running "go" will
do the right thing, and we no longer need to fuss with shims and
version-based path prefixes.

Rather than duplicating the logic from build.yml, instead it's factored
out into a separate composite action which both build.yml and checks.yml
will now share, in case we want to change the Go version selection
methodology in the future.
2022-04-04 08:12:44 -07:00
Martin Atkins
67fedd48a6 build: "Quick Checks" avoid repeating Install Go
This factors out the "Install Go" step into a separate composite action
which we can then call from both of the jobs that need it.

We can't factor out the "Cache Go Modules" because GitHub doesn't allow
composite actions to refer to other external actions.
2022-04-04 08:12:44 -07:00