James Nugent
b044340e75
Merge pull request #4017 from hashicorp/b-vars-refresh
...
core: Validate context after input of vars on refresh
2015-11-23 16:19:36 +02:00
Paul Hinze
fd2c62b3c7
Update CHANGELOG.md
2015-11-23 08:19:23 -06:00
Paul Hinze
3afe350c28
Merge pull request #4002 from hashicorp/phinze/skip-statefunc-for-nils
...
helper/schema: skip StateFunc when value is nil
2015-11-23 08:12:13 -06:00
James Nugent
1f5de8ee43
Update CHANGELOG.md
2015-11-23 15:10:38 +02:00
James Nugent
1fa44b4796
Merge pull request #4020 from stack72/f-aws-elasticache-cluster-maintenance-window
...
provider/aws:Elasticache maintenance_window forces lowercase
2015-11-23 15:02:21 +02:00
stack72
150e997a96
Changing the AWS ElastiCache cluster maintenance_window to enforce lowercase
2015-11-23 12:54:56 +00:00
James Nugent
b4725d4fa3
Merge pull request #4018 from hashicorp/f-ignore-test-files
...
Ignore .test files generated by some editors
2015-11-23 12:42:40 +02:00
James Nugent
0375c5a4ab
Ignore .test files generated by some editors
...
Seems like Emacs is generating .test files when saving _test.go files -
we don't need these in the repo.
2015-11-23 10:40:38 +02:00
James Nugent
50b5e7c1a5
Validate context after input of vars on refresh
...
Fixes #4013 .
2015-11-23 10:33:40 +02:00
James Nugent
890e214c00
Add failing test replicating #4013
2015-11-23 10:32:46 +02:00
Radek Simko
ddc98d7733
Update CHANGELOG.md
2015-11-23 08:00:49 +00:00
Radek Simko
749fcd4931
Merge pull request #4010 from pforman/cloudtrail-enable
...
provider/aws: Add "enable_logging" to CloudTrail resource
2015-11-23 07:59:29 +00:00
Paul Forman
52aad04930
Mistake in type refactor in cloudTrailGetLoggingStatus
...
When adjusting the types to prevent casting, I didn't change the error
message to handle the pointer change. "go tool vet" caught this.
2015-11-22 13:23:08 -07:00
Paul Forman
9cec40ea3c
Add missing error-checks from code review
...
Some error-checking was omitted.
Specifically, the cloudTrailSetLogging call in the Create function was
ignoring the return and cloudTrailGetLoggingStatus could crash on a
nil-dereference during the return. Fixed both.
Fixed some needless casting in cloudTrailGetLoggingStatus.
Clarified error message in acceptance tests.
Removed needless option from example in docs.
2015-11-22 12:54:11 -07:00
Paul Forman
484887c0c5
Change default for logging in CloudTrail to true
...
The default for `enable_logging`, which defines whether CloudTrail
actually logs events was originally written as defaulting to `false`,
since that's how AWS creates trails.
`true` is likely a better default for Terraform users.
Changed the default and updated the docs.
Changed the acceptance tests to verify new default behavior.
2015-11-22 10:47:23 -07:00
James Nugent
774ed1ded8
Merge pull request #4012 from rakutentech/rename-function
...
provider/vsphere: Rename create* functions
2015-11-22 11:34:42 +02:00
Paul Forman
c9eeb161e0
Add a comment in tests
...
The purpose of the first test of enable_logging wasn't quite clear.
It's future-proofing against the assumptions made about AWS behavior.
2015-11-21 14:55:08 -07:00
Martin Atkins
11190144f0
AWS Opsworks tests bring their own IAM objects.
...
Previously we assumed the existence of some default objects that most
Opsworks users have because the Opsworks console creates them by default
when a new stack is created.
However, that meant that these tests wouldn't work correctly for anyone
who either had never used Opsworks via the UI or who had never accepted
the default of having the console create some predefined IAM objects to
use. It may also have led to some weird failures if a particular user had
customized the settings for these default objects.
Now the tests create suitable IAM roles, a policy and an instance profile
and use these when creating Opsworks stacks, avoiding any dependency
on any pre-existing objects.
This fixes #3998 .
2015-11-21 11:13:25 -08:00
Paul Forman
f98dbbb580
Tests and docs for AWS CloudTrail "enable_logging"
...
Add acceptance tests for creation, enable, and disable logging.
Add option to docs and example.
2015-11-21 00:18:38 -07:00
Paul Forman
52db098292
Add enable_logging to AWS CloudTrail
...
The AWS CloudTrail resource is capable of creating CloudTrail resources,
but AWS defaults the actual logging of the trails to `false`, and
Terraform has no method to enable or monitor the status of logging.
CloudTrail trails that are inactive aren't very useful, and it's a
surprise to discover they aren't logging on creation.
Added an `enable_logging` parameter to resource_aws_cloudtrail to enable
logging. This requires some extra API calls, which are wrapped in new
internal functions.
For compatibility with AWS, the default of `enable_logging` is set to
`false`.
2015-11-21 00:18:38 -07:00
clint shryock
233aab6e0a
provider/aws: Fix issue deleting users who are attached to a group
...
If you want to delete an IAM user, that user must not belong to any groups
2015-11-20 16:54:26 -06:00
Clint
cf87ede5dd
Update CHANGELOG.md
2015-11-20 14:50:41 -06:00
Clint
cc70d25dc5
Merge pull request #3898 from hashicorp/b-aws-elb-iam-cert-delete
...
providers/aws: Retry deleting IAM Server Cert on dependency violation
2015-11-20 14:50:18 -06:00
Clint
f26be08091
Update CHANGELOG.md
2015-11-20 14:49:24 -06:00
Clint
9edbf6a7fc
Merge pull request #3908 from hashicorp/b-elb-cookie-fix
...
provider/aws: Fix issue with LB Cookie Stickiness and empty expiration period
2015-11-20 14:49:00 -06:00
Paul Hinze
c7dc1c10a3
helper/schema: skip StateFunc when value is nil
...
This takes the nil checking burden off of StateFunc.
fixes #3586 , see that issue for further discussion
2015-11-20 14:07:18 -06:00
Paul Hinze
5ec446718a
Merge pull request #4000 from hashicorp/phinze/keys-for-schema-test-cases
...
helper/schema: name test cases w/ strings
2015-11-20 14:06:37 -06:00
Paul Hinze
938281024f
helper/schema: name test cases w/ strings
...
I promised myself that next time I jumped in this file I'd fix this up.
Now we don't have to manually index the file with comments, we can just
add descriptive names to the test cases!
2015-11-20 13:51:34 -06:00
Clint
ed3399593a
Merge pull request #3996 from hashicorp/b-aws-test-fixes
...
Adjustments for AWS Acceptance tests
2015-11-20 13:28:25 -06:00
clint shryock
9eb46c28b2
use a log group resourcE
2015-11-20 13:15:20 -06:00
clint shryock
cf5b32617b
fix vpn gateway refresh/reattach issue
2015-11-20 11:47:10 -06:00
stack72
74c93d3a46
Reording the code for the creation of a Floating IP for a droplet. The call to the DO api takes a few seconds to propagate so I had to sacriface some kittens and added a short 10 second sleep
2015-11-20 19:12:31 +02:00
stack72
7bda855590
Adding the work to assign a Floating IP to a Droplet
2015-11-20 19:12:31 +02:00
stack72
9cf1c2943c
Adding the first pass of the work to get a floatingip assigned to a region
2015-11-20 19:12:30 +02:00
Paul Hinze
24d15820c1
provider/heroku: fix acc test
...
depends_on requires a list of strings. the old parser would silently
ignore this field, but the new one returned a syntax error.
2015-11-20 10:51:34 -06:00
Paul Hinze
c637ca039c
Merge pull request #3987 from hashicorp/b-aws-test-fixes
...
AWS Test fixtures updates
2015-11-20 10:36:38 -06:00
Paul Hinze
2f25d57e7c
Merge pull request #3993 from lwander/b-gcp-test-ssl-cert
...
provider/google: self-signed ssl certs for testing
2015-11-20 10:36:27 -06:00
Lars Wander
93ff7edb13
provider/google: self-signed ssl certs for testing
2015-11-20 11:32:25 -05:00
Paul Hinze
e67551a641
provider/docker: fix image test
...
there's a new latest in town
2015-11-20 09:58:03 -06:00
Paul Hinze
e9a18a8f9f
provider/google: fix sql database test
...
Was missing a required parameter
/cc @lwander @sparkprime
2015-11-20 09:52:23 -06:00
clint shryock
73475edceb
update TestAccAWSFlowLog_subnet to use new cloudwatch resource, not needing env var anymore
2015-11-20 09:39:43 -06:00
clint shryock
fe204bb291
error test when env var is not supplied
2015-11-20 09:39:17 -06:00
clint shryock
4d0699b9dd
mark snapshots as computed for ElastiCache clusters
2015-11-20 09:39:17 -06:00
Takaaki Furukawa
cb84b98ce4
provider/vsphere: Rename functions
2015-11-20 21:01:02 +09:00
Paul Hinze
887839ce23
provider/digitalocean: remove relative CNAME test
...
Heard back from DO support:
> we require it to be a FQDN for a CNAME record in our DNS system.
/cc @paystee, the original author here
2015-11-19 18:36:58 -06:00
Paul Hinze
3d089143c6
provider/azure: fix hosted service acctest
...
Just some basic bitrot stuff.
2015-11-19 16:28:24 -06:00
clint shryock
325fd751eb
update TestAccAWSFlowLog_subnet to use new cloudwatch resource, not needing env var anymore
2015-11-19 16:27:56 -06:00
clint shryock
e91381c4e2
error test when env var is not supplied
2015-11-19 16:24:17 -06:00
clint shryock
0aedb7eae6
mark snapshots as computed for ElastiCache clusters
2015-11-19 16:19:53 -06:00
Paul Hinze
75d056c878
provider/digitalocean: comment out test for relative DNS records
...
Until we hear back from DigitalOcean on whether this behavior is
supposed to be supported or not.
2015-11-19 16:11:42 -06:00
