Mitchell Hashimoto
0bc0c03fec
helper/schema: zero value set should set function [GH-1009]
2015-02-19 11:26:02 -08:00
Mitchell Hashimoto
9b8b38cbb1
helper/schema: test that set can be nil
2015-02-18 14:59:55 -08:00
Mitchell Hashimoto
e4f0f6b15d
helper/schema: more tests
2015-02-18 14:44:46 -08:00
Mitchell Hashimoto
dd00001c9a
helper/schema: tests that all pass as I was trying to track down a bug
2015-02-18 14:10:12 -08:00
Mitchell Hashimoto
17680bb7ff
helper/schema: some more test cases, revert some weird behavior from
...
dbfb95fcd5
2015-02-18 12:54:46 -08:00
Mitchell Hashimoto
659a77c6ae
helper/schema: validate subresources more effectively
2015-02-18 09:41:55 -08:00
Mitchell Hashimoto
fa7f496bef
helper/schema: zero value of a set should be empty
2015-02-17 16:58:47 -08:00
Mitchell Hashimoto
7d32c8946a
helper/schema: GetOk now only returns true if set to non-zero value
2015-02-17 16:55:39 -08:00
Mitchell Hashimoto
e04def93e6
Merge pull request #991 from hashicorp/b-autoscale-lc-update
...
providers/aws: allow in-place update of launch configuration
2015-02-17 16:29:56 -08:00
Mitchell Hashimoto
faec39b8c1
Merge pull request #990 from hashicorp/b-set-change
...
helper/schema: GetChange shouldn't return true when no change
2015-02-17 16:17:44 -08:00
Mitchell Hashimoto
5a64d0900b
providers/aws: test for allowing in-place lC update
2015-02-17 16:12:02 -08:00
Mitchell Hashimoto
66f7731995
helper/schema: GetChange shouldn't return true when no change
2015-02-17 15:43:19 -08:00
Mitchell Hashimoto
5c06cc386a
helper/schema: empty map values should show up in diff [GH-968]
2015-02-17 15:22:45 -08:00
Mitchell Hashimoto
e9778c85a5
helper/schema: clarify test
2015-02-17 14:46:24 -08:00
Mitchell Hashimoto
dbfb95fcd5
helper/schema: show in diff when no config is going to empty set
2015-02-17 14:45:18 -08:00
Mitchell Hashimoto
fd274d7328
helper/schema: update test desc
2015-02-17 13:17:23 -08:00
Mitchell Hashimoto
bcdec738d4
helper/schema: default the new value to zero only for the decode
2015-02-17 13:16:59 -08:00
Mitchell Hashimoto
ad6be99f5b
helper/schema: failing test
2015-02-17 13:15:30 -08:00
Mitchell Hashimoto
2ee2b9e26f
Merge pull request #986 from hashicorp/b-remove-set
...
helper/schema: Diff with set going to 0 elements removes it from state
2015-02-17 11:50:50 -08:00
Mitchell Hashimoto
2212d6895d
helper/schema: diff with set going to 0 elements removes it from state
2015-02-17 11:38:56 -08:00
Mitchell Hashimoto
c22ba7d3a8
helper/schema: fix test index
2015-02-17 11:14:04 -08:00
Mitchell Hashimoto
cbcfb26ec6
helper/schema: add test for sets
2015-02-17 11:12:45 -08:00
Mitchell Hashimoto
b778a65a83
helper/schema: diff of zero value in state with lack of value should not
...
diff
2015-02-17 11:10:45 -08:00
Mitchell Hashimoto
61215d8826
Merge pull request #919 from ceh/url-helper
...
helper/url: add "Windows-safe" URL Parse wrapper
2015-02-17 09:26:55 -08:00
Clint Shryock
4c7b732dad
typo
2015-02-11 14:49:50 -08:00
Clint Shryock
5602348695
formatting, cleanups
2015-02-11 11:40:49 -08:00
Clint Shryock
a5040ecc03
Update hashcode to always generate a positive
2015-02-11 10:59:21 -08:00
Emil Hessman
e7bbbfb098
helper/url: add Windows 'safe' URL Parse wrapper
...
Pull out the urlParse function, which was introduced in config/module,
into a helper package.
2015-02-05 11:16:54 +01:00
Paul Hinze
26156981d7
Merge pull request #917 from methane/fix-stringer
...
Fix stringer error on helper/schema/schema.go
2015-02-04 10:09:53 -06:00
Paul Hinze
4e8e3dad86
DiffFieldReader: filter all '#' fields from sets
...
Now that readMap filters out '#' fields, when maps are nested in sets,
we exposed a related bug where a set was iterating over nested maps and
expected the '#' key to be present in those nested maps.
By skipping _all_ count fields when iterating over set keys, all is
right with the world again.
2015-02-04 09:25:45 -06:00
Paul Hinze
219aa3e788
helper/schema: fix DiffFieldReader map handling
...
An `InstanceDiff` will include `ResourceAttrDiff` entries for the
"length" / `#` field of maps. This makes sense, since for something like
`terraform plan` it's useful to see when counts are changing.
The `DiffFieldReader` was not taking these entries into account when
reading maps out, and was therefore incorrectly returning maps that
included an extra `'#'` field, which was causing all sorts of havoc
for providers (extra tags on AWS instances, broken google compute
instance launch, possibly others).
* fixes #914 - extra tags on AWS instances
* fixes #883 - general core issue sprouted from #757
* removes the hack+TODO from #757
2015-02-03 20:17:57 -06:00
INADA Naoki
f6367a779a
regenerate with new stringer.
2015-02-04 01:54:14 +09:00
INADA Naoki
33aa9d3ee8
Fix stringer error on helper/schema/schema.go
2015-02-03 19:33:01 +09:00
Dave Cunningham
aa2015ccd0
Fix failing tests
2015-01-28 16:20:14 -05:00
Dave Cunningham
3cbf1a3230
Fix missing import of math
2015-01-28 15:39:32 -05:00
Dave Cunningham
319933f551
Add some tests for TypeFloat
2015-01-28 15:22:47 -05:00
Dave Cunningham
18c26cb2eb
Add some missing Float cases
2015-01-28 12:53:34 -05:00
Paul Hinze
5d4e69cc80
helper/schema: apply schema defaults at the field level when reading from config
...
We were waiting until the higher-level (m schemaMap) diffString method
to apply defaults, which was messing with set hashcode evaluation for
cases when a field with a default is included in the hash function.
fixes #824
2015-01-27 18:18:57 -06:00
Seth Vargo
0a7dea5532
Improve readability and purpose of multi-env default test
2015-01-22 16:09:25 -05:00
Seth Vargo
072a1cf353
Read the "standard" AWS environment variables
...
This is 100% backwards-compatible
2015-01-22 16:09:25 -05:00
Mitchell Hashimoto
466a54cfe4
Merge pull request #766 from hashicorp/f-exists-api
...
helper/schema: Exists API
2015-01-16 10:56:25 -08:00
Mitchell Hashimoto
41029f8daa
helper/schema: tests for EnvDefaultFunc
...
/cc @jefferai - In case you care
2015-01-16 10:54:43 -08:00
Mitchell Hashimoto
b3e77ef244
Merge pull request #825 from jefferai/envdefault
...
Move duplicated envDefaultFunc out of each provider and into Schema.
2015-01-16 10:50:43 -08:00
Mitchell Hashimoto
87948b68fc
helper/schema: use interface for equality check
...
/cc @svanharmelen
2015-01-16 09:32:15 -08:00
Jeff Mitchell
f2bd1f45ab
Move duplicated envDefaultFunc out of each provider and into Schema.
2015-01-16 17:25:39 +00:00
Mitchell Hashimoto
8cba4a40f5
Merge pull request #821 from svanharmelen/b-core-haschange-getchange
...
core: fixing two related bugs in HasChange and GetChange
2015-01-16 09:10:06 -08:00
Mitchell Hashimoto
e32cd396ad
helper/schema: add test for GH-814
2015-01-16 08:37:25 -08:00
Sander van Harmelen
c7550595a3
Fixing two related bugs in HasChange and GetChange
...
This was actually quite nasty as the first bug covered the second one…
The first bug is with HasChange. This function uses reflect.DeepEqual
to check if two instances are the same/have the same content. This
works fine for all types except for Set’s as they contain a function.
And reflect.DeepEqual will only say the functions are equal if they are
both nil (which they aren’t in a Set). So in effect it means that
currently HasChange will always say true for Set’s, even when they are
actually being equal.
As soon as you fix this problem, you will notice the second one (which
the added test is written for). Without saying you want the exact diff,
you will end up with a merged value which will (in most cases) be the
same.
Run all unit tests and a good part of the acc tests to verify this
works as expected and all look good.
2015-01-16 14:13:40 +01:00
Sander van Harmelen
2edfd0e89d
Just my OCD playing up 😉
2015-01-16 13:30:11 +01:00
Greg Osuri
2769d7cf9c
Fixes #813 : Ensuring set count (.#) is written to the state
2015-01-16 03:43:57 -08:00
