Commit Graph

8 Commits

Author SHA1 Message Date
James Bardin
ff2936bb3f Fix cancellation when spawning a subprocess
If the shell spawns a subprocess which doesn't close the output file
descriptors, the exec.Cmd will block on Wait() (see
golang.org/issue/18874). Use an os.Pipe to provide the command with a
real file descriptor so the exec package doesn't need to do the copy
manually. This in turn may block our own reading goroutine, but we can
select on that and leave it for cleanup later.
2017-02-01 12:01:29 -05:00
Mitchell Hashimoto
0fb87cd96b
provisioners/local-exec: stoppable
This modifies local-exec to be stoppable with the new Stop API call that
provisioners can listen to.
2017-01-26 15:03:28 -08:00
Mitchell Hashimoto
c5b784c33f
provisioners/local-exec: switch to helper/schema 2017-01-26 15:03:28 -08:00
Mitchell Hashimoto
e5868ebdd9 provisioners/*: new interface 2014-10-04 16:29:33 -07:00
Mitchell Hashimoto
8720d2465e builtin/provisioners/*: new API 2014-07-22 10:38:39 -07:00
Mitchell Hashimoto
01b58669b0 provisioners/local-exec: tests pass on Windows due to line-endings diff
/cc @armon
2014-07-10 13:09:09 -07:00
Armon Dadgar
7721caf867 provisioner/local-exec: Adding tests for Apply and Validate 2014-07-10 11:38:57 -07:00
Armon Dadgar
9c49642b37 provisioner/local-exec: First pass 2014-07-10 11:38:56 -07:00