mirror of
https://github.com/opentofu/opentofu.git
synced 2024-12-30 10:47:14 -06:00
b807505d55
Currently, the refresh graph uses the resources from state as a base, with data sources then layered on. Config is not consulted for resources and hence new resources that are added with count (or any new resource from config, for that matter) do not get added to the graph during refresh. This is leading to issues with scale in and scale out when the same value for count is used in both resources, and data sources that may depend on that resource (and possibly vice versa). While the resources exist in config and can be used, the fact that ConfigTransformer for resources is missing means that they don't get added into the graph, leading to "index out of range" errors and what not. Further to that, if we add these new resources to the graph for scale out, considerations need to be taken for scale in as well, which are not being caught 100% by the current implementation of NodeRefreshableDataResource. Scale-in resources should be treated as orphans, which according to the instance-form NodeRefreshableResource node, should be NodeDestroyableDataResource nodes, but this this logic is currently not rolled into NodeRefreshableDataResource. This causes issues on scale-in in the form of race-ish "index out of range" errors again. This commit updates the refresh graph so that StateTransformer is no longer used as the base of the graph. Instead, we add resources from the state and config in a hybrid fashion: * First off, resource nodes are added from config, but only if resources currently exist in state. NodeRefreshableManagedResource is a new expandable resource node that will expand count and add orphans from state. Any count-expanded node that has config but no state is also transformed into a plannable resource, via a new ResourceRefreshPlannableTransformer. * The NodeRefreshableDataResource node type will now add count orphans as NodeDestroyableDataResource nodes. This achieves the same effect as if the data sources were added by StateTransformer, but ensures there are no races in the dependency chain, with the added benefit of directing these nodes straight to the proper NodeDestroyableDataResource node. * Finally, config orphans (nodes that don't exist in config anymore period) are then added, to complete the graph. This should ensure as much as possible that there is a refresh graph that best represents both the current state and config with updated variables and counts.
56 lines
1.7 KiB
Go
56 lines
1.7 KiB
Go
package terraform
|
|
|
|
import (
|
|
"fmt"
|
|
"log"
|
|
)
|
|
|
|
// ResourceRefreshPlannableTransformer is a GraphTransformer that replaces any
|
|
// nodes that don't have state yet exist in config with
|
|
// NodePlannableResourceInstance.
|
|
//
|
|
// This transformer is used when expanding count on managed resource nodes
|
|
// during the refresh phase to ensure that data sources that have
|
|
// interpolations that depend on resources existing in the graph can be walked
|
|
// properly.
|
|
type ResourceRefreshPlannableTransformer struct {
|
|
// The full global state.
|
|
State *State
|
|
}
|
|
|
|
// Transform implements GraphTransformer for
|
|
// ResourceRefreshPlannableTransformer.
|
|
func (t *ResourceRefreshPlannableTransformer) Transform(g *Graph) error {
|
|
nextVertex:
|
|
for _, v := range g.Vertices() {
|
|
addr := v.(*NodeRefreshableManagedResourceInstance).Addr
|
|
|
|
// Find the state for this address, if there is one
|
|
filter := &StateFilter{State: t.State}
|
|
results, err := filter.Filter(addr.String())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Check to see if we have a state for this resource. If we do, skip this
|
|
// node.
|
|
for _, result := range results {
|
|
if _, ok := result.Value.(*ResourceState); ok {
|
|
continue nextVertex
|
|
}
|
|
}
|
|
// If we don't, convert this resource to a NodePlannableResourceInstance node
|
|
// with all of the data we need to make it happen.
|
|
log.Printf("[TRACE] No state for %s, converting to NodePlannableResourceInstance", addr.String())
|
|
new := &NodePlannableResourceInstance{
|
|
NodeAbstractResource: v.(*NodeRefreshableManagedResourceInstance).NodeAbstractResource,
|
|
}
|
|
// Replace the node in the graph
|
|
if !g.Replace(v, new) {
|
|
return fmt.Errorf("ResourceRefreshPlannableTransformer: Could not replace node %#v with %#v", v, new)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|