mirror of
https://github.com/opentofu/opentofu.git
synced 2025-01-01 11:47:07 -06:00
8fabcc0c08
The logic under test has intentionally changed here so that setting count to any value -- even 1 -- causes Terraform to prefer to keep indexed instances if both non-indexed and indexed are present. Previously Terraform treated count = 1 as equivalent to count not set at all, but we now recognize these as two different situations and treat count = 1 as the same as any other non-zero count, to ensure that if count is set conditionally it'll always produce indexed instances, even if the dynamic expression ends up evaluating to 1.
138 lines
3.9 KiB
Go
138 lines
3.9 KiB
Go
package terraform
|
|
|
|
import (
|
|
"log"
|
|
|
|
"github.com/hashicorp/terraform/addrs"
|
|
"github.com/hashicorp/terraform/dag"
|
|
)
|
|
|
|
// OrphanResourceCountTransformer is a GraphTransformer that adds orphans
|
|
// for an expanded count to the graph. The determination of this depends
|
|
// on the count argument given.
|
|
//
|
|
// Orphans are found by comparing the count to what is found in the state.
|
|
// This transform assumes that if an element in the state is within the count
|
|
// bounds given, that it is not an orphan.
|
|
type OrphanResourceCountTransformer struct {
|
|
Concrete ConcreteResourceInstanceNodeFunc
|
|
|
|
Count int // Actual count of the resource, or -1 if count is not set at all
|
|
Addr addrs.AbsResource // Addr of the resource to look for orphans
|
|
State *State // Full global state
|
|
}
|
|
|
|
func (t *OrphanResourceCountTransformer) Transform(g *Graph) error {
|
|
|
|
// Grab the module in the state just for this resource address
|
|
ms := t.State.ModuleByPath(t.Addr.Module)
|
|
if ms == nil {
|
|
// If no state, there can't be orphans
|
|
return nil
|
|
}
|
|
|
|
haveKeys := make(map[addrs.InstanceKey]struct{})
|
|
for legacyAddrStr := range ms.Resources {
|
|
legacyAddr, err := parseResourceAddressInternal(legacyAddrStr)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
legacyAddr.Path = ms.Path[1:]
|
|
addr := legacyAddr.AbsResourceInstanceAddr()
|
|
|
|
if addr.ContainingResource().String() != t.Addr.String() {
|
|
// Not one of our instances
|
|
continue
|
|
}
|
|
|
|
haveKeys[addr.Resource.Key] = struct{}{}
|
|
}
|
|
|
|
if t.Count < 0 {
|
|
return t.transformNoCount(haveKeys, g)
|
|
}
|
|
if t.Count == 0 {
|
|
return t.transformZeroCount(haveKeys, g)
|
|
}
|
|
return t.transformCount(haveKeys, g)
|
|
}
|
|
|
|
func (t *OrphanResourceCountTransformer) transformCount(haveKeys map[addrs.InstanceKey]struct{}, g *Graph) error {
|
|
// Due to the logic in Transform, we only get in here if our count is
|
|
// at least one.
|
|
|
|
_, have0Key := haveKeys[addrs.IntKey(0)]
|
|
|
|
for key := range haveKeys {
|
|
if key == addrs.NoKey && !have0Key {
|
|
// If we have no 0-key then we will accept a no-key instance
|
|
// as an alias for it.
|
|
continue
|
|
}
|
|
|
|
i, isInt := key.(addrs.IntKey)
|
|
if isInt && int(i) < t.Count {
|
|
continue
|
|
}
|
|
|
|
abstract := NewNodeAbstractResourceInstance(t.Addr.Instance(key))
|
|
var node dag.Vertex = abstract
|
|
if f := t.Concrete; f != nil {
|
|
node = f(abstract)
|
|
}
|
|
log.Printf("[TRACE] OrphanResourceCount(non-zero): adding %s as %T", t.Addr, node)
|
|
g.Add(node)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (t *OrphanResourceCountTransformer) transformZeroCount(haveKeys map[addrs.InstanceKey]struct{}, g *Graph) error {
|
|
// This case is easy: we need to orphan any keys we have at all.
|
|
|
|
for key := range haveKeys {
|
|
abstract := NewNodeAbstractResourceInstance(t.Addr.Instance(key))
|
|
var node dag.Vertex = abstract
|
|
if f := t.Concrete; f != nil {
|
|
node = f(abstract)
|
|
}
|
|
log.Printf("[TRACE] OrphanResourceCount(zero): adding %s as %T", t.Addr, node)
|
|
g.Add(node)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (t *OrphanResourceCountTransformer) transformNoCount(haveKeys map[addrs.InstanceKey]struct{}, g *Graph) error {
|
|
// Negative count indicates that count is not set at all, in which
|
|
// case we expect to have a single instance with no key set at all.
|
|
// However, we'll also accept an instance with key 0 set as an alias
|
|
// for it, in case the user has just deleted the "count" argument and
|
|
// so wants to keep the first instance in the set.
|
|
|
|
_, haveNoKey := haveKeys[addrs.NoKey]
|
|
_, have0Key := haveKeys[addrs.IntKey(0)]
|
|
keepKey := addrs.NoKey
|
|
if have0Key && !haveNoKey {
|
|
// If we don't have a no-key instance then we can use the 0-key instance
|
|
// instead.
|
|
keepKey = addrs.IntKey(0)
|
|
}
|
|
|
|
for key := range haveKeys {
|
|
if key == keepKey {
|
|
continue
|
|
}
|
|
|
|
abstract := NewNodeAbstractResourceInstance(t.Addr.Instance(key))
|
|
var node dag.Vertex = abstract
|
|
if f := t.Concrete; f != nil {
|
|
node = f(abstract)
|
|
}
|
|
log.Printf("[TRACE] OrphanResourceCount(no-count): adding %s as %T", t.Addr, node)
|
|
g.Add(node)
|
|
}
|
|
|
|
return nil
|
|
}
|