mirror of
https://github.com/opentofu/opentofu.git
synced 2025-01-20 21:52:57 -06:00
4bc1696fd1
The graph walking mechanism is specified as requiring a graph with a single root, which in practice means there's exactly one node in the graph which doesn't have any dependencies. However, we previously weren't verifying that invariant is true for subgraphs returned from DynamicExpand. It was working anyway, but it's not ideal to be relying on a behavior that isn't guaranteed by our underlying infrastructure. We also previously had the RootTransformer being a bit clever and trying to avoid adding a new node if there is already only a single graph with no dependencies. That special case isn't particularly valuable since there's no harm in turning a one-node graph into a two-node graph with an explicit separate root node, and doing that allows us to assume that the root node is always present and is always exactly terraform.rootNode. Many existing DynamicExpand implementations were not producing valid graphs and were previously getting away with it. All of them now produce properly-rooted graphs that should pass validation, and we will guarantee that with an explicit check of the DynamicExpand return value before we try to walk that subgraph. For good measure we also verify that the root node is exactly terraform.rootNode, even though that isn't strictly required by our graph walker, just to help us catch potential future bugs where a DynamicExpand implementation neglects to add our singleton root node. |
||
|---|---|---|
| .. | ||
| addrs | ||
| backend | ||
| builtin | ||
| checks | ||
| cloud | ||
| command | ||
| communicator | ||
| configs | ||
| copy | ||
| dag | ||
| depsfile | ||
| didyoumean | ||
| e2e | ||
| earlyconfig | ||
| experiments | ||
| getmodules | ||
| getproviders | ||
| grpcwrap | ||
| helper/slowmessage | ||
| httpclient | ||
| initwd | ||
| instances | ||
| ipaddr | ||
| lang | ||
| legacy | ||
| logging | ||
| modsdir | ||
| moduledeps | ||
| moduletest | ||
| plans | ||
| plugin | ||
| plugin6 | ||
| provider-simple | ||
| provider-simple-v6 | ||
| provider-terraform/main | ||
| providercache | ||
| providers | ||
| provisioner-local-exec/main | ||
| provisioners | ||
| refactoring | ||
| registry | ||
| repl | ||
| replacefile | ||
| states | ||
| terminal | ||
| terraform | ||
| tfdiags | ||
| tfplugin5 | ||
| tfplugin6 | ||