mirror of
https://github.com/opentofu/opentofu.git
synced 2025-01-08 15:13:56 -06:00
069425a700
Implementation notes: * The hash implementation was not considering key value, causing "diffs did not match" errors when a value was updated. Switching to default HashResource implementation fixes this * Using HashResource as a default exposed a bug in helper/schema that needed to be fixed so the Set function is picked up properly during Read * Stop writing back values into the `key` attribute; it triggers extra diffs when `default` is used. Computed values all just go into `var`. * Includes a state migration to prevent unnecessary diffs based on "key" attribute hashcodes changing. In the tests: * Switch from leaning on the public demo Consul instance to requiring a CONSUL_HTTP_ADDR variable be set pointing to a `consul agent -dev` instance to be used only for testing. * Add a test that exposes the updating issues and covers the fixes Fixes #774 Fixes #1866 Fixes #3023
91 lines
2.1 KiB
Go
91 lines
2.1 KiB
Go
package consul
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/hashicorp/terraform/terraform"
|
|
)
|
|
|
|
func TestConsulKeysMigrateState(t *testing.T) {
|
|
cases := map[string]struct {
|
|
StateVersion int
|
|
Attributes map[string]string
|
|
Expected map[string]string
|
|
Meta interface{}
|
|
}{
|
|
"v0.6.9 and earlier, with old values hash function": {
|
|
StateVersion: 0,
|
|
Attributes: map[string]string{
|
|
"key.#": "2",
|
|
"key.12345.name": "hello",
|
|
"key.12345.path": "foo/bar",
|
|
"key.12345.value": "world",
|
|
"key.12345.default": "",
|
|
"key.12345.delete": "false",
|
|
"key.6789.name": "temp",
|
|
"key.6789.path": "foo/foo",
|
|
"key.6789.value": "",
|
|
"key.6789.default": "",
|
|
"key.6789.delete": "true",
|
|
},
|
|
Expected: map[string]string{
|
|
"key.#": "2",
|
|
"key.2401383718.default": "",
|
|
"key.2401383718.delete": "true",
|
|
"key.2401383718.name": "temp",
|
|
"key.2401383718.path": "foo/foo",
|
|
"key.2401383718.value": "",
|
|
"key.3116955509.path": "foo/bar",
|
|
"key.3116955509.default": "",
|
|
"key.3116955509.delete": "false",
|
|
"key.3116955509.name": "hello",
|
|
"key.3116955509.value": "world",
|
|
},
|
|
},
|
|
}
|
|
|
|
for tn, tc := range cases {
|
|
is := &terraform.InstanceState{
|
|
ID: "consul",
|
|
Attributes: tc.Attributes,
|
|
}
|
|
is, err := resourceConsulKeys().MigrateState(
|
|
tc.StateVersion, is, tc.Meta)
|
|
|
|
if err != nil {
|
|
t.Fatalf("bad: %s, err: %#v", tn, err)
|
|
}
|
|
|
|
for k, v := range tc.Expected {
|
|
if is.Attributes[k] != v {
|
|
t.Fatalf(
|
|
"bad: %s\n\n expected: %#v -> %#v\n got: %#v -> %#v\n in: %#v",
|
|
tn, k, v, k, is.Attributes[k], is.Attributes)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestConsulKeysMigrateState_empty(t *testing.T) {
|
|
var is *terraform.InstanceState
|
|
var meta interface{}
|
|
|
|
// should handle nil
|
|
is, err := resourceConsulKeys().MigrateState(0, is, meta)
|
|
|
|
if err != nil {
|
|
t.Fatalf("err: %#v", err)
|
|
}
|
|
if is != nil {
|
|
t.Fatalf("expected nil instancestate, got: %#v", is)
|
|
}
|
|
|
|
// should handle non-nil but empty
|
|
is = &terraform.InstanceState{}
|
|
is, err = resourceConsulKeys().MigrateState(0, is, meta)
|
|
|
|
if err != nil {
|
|
t.Fatalf("err: %#v", err)
|
|
}
|
|
}
|