mirror of
https://github.com/opentofu/opentofu.git
synced 2024-12-28 18:01:01 -06:00
f93f7e5b5c
In early versions of Terraform where the interpolation language didn't
have any real list support, list brackets around a single string was the
signal to split the string on a special uuid separator to produce a list
just in time for processing, giving expressions like this:
foo = ["${test_instance.foo.*.id}"]
Logically this is weird because it looks like it should produce a list
of lists of strings. When we added real list support in Terraform 0.7 we
retained support for this behavior by trimming off extra levels of list
during evaluation, and inadvertently continued relying on this notation
for correct type checking.
During the Terraform 0.10 line we fixed the type checker bugs (a few
remaining issues notwithstanding) so that it was finally possible to
use the more intuitive form:
foo = "${test_instance.foo.*.id}"
...but we continued trimming off extra levels of list for backward
compatibility.
Terraform 0.12 finally removes that compatibility shim, causing redundant
list brackets to be interpreted as a list of lists.
This upgrade rule attempts to identify situations that are relying on the
old compatibility behavior and trim off the redundant extra brackets. It's
not possible to do this fully-generally using only static analysis, but
we can gather enough information through or partial type inference
mechanism here to deal with the most common situations automatically and
produce a TF-UPGRADE-TODO comment for more complex scenarios where the
user intent isn't decidable with only static analysis.
In particular, this handles by far the most common situation of wrapping
list brackets around a splat expression like the first example above.
After this and the other upgrade rules are applied, the first example
above will become:
foo = test_instance.foo.*.id
|
||
|---|---|---|
| .. | ||
| configload | ||
| configschema | ||
| configupgrade | ||
| test-fixtures | ||
| backend.go | ||
| compat_shim.go | ||
| config_build_test.go | ||
| config_build.go | ||
| config_test.go | ||
| config.go | ||
| depends_on.go | ||
| doc.go | ||
| module_call_test.go | ||
| module_call.go | ||
| module_merge_body.go | ||
| module_merge_test.go | ||
| module_merge.go | ||
| module.go | ||
| named_values.go | ||
| parser_config_dir_test.go | ||
| parser_config_dir.go | ||
| parser_config_test.go | ||
| parser_config.go | ||
| parser_test.go | ||
| parser_values_test.go | ||
| parser_values.go | ||
| parser.go | ||
| provider_test.go | ||
| provider.go | ||
| provisioner.go | ||
| provisioneronfailure_string.go | ||
| provisionerwhen_string.go | ||
| resource.go | ||
| synth_body_test.go | ||
| synth_body.go | ||
| util.go | ||
| variable_type_hint.go | ||
| variabletypehint_string.go | ||
| version_constraint.go | ||