mirror of
https://github.com/opentofu/opentofu.git
synced 2024-12-25 08:21:07 -06:00
c39905e1a8
In earlier refactoring we updated these commands to support the new address and state types, but attempted to partially retain the old-style "StateFilter" abstraction that originally lived in the Terraform package, even though that was no longer being used for any other functionality. Unfortunately the adaptation of the existing filtering to the new types wasn't exact and so these commands ended up having a few bugs that were not covered by the existing tests. Since the old StateFilter behavior was the source of various misbehavior anyway, here it's removed altogether and replaced with some simpler functions in the state_meta.go file that are tailored to the use-cases of these sub-commands. As well as just generally behaving more consistently with the other parts of Terraform that use the new resource address types, this commit fixes the following bugs: - A resource address of aws_instance.foo would previously match an resource of that type and name in any module, which disagreed with the expected interpretation elsewhere of meaning a single resource in the root module. - The "terraform state mv" command was not supporting moves from a single resource address to an indexed address and vice-versa, because the old logic didn't need to make that distinction while they are two separate address types in the new logic. Now we allow resources that do not have count/for_each to be treated as if they are instances for the purposes of this command, which is a better match for likely user intent and for the old behavior. Finally, we also clean up a little some of the usage output from these commands, which hasn't been updated for some time and so had both some stale information and some inaccurate terminology.
199 lines
6.2 KiB
Go
199 lines
6.2 KiB
Go
package command
|
|
|
|
import (
|
|
"fmt"
|
|
"sort"
|
|
"time"
|
|
|
|
"github.com/hashicorp/terraform/addrs"
|
|
"github.com/hashicorp/terraform/state"
|
|
"github.com/hashicorp/terraform/states"
|
|
"github.com/hashicorp/terraform/states/statemgr"
|
|
"github.com/hashicorp/terraform/tfdiags"
|
|
|
|
backendLocal "github.com/hashicorp/terraform/backend/local"
|
|
)
|
|
|
|
// StateMeta is the meta struct that should be embedded in state subcommands.
|
|
type StateMeta struct {
|
|
Meta
|
|
}
|
|
|
|
// State returns the state for this meta. This gets the appropriate state from
|
|
// the backend, but changes the way that backups are done. This configures
|
|
// backups to be timestamped rather than just the original state path plus a
|
|
// backup path.
|
|
func (c *StateMeta) State() (state.State, error) {
|
|
var realState state.State
|
|
backupPath := c.backupPath
|
|
stateOutPath := c.statePath
|
|
|
|
// use the specified state
|
|
if c.statePath != "" {
|
|
realState = statemgr.NewFilesystem(c.statePath)
|
|
} else {
|
|
// Load the backend
|
|
b, backendDiags := c.Backend(nil)
|
|
if backendDiags.HasErrors() {
|
|
return nil, backendDiags.Err()
|
|
}
|
|
|
|
workspace := c.Workspace()
|
|
// Get the state
|
|
s, err := b.StateMgr(workspace)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Get a local backend
|
|
localRaw, backendDiags := c.Backend(&BackendOpts{ForceLocal: true})
|
|
if backendDiags.HasErrors() {
|
|
// This should never fail
|
|
panic(backendDiags.Err())
|
|
}
|
|
localB := localRaw.(*backendLocal.Local)
|
|
_, stateOutPath, _ = localB.StatePaths(workspace)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
realState = s
|
|
}
|
|
|
|
// We always backup state commands, so set the back if none was specified
|
|
// (the default is "-", but some tests bypass the flag parsing).
|
|
if backupPath == "-" || backupPath == "" {
|
|
// Determine the backup path. stateOutPath is set to the resulting
|
|
// file where state is written (cached in the case of remote state)
|
|
backupPath = fmt.Sprintf(
|
|
"%s.%d%s",
|
|
stateOutPath,
|
|
time.Now().UTC().Unix(),
|
|
DefaultBackupExtension)
|
|
}
|
|
|
|
// If the backend is local (which it should always be, given our asserting
|
|
// of it above) we can now enable backups for it.
|
|
if lb, ok := realState.(*statemgr.Filesystem); ok {
|
|
lb.SetBackupPath(backupPath)
|
|
}
|
|
|
|
return realState, nil
|
|
}
|
|
|
|
func (c *StateMeta) lookupResourceInstanceAddr(state *states.State, allowMissing bool, addrStr string) ([]addrs.AbsResourceInstance, tfdiags.Diagnostics) {
|
|
target, diags := addrs.ParseTargetStr(addrStr)
|
|
if diags.HasErrors() {
|
|
return nil, diags
|
|
}
|
|
|
|
targetAddr := target.Subject
|
|
var ret []addrs.AbsResourceInstance
|
|
switch addr := targetAddr.(type) {
|
|
case addrs.ModuleInstance:
|
|
// Matches all instances within the indicated module and all of its
|
|
// descendent modules.
|
|
ms := state.Module(addr)
|
|
if ms == nil {
|
|
if !allowMissing {
|
|
diags = diags.Append(tfdiags.Sourceless(
|
|
tfdiags.Error,
|
|
"Unknown module",
|
|
fmt.Sprintf(`The current state contains no module at %s. If you've just added this module to the configuration, you must run "terraform apply" first to create the module's entry in the state.`, addr),
|
|
))
|
|
}
|
|
break
|
|
}
|
|
ret = append(ret, c.collectModuleResourceInstances(ms)...)
|
|
for _, cms := range state.Modules {
|
|
candidateAddr := ms.Addr
|
|
if len(candidateAddr) > len(addr) && candidateAddr[:len(addr)].Equal(addr) {
|
|
ret = append(ret, c.collectModuleResourceInstances(cms)...)
|
|
}
|
|
}
|
|
case addrs.AbsResource:
|
|
// Matches all instances of the specific selected resource.
|
|
rs := state.Resource(addr)
|
|
if rs == nil {
|
|
if !allowMissing {
|
|
diags = diags.Append(tfdiags.Sourceless(
|
|
tfdiags.Error,
|
|
"Unknown resource",
|
|
fmt.Sprintf(`The current state contains no resource %s. If you've just added this resource to the configuration, you must run "terraform apply" first to create the resource's entry in the state.`, addr),
|
|
))
|
|
}
|
|
break
|
|
}
|
|
ret = append(ret, c.collectResourceInstances(addr.Module, rs)...)
|
|
case addrs.AbsResourceInstance:
|
|
is := state.ResourceInstance(addr)
|
|
if is == nil {
|
|
if !allowMissing {
|
|
diags = diags.Append(tfdiags.Sourceless(
|
|
tfdiags.Error,
|
|
"Unknown resource instance",
|
|
fmt.Sprintf(`The current state contains no resource instance %s. If you've just added its resource to the configuration or have changed the count or for_each arguments, you must run "terraform apply" first to update the resource's entry in the state.`, addr),
|
|
))
|
|
}
|
|
break
|
|
}
|
|
ret = append(ret, addr)
|
|
}
|
|
sort.Slice(ret, func(i, j int) bool {
|
|
return ret[i].Less(ret[j])
|
|
})
|
|
|
|
return ret, diags
|
|
}
|
|
|
|
func (c *StateMeta) lookupSingleResourceInstanceAddr(state *states.State, addrStr string) (addrs.AbsResourceInstance, tfdiags.Diagnostics) {
|
|
return addrs.ParseAbsResourceInstanceStr(addrStr)
|
|
}
|
|
|
|
func (c *StateMeta) lookupSingleStateObjectAddr(state *states.State, addrStr string) (addrs.Targetable, tfdiags.Diagnostics) {
|
|
target, diags := addrs.ParseTargetStr(addrStr)
|
|
if diags.HasErrors() {
|
|
return nil, diags
|
|
}
|
|
return target.Subject, diags
|
|
}
|
|
|
|
func (c *StateMeta) lookupResourceInstanceAddrs(state *states.State, addrStrs ...string) ([]addrs.AbsResourceInstance, tfdiags.Diagnostics) {
|
|
var ret []addrs.AbsResourceInstance
|
|
var diags tfdiags.Diagnostics
|
|
for _, addrStr := range addrStrs {
|
|
moreAddrs, moreDiags := c.lookupResourceInstanceAddr(state, false, addrStr)
|
|
ret = append(ret, moreAddrs...)
|
|
diags = diags.Append(moreDiags)
|
|
}
|
|
return ret, diags
|
|
}
|
|
|
|
func (c *StateMeta) lookupAllResourceInstanceAddrs(state *states.State) ([]addrs.AbsResourceInstance, tfdiags.Diagnostics) {
|
|
var ret []addrs.AbsResourceInstance
|
|
var diags tfdiags.Diagnostics
|
|
for _, ms := range state.Modules {
|
|
ret = append(ret, c.collectModuleResourceInstances(ms)...)
|
|
}
|
|
sort.Slice(ret, func(i, j int) bool {
|
|
return ret[i].Less(ret[j])
|
|
})
|
|
return ret, diags
|
|
}
|
|
|
|
func (c *StateMeta) collectModuleResourceInstances(ms *states.Module) []addrs.AbsResourceInstance {
|
|
var ret []addrs.AbsResourceInstance
|
|
for _, rs := range ms.Resources {
|
|
ret = append(ret, c.collectResourceInstances(ms.Addr, rs)...)
|
|
}
|
|
return ret
|
|
}
|
|
|
|
func (c *StateMeta) collectResourceInstances(moduleAddr addrs.ModuleInstance, rs *states.Resource) []addrs.AbsResourceInstance {
|
|
var ret []addrs.AbsResourceInstance
|
|
for key := range rs.Instances {
|
|
ret = append(ret, rs.Addr.Instance(key).Absolute(moduleAddr))
|
|
}
|
|
return ret
|
|
}
|